Received: from eggs.gnu.org ([2001:4830:134:3::10]:46653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1qqD-0006hw-2U for qemu-devel@nongnu.org; Thu, 26 Nov 2015 02:19:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1qq9-0006Ex-VF for qemu-devel@nongnu.org; Thu, 26 Nov 2015 02:19:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1qq9-0006En-Qu for qemu-devel@nongnu.org; Thu, 26 Nov 2015 02:19:37 -0500 From: Markus Armbruster References: <1447776349-2344-1-git-send-email-armbru@redhat.com> <20151126040225.GD14630@ad.usersys.redhat.com> Date: Thu, 26 Nov 2015 08:19:34 +0100 In-Reply-To: <20151126040225.GD14630@ad.usersys.redhat.com> (Fam Zheng's message of "Thu, 26 Nov 2015 12:02:25 +0800") Message-ID: <87y4dlmdmh.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] error: Document how to accumulate multiple errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Fam Zheng writes: > On Tue, 11/17 17:05, Markus Armbruster wrote: >> Suggested-by: Eric Blake >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- >> include/qapi/error.h | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/include/qapi/error.h b/include/qapi/error.h >> index 4d42cdc..b2362a5 100644 >> --- a/include/qapi/error.h >> +++ b/include/qapi/error.h >> @@ -76,6 +76,23 @@ >> * But when all you do with the error is pass it on, please use >> * foo(arg, errp); >> * for readability. >> + * >> + * Receive and accumulate multiple errors (first one wins): >> + * Error *err = NULL, *local_err = NULL; >> + * foo(arg, &err); >> + * bar(arg, &local_err); >> + * error_propagate(&err, local_err); >> + * if (err) { >> + * handle the error... >> + * } >> + * >> + * Do *not* "optimize" this to >> + * foo(arg, &err); >> + * bar(arg, &err); // WRONG! >> + * if (err) { >> + * handle the error... >> + * } >> + * because this may pass a non-null err to bar(). >> */ >> >> #ifndef ERROR_H >> -- >> 2.4.3 >> >> > > Curious if there is a recommended way to report both error messages to caller, > rather than overwriting the first with the second? The documentation above is about keeping the first and throwing away the second, i.e. first one wins. I haven't seen in "last one wins" the code, yet. How to do it is thus left as exercise to the reader. You can only return one *error*. You can still combine multiple *messages* into one error. There is no recommended way, at least not yet. You could use the hint mechanism to append additional messages: foo(arg, &err); bar(arg, &err2); if (err2) { error_append_hint(err, "additionally, %s", error_get_pretty(err2)); error_free(err2); } Just an example, the wording of the hint is probably not a good idea. You may want to modify the first message, too. The obvious technique for receiving, modifying and passing on an error: frob(arg, &err) error_setg(errp, "Could not frobnicate: %s", error_get_pretty(local_err));