Received: from eggs.gnu.org ([2001:4830:134:3::10]:51979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyhRm-0005fo-Px for qemu-devel@nongnu.org; Tue, 17 Nov 2015 09:41:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyhRh-0005bx-Pj for qemu-devel@nongnu.org; Tue, 17 Nov 2015 09:41:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyhRh-0005bt-KQ for qemu-devel@nongnu.org; Tue, 17 Nov 2015 09:41:21 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 53C3F43EB0 for ; Tue, 17 Nov 2015 14:41:21 +0000 (UTC) From: Markus Armbruster References: <1447397748-24920-1-git-send-email-bsd@redhat.com> <1447397748-24920-3-git-send-email-bsd@redhat.com> Date: Tue, 17 Nov 2015 15:41:17 +0100 In-Reply-To: <1447397748-24920-3-git-send-email-bsd@redhat.com> (Bandan Das's message of "Fri, 13 Nov 2015 01:55:48 -0500") Message-ID: <87y4dwpu2a.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 2/2] i440fx: print an error message if user tries to enable iommu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bandan Das Cc: qemu-devel@nongnu.org, mst@redhat.com Bandan Das writes: > There's no indication of any sort that i440fx doesn't support > "iommu=on" > > Reviewed-by: Eric Blake > Signed-off-by: Bandan Das > --- > hw/pci-host/piix.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c > index 7b2fbf9..715208b 100644 > --- a/hw/pci-host/piix.c > +++ b/hw/pci-host/piix.c > @@ -34,6 +34,7 @@ > #include "sysemu/sysemu.h" > #include "hw/i386/ioapic.h" > #include "qapi/visitor.h" > +#include "qemu/error-report.h" > > /* > * I440FX chipset data sheet. > @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) > static void i440fx_realize(PCIDevice *dev, Error **errp) > { > dev->config[I440FX_SMRAM] = 0x02; > + > + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { > + error_report("warning: i440fx doesn't support emulated iommu"); > + } > } > > PCIBus *i440fx_init(const char *host_type, const char *pci_type, Hmm. If I understand things correctly, we add property "iommu" to *any* machine, whether it supports it or not (see machine_initfn() in hw/core/machine.c). Most machines don't support it. You add a warning to one of them. Why to that one and not the others? Shouldn't we add properties only to machines where they make sense? Adding them indiscrimiately defeats QOM introspection.