From: OGAWA Hirofumi Subject: Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size Date: Tue, 04 Feb 2014 23:50:53 +0900 Message-ID: <87y51rue2a.fsf@devron.myhome.or.jp> References: <1387953050-2692-1-git-send-email-linkinjeon@gmail.com> <87ioswx1xq.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Amit Sahrawat To: Namjae Jeon Return-path: In-Reply-To: (Namjae Jeon's message of "Tue, 4 Feb 2014 19:20:27 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Namjae Jeon writes: > 2014-02-03, OGAWA Hirofumi : >> Namjae Jeon writes: >> >>> From: Namjae Jeon >>> >>> Add i_disksize to represent uninitialized allocated size. >>> And mmu_private represent initialized allocated size. >> >> Don't we need to update ->i_disksize after cont_write_begin()? > We don't need to update i_disksize after cont_write_begin. > It is taken care by the fat_get_block after the allocation. > For all write paths we align the mmu_private and i_disksize from > fat_fill_inode and fat_get_block. fat_fill_inode() just set i_disksize to i_size. So, it is not aligned by cluster size or block size. E.g. ->mmu_private = 500. Then, cont_write_begin() can set ->mmu_private to 512 on some case. In this case, fat_get_block() will not be called, because no new allocation. If this is true, it would be possible to have ->mmu_private == 512 and ->i_disksize == 500. I'm missing something? Thanks. -- OGAWA Hirofumi