Received: from eggs.gnu.org ([2001:4830:134:3::10]:41345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnT6U-0007Zh-7H for qemu-devel@nongnu.org; Mon, 02 Dec 2013 08:00:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnT6P-0005T7-Ok for qemu-devel@nongnu.org; Mon, 02 Dec 2013 07:59:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnT6P-0005T2-HX for qemu-devel@nongnu.org; Mon, 02 Dec 2013 07:59:53 -0500 From: Markus Armbruster References: <4918e89476b8da916be2964ec41578b50d569a37.1385969450.git.peter.crosthwaite@xilinx.com> <529C7D03.4080109@suse.de> Date: Mon, 02 Dec 2013 13:59:48 +0100 In-Reply-To: (Peter Maydell's message of "Mon, 2 Dec 2013 12:36:08 +0000") Message-ID: <87y5439znf.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH arm-devs v4 3/4] hw/timer: Introduce ARM A9 Global Timer. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , Andreas =?utf-8?Q?F=C3=A4rber?= , QEMU Developers Peter Maydell writes: > On 2 December 2013 12:28, Andreas F=C3=A4rber wrote: >> Am 02.12.2013 08:36, schrieb Peter Crosthwaite: >>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore. >>> The timer is shared but each CPU has a private independent comparator >>> and interrupt. >>> + dc->no_user =3D 1; >> >> There is a series from Markus waiting on my review that renames and >> investigates all uses of this field. Please explain why you are using it >> (in form of a comment) or drop it. There's only a numeric property >> above, so likely the latter. > > It's a sysbus device so it's never going to be usable via device-add. Not sure about "never", but it doesn't matter now. > I think Markus' patchset puts that check in the sysbus base class > though, which would make dropping the no_user here correct. Yes.