From: Eric Anholt Subject: Re: [PATCH 0/2] intel-gen4asm: modernization Date: Mon, 09 May 2011 13:45:45 -0700 Message-ID: <87y62f61s6.fsf@pollan.anholt.net> References: <1304706867-29308-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1142929608==" Return-path: In-Reply-To: <1304706867-29308-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1142929608== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 6 May 2011 11:34:25 -0700, Ben Widawsky wrote: >=20 > I attempted to merge the assembler into the modern age. Ideally we should= be > able to push the changes back into mesa since it appears Haihao added some > relevant structs. >=20 > I've only done very limited testing on this for my usecase. Wondering if > this seems acceptable to push? What is the best way to actually test > this? >=20 > Most of the changes are copy-paste, but only moderate amount of merging > occurred in brw_structs.h, and brw_defines.h You should probably test that generation of existing code (2d driver, probably vaapi?) hasn't changed. Also that you've run the newly-changed generated code somehow. There's a testsuite for round-trip asm-to-disasm, but it looks like that's already pre-broken by some past change. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3IUnkACgkQHUdvYGzw6vcmRACdGFpi0lexa/O7wIKYryBZn1js 5zUAnAx3D9TcC97M+8KTBIRLHmjkWuHE =XAfF -----END PGP SIGNATURE----- --=-=-=-- --===============1142929608== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1142929608==--