From: Eric Anholt Subject: Re: [PATCH] agp/intel: Fix dma mask for Sandybridge Date: Mon, 23 Aug 2010 07:02:16 -0700 Message-ID: <87y6bxqvfb.fsf@pollan.anholt.net> References: <20100823013507.GA29442@zhen-devel.sh.intel.com> <20100823054303.GC29442@zhen-devel.sh.intel.com> <20100823061922.GD29442@zhen-devel.sh.intel.com> <20100823064854.GE29442@zhen-devel.sh.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1277700076==" Return-path: In-Reply-To: <20100823064854.GE29442@zhen-devel.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang , Takashi Iwai Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1277700076== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 23 Aug 2010 14:48:54 +0800, Zhenyu Wang w= rote: > On 2010.08.23 08:31:42 +0200, Takashi Iwai wrote: > > > bit 31 bit 11 bit 4 bit 0 > > > |<-physical addr 31:12->|<-physical addr 39:32->|<-cache ctl 3:1->= |valid| > >=20 > > Then I really don't understand why it works. > > You shift 28bit and mask with 0xff. Obviously it overwrite bits 0:3 > > with original 28:31 bits. Masking 0xff0 fixes the issue. > >=20 >=20 > ah, sorry, my stupid. Thanks for catching this! >=20 > Subject: [PATCH] agp/intel: fix physical address mask bits for sandybridge >=20 > It should shift bit 39-32 into pte's bit 11-4. Applied. Thanks! --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkxyf2gACgkQHUdvYGzw6vdUCwCghkscXUjV2TVmkXga5LiJPiN1 Dr8Ani+Voxx5jpvOfzNsUUEVA9e2P/x8 =yiHB -----END PGP SIGNATURE----- --=-=-=-- --===============1277700076== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1277700076==--