From: Markus Armbruster Subject: Re: [Patch] fix xenfb_update_screen bogus rect Date: Thu, 29 Jan 2009 15:44:57 +0100 Message-ID: <87y6wuw4ra.fsf@pike.pond.sub.org> References: <497E784B.7060003@jp.fujitsu.com> <497ED10A.76E4.0078.0@novell.com> <498009CC.1000101@jp.fujitsu.com> <871vun33jp.fsf@pike.pond.sub.org> <4981A70D.1010905@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <4981A70D.1010905@jp.fujitsu.com> (Akio Takebe's message of "Thu\, 29 Jan 2009 21\:54\:37 +0900") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Akio Takebe Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Akio Takebe writes: > Hi, Markus > > Markus Armbruster wrote: >> Akio Takebe writes: [...] >>> diff -r 83b71f4b5cb2 drivers/xen/fbfront/xenfb.c >>> --- a/drivers/xen/fbfront/xenfb.c Tue Jan 20 13:28:35 2009 +0000 >>> +++ b/drivers/xen/fbfront/xenfb.c Thu Jan 29 01:24:06 2009 +0900 >>> @@ -213,17 +213,23 @@ >> >> Please use -p with diff. >> >>> if (xenfb_queue_full(info)) >>> return; >>> - mutex_lock(&info->mm_lock); >>> - >>> spin_lock_irqsave(&info->dirty_lock, flags); >>> - y1 = info->y1; >>> - y2 = info->y2; >>> - x1 = info->x1; >>> - x2 = info->x2; >>> - info->x1 = info->y1 = INT_MAX; >>> - info->x2 = info->y2 = 0; >>> + if (info->dirty){ >>> + info->dirty = 0; >>> + y1 = info->y1; >>> + y2 = info->y2; >>> + x1 = info->x1; >>> + x2 = info->x2; >>> + info->x1 = info->y1 = INT_MAX; >>> + info->x2 = info->y2 = 0; >>> + } else { >>> + spin_unlock_irqrestore(&info->dirty_lock, flags); >>> + return; >>> + } >>> spin_unlock_irqrestore(&info->dirty_lock, flags); >>> + mutex_lock(&info->mm_lock); >>> + >>> list_for_each_entry(map, &info->mappings, link) { >>> if (!map->faults) >>> continue; >> >> Careful, locking is rather delicate here. Please read the big comment >> "There are three locks:", then explain why moving the locking of >> mm_lock is safe. >> > Thank you for your review. My pleasure. I have to thank for your fix! > First, I thought mm_lock just protected the mappings, > and the dirty rectangle was protected by the dirty_lock. > So I moved the mm_lock. > Also when I tested the patch, I didn't get any problem. Subtle locking bugs are notoriously hard to demonstrate by testing. > Do you mean the narrow point of between unloking dirty_lock and locking mm_lock > in xenfb_update_screen() may be not safe? > Do you find any critical cases? > > Best Regards, > > Akio Takebe Your proposed change might be fine, it might be racy, I don't know. What I do know is that it invalidates the comment I mentioned. That's a nasty trap for the unwary, and clearly a bug as far as I'm concerned. I strongly recommend to either revert the locking change, or fix the comment to match the new code.