From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20071016210907.GA10870@thorin> <87k5pmqgyr.fsf@xs4all.nl>
	<20071017085052.GA17346@thorin> <877ilmqcpt.fsf@xs4all.nl>
	<20071017102602.GA21040@thorin>
Mail-Copies-To: mgerards@xs4all.nl
Date: Wed, 17 Oct 2007 12:35:03 +0200
In-Reply-To: <20071017102602.GA21040@thorin> (Robert Millan's message of "Wed, 
	17 Oct 2007 12:26:02 +0200")
Message-ID: <87y7e2owq0.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [PATCH] split realmode and loader routines out of startup.S
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>

Robert Millan <rmh@aybabtu.com> writes:

> On Wed, Oct 17, 2007 at 12:04:14PM +0200, Marco Gerards wrote:
>> >
>> > Linking required wrapping a lot of references with EXT_C() macro, so I opted
>> > for #include (note this is done for lzo1x.S already).
>> 
>> Is using EXT_C a problem?  I don't know this code too well,
>> unfortunately :(
>
> No.  Maybe linking bring in other problems, but EXT_C per se isn't a big deal.
> Though do we really want it?  It doesn't seem to be a problem for lzo1x.S.

Including is not a big problem for me.  It should just not become a
common practise.  It's easy to change so I am fine with it.

--
Marco