Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09FDFC433FE for ; Tue, 22 Nov 2022 07:18:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 436B51662; Tue, 22 Nov 2022 08:17:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 436B51662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1669101479; bh=nRvXcbnAAelOIt7W/5rY4QQnU8my/2kjGFvOcYKFKLI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KegWlrBUpFIuv/f7YeutwseIvU8WrVNiZ4HViKYzn8n7FzJh/p1V0ZcJbsq75QIT5 oGxKYBo/TlgNvNDhfpFQhmui2LXL8HWVBuZ/kMybk/ZOul7SDnuaDXBOQEdWcbB6U9 1oVDQuzRGhm/jsTILtks7ib4VvISuxMpu5Q1PUq4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D2DC4F8026A; Tue, 22 Nov 2022 08:17:08 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 86050F80272; Tue, 22 Nov 2022 08:17:07 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1E1D5F80149 for ; Tue, 22 Nov 2022 08:17:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1E1D5F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Ysqr2B5Z"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="3WUYspX1" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5310621EF3; Tue, 22 Nov 2022 07:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669101422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+UhD1ad2veeikmHqCQC9DmPwNtUNk0xYfG3WvlpNyfw=; b=Ysqr2B5ZbGK4ZdKXEGWWnLIvDw0eql019Dm7VjT0fBV2vyFM6LaChw7UOX8BXXd3PAX0aF 43vHOF5uhT7lTbhnEMNPD+1i749XRJZBeqogH3BGOEXC+kTYefz1BNQoNxXzNpjiblaZOd jqOwYk5Wmalzgo/MVysGt4gW6OHJ60E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669101422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+UhD1ad2veeikmHqCQC9DmPwNtUNk0xYfG3WvlpNyfw=; b=3WUYspX1R79gkd3+bofJqVzvdo/b26GV24pytG25R5jhm3oRL2SH6GCpb/Ls+4/9vvGuvl gFWy4faH4uJEvRCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 379E113AA1; Tue, 22 Nov 2022 07:17:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fbK4DG53fGM1dAAAMHmgww (envelope-from ); Tue, 22 Nov 2022 07:17:02 +0000 Date: Tue, 22 Nov 2022 08:17:01 +0100 Message-ID: <87zgcjv4pe.wl-tiwai@suse.de> From: Takashi Iwai To: Jiao Zhou Subject: Re: [PATCH] kernel: Add HP Device 0x8711 to force connect list In-Reply-To: <20221116194550.705566-1-jiaozhou@google.com> References: <20221116194550.705566-1-jiaozhou@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: ALSA development X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 16 Nov 2022 20:45:50 +0100, Jiao Zhou wrote: > > Signed-off-by: Jiao Zhou > --- > HDMI audio is not working on the HP EliteDesk 800 G6 because the pin is > unconnected. This issue can be resolved by using the 'hdajackretask' > tool to override the unconnected pin to force it to connect. > > Change-Id: If7ffc0691466078e59240f9eab89de562b3f119d Please reformat your patch and resubmit. As of this submission, the comment about "HDMI audio is not working..." won't be taken as the patch description since you've put after the line "---". The comment there will be discarded. Also please drop the useless Change-Id tag. And, align the patch subject line with others. In this case, use "ALSA:" prefix, at best, "ALSA: hda/hdmi:" instead of "kernel:". Last but not least, put the subsystem maintainers (me in this case) to Cc at submission. thanks, Takashi > --- > sound/pci/hda/patch_hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 21edf7a619f0..7a40ddfd695a 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -1975,6 +1975,7 @@ static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t cvt_nid) > static const struct snd_pci_quirk force_connect_list[] = { > SND_PCI_QUIRK(0x103c, 0x870f, "HP", 1), > SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1), > + SND_PCI_QUIRK(0x103c, 0x8711, "HP", 1), > SND_PCI_QUIRK(0x1462, 0xec94, "MS-7C94", 1), > SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", 1), > {} > -- > 2.38.1.431.g37b22c650d-goog >