Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172C3C433E2 for ; Fri, 28 Aug 2020 16:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EBFB207DF for ; Fri, 28 Aug 2020 16:06:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cjr.nz header.i=@cjr.nz header.b="BncZin+J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725911AbgH1QGA (ORCPT ); Fri, 28 Aug 2020 12:06:00 -0400 Received: from mx.cjr.nz ([51.158.111.142]:19002 "EHLO mx.cjr.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725814AbgH1QF5 (ORCPT ); Fri, 28 Aug 2020 12:05:57 -0400 Received: from authenticated-user (mx.cjr.nz [51.158.111.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pc) by mx.cjr.nz (Postfix) with ESMTPSA id D85667FCFE; Fri, 28 Aug 2020 16:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjr.nz; s=dkim; t=1598630753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kCacCX6pGTDIvMVVA9V19Ct4m61XuoZToQJAlbdWPAM=; b=BncZin+JyFK/l86AfHJBiH42ucDs29OZmr5IIskfh0q03HJ4wH9766hDmMzjgBiN1sJgvV NeiRZg5/ipWsEU7EIHq02nFUxl1reVBAmpOQVy8vYAW1MBP7tXUh88bxXKk8aNXA8w8FBc GWs0x/Qp225QuIboOgVkp7FYZi/UKQzEiRl2Xqs+soXgqL8/Q/Er4fdns7ZOqxKZ/wtSdL tJb/m1b3fipQc2cgPvIYo+BFEu9aBS401sUSm7Sbx7VN2aiHw/a3I4e6Mxlg1lhWoMQVUD awzQ+8XVfInn0dfkYZ7CX6eSCMa4IgsXqhZTeLRVKT5zzvsMFlRaqr312k++DA== From: Paulo Alcantara To: Shyam Prasad N Cc: CIFS , Steve French Subject: Re: [PATCH] cifs: fix check of tcon dfs in smb1 In-Reply-To: References: <20200827142019.26968-1-pc@cjr.nz> Date: Fri, 28 Aug 2020 13:05:48 -0300 Message-ID: <87zh6eiwmb.fsf@cjr.nz> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Shyam Prasad N writes: > These changes look good to me. > However, I see other places in the code where these flags are checked > separately. Don't we want to replace all those with is_tcon_dfs() > calls? Yes, probably. We could do that in separate patches, however it would require a lot of testing. I initially did it for dfs mount because it was easily reproducible when running smb1 tests against Windows 2019. Thanks for pointing that out. I can take a look at it when time allows.