Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id t8UF08jL028284 for ; Wed, 30 Sep 2015 11:00:09 -0400 Received: by laclj5 with SMTP id lj5so49633105lac.3 for ; Wed, 30 Sep 2015 08:00:06 -0700 (PDT) From: Rasmus Villemoes To: Stephen Smalley Cc: Paul Moore , Eric Paris , James Morris , "Serge E. Hallyn" , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, Joe Perches Subject: Re: [PATCH 5/5] selinux: use sprintf return value References: <1443220459-11042-1-git-send-email-linux@rasmusvillemoes.dk> <1443220459-11042-6-git-send-email-linux@rasmusvillemoes.dk> <560AD5AF.4070400@tycho.nsa.gov> Date: Wed, 30 Sep 2015 17:00:04 +0200 In-Reply-To: <560AD5AF.4070400@tycho.nsa.gov> (Stephen Smalley's message of "Tue, 29 Sep 2015 14:17:19 -0400") Message-ID: <87zj04j6kr.fsf@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: On Tue, Sep 29 2015, Stephen Smalley wrote: > On 09/25/2015 06:34 PM, Rasmus Villemoes wrote: >> sprintf returns the number of characters printed (excluding '\0'), so >> we can use that and avoid duplicating the length computation. >> >> Signed-off-by: Rasmus Villemoes > > Acked-by: Stephen Smalley Thanks. I also like Joe's add-on suggestion (except I'd declare user, role, type as const char*). Rasmus