From: Eric Anholt Subject: Re: [PATCH 03/12] Don't use GetScratchPixmapHeader for shadow pixmaps Date: Mon, 04 Aug 2014 09:58:40 -0700 Message-ID: <87zjfknqdb.fsf@eliezer.anholt.net> References: <1406243908-1123-1-git-send-email-keithp@keithp.com> <1406243908-1123-4-git-send-email-keithp@keithp.com> <87oaw6e2i4.fsf@eliezer.anholt.net> <86d2cmdqmh.fsf@hiro.keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0266874566==" Return-path: In-Reply-To: <86d2cmdqmh.fsf@hiro.keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Keith Packard , xorg-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0266874566== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Keith Packard writes: > Eric Anholt writes: > >> This change appears to be unrelated, and possibly harmful (if X has >> dropped the last ref to the BO, but it's still the scanout buffer, a new >> allocation would now reuse the BO and scribble on scanout until the next >> modeset happens). > > Yeah, it's unrelated. intel_allocate_framebuffer calls disable_reuse, so > there's no need to call it from these two other places. I'll split that > change out into a separate patch with separate comment. > >> Unrelated whitespace. > > There are a bunch of whitespace fixups; should I pull those into a > separate patch or just leave them scattered in the first patch to change > a file? One patch at the front is fine with me. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJT37vAAAoJELXWKTbR/J7orycQALWCfClEFZaeOMNWPcHpiPgt EsP6P/vhFatX2AiiCLmUUj/NIGjOBnFtHUqR3tslqz9U23ibNX3rT9Nc3oNWb+6O YaC3REBy+HtojpdyNC8jm0V7gi4sj18n6TY4hougNM1wzhzJNWl4ziLf/lQJFhX9 bKTmaqzYWgJZxfYKfX7V7Yq3dHPHtud8hwsi+tLFT+GLJa09eXLaluwkwFLEoSbG Ht/Yc5Hgb+HbcwIX8/NwdFxyY/whejYI/V9hkqJbgQunF7IRG64PmTkVpshf86eL MLb3oQvDhNJqyrn3DgFiZ8Jwfdm9Vah34TYv+ScJOut4+u54tUFt+BemFt3V6yDF 4alwkMlPKNMlvFQHkh1H6WcsahTvLEMjn2Hq5V6pb7PjpVHBhb7kaWLufeBOf6v9 AI694IOGVePwwbtnOQ60ty9uOKGUpvKCsabFUlvBdsfYWCZmClJXvL0JtMa5r+r0 68MKGony+LEcx0fkCuKZ7Nn6s332snN36Q2F810jUYQnzbmyVz6iYCOwLi0jhxW9 Ed1o7SGALpD3JYu7O/D+JOuyntX9+2y55vSXZwc4kauEUMirTbfjUtB9/Qt2775b XYPgfL7pWRK4Sr+SoSy7G2kUby42aiW9yaXXpIfjyp9jqdwEtfi7Mi3F11MWMaDw lZ+f3fnISTKnTlUEruHS =DQxT -----END PGP SIGNATURE----- --=-=-=-- --===============0266874566== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0266874566==--