Received: from eggs.gnu.org ([2001:4830:134:3::10]:55597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsTQo-00060x-Bx for qemu-devel@nongnu.org; Mon, 16 Dec 2013 03:21:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsTQi-00077R-P7 for qemu-devel@nongnu.org; Mon, 16 Dec 2013 03:21:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsTQi-00077E-F9 for qemu-devel@nongnu.org; Mon, 16 Dec 2013 03:21:32 -0500 From: Markus Armbruster References: <1385656023-11519-1-git-send-email-armbru@redhat.com> <52AE12F3.4050401@suse.de> Date: Mon, 16 Dec 2013 09:21:22 +0100 In-Reply-To: <52AE12F3.4050401@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?= =?utf-8?Q?'s?= message of "Sun, 15 Dec 2013 21:37:07 +0100") Message-ID: <87zjo1mcjh.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/10] Clean up and fix no_user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: peter.maydell@linaro.org, marcel.a@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, borntraeger@de.ibm.com Andreas F=C3=A4rber writes: > Am 28.11.2013 17:26, schrieb armbru@redhat.com: >> Markus Armbruster (10): >> qdev: Replace no_user by cannot_instantiate_with_device_add_yet >> sysbus: Set cannot_instantiate_with_device_add_yet >> cpu: Document why cannot_instantiate_with_device_add_yet >> apic: Document why cannot_instantiate_with_device_add_yet >> pci-host: Consistently set cannot_instantiate_with_device_add_yet >> ich9: Document why cannot_instantiate_with_device_add_yet >> piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet >> vt82c686: Clean up use of cannot_instantiate_with_device_add_yet >> isa: Clean up use of cannot_instantiate_with_device_add_yet >> qdev: Do not let the user try to device_add when it cannot work > > I've applied all except for the ISA patch, which doesn't feature a > Reviewed-by yet. > > https://github.com/afaerber/qemu-cpu/commits/qom-next > > I'd appreciate if some previous reviewer can comment on whether any > issues have been resolved satisfactorily. Paolo answered a question I posted along with my RFC series, Peter pointed out two wires I missed in v1 (fixed in v2), Marcel examined v3, but didn't feel familiar enough with the code to risk a formal Reviewed-by. I asked Anthony to review a couple of times, and he said he intended to. However, consider the timeline: Oct 10 RFC * you, Paolo, Kevin and Anthony commented Oct 17 v1 Oct 29 v2: address Peter Maydell's review * Some commit messages improved * Use QOM cast macros instead of .parent_class [PATCH 05] * keep cannot_instantiate_with_device_add_yet for port92, isa-pit, kvm-pit, m48t59_isa, mc146818rtc [PATCH 09] Oct 30 v3: address Eric Blake's and Marcel Apfelbaum's review * Clean up a harmless editing accident in PATCH 07 * Simplify PATCH 10 slightly Nov 28 v4: straightforward rebase (only PATCH 10/10 conflicts) It's been more than six weeks since the last review comment. I doubt more waiting (and more rebasing) will be productive.