From: Kalle Valo Date: Fri, 5 Jul 2013 09:29:21 +0300 Subject: [ath9k-devel] [PATCH v3 1/9] ath10k: decouple pci start/stop logic In-Reply-To: <1372147152-26799-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 25 Jun 2013 09:59:04 +0200") References: <1371041642-20273-1-git-send-email-michal.kazior@tieto.com> <1372147152-26799-1-git-send-email-michal.kazior@tieto.com> <1372147152-26799-2-git-send-email-michal.kazior@tieto.com> Message-ID: <87zju1h64e.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Michal Kazior writes: > Split logic that prepares the device for BMI > phase/cleans up related resources. > > This is necessary for ath10k to be able to restart > hw on the fly without reloading the module. > > Signed-off-by: Michal Kazior > --- [...] > --- a/drivers/net/wireless/ath/ath10k/hif.h > +++ b/drivers/net/wireless/ath/ath10k/hif.h > @@ -46,8 +46,11 @@ struct ath10k_hif_ops { > void *request, u32 request_len, > void *response, u32 *response_len); > > + /* Post BMI phase, after FW is loaded. Starts regular operation */ > int (*start)(struct ath10k *ar); > > + /* Clean up what start() did. This does not revert to BMI phase. If > + * desired so, call deinit() and init() */ > void (*stop)(struct ath10k *ar); The last sentence in the comment can be removed, right? Or I misunderstand the meaning. -- Kalle Valo