From: Dmitry Subject: Re: [PATCH 04/11] quota: make dquot lists per-sb Date: Wed, 06 Oct 2010 14:40:06 +0400 Message-ID: <87zkur8v09.fsf@dmon-lap.sw.ru> References: <1286302827-31043-1-git-send-email-dmonakhov@gmail.com> <1286302827-31043-5-git-send-email-dmonakhov@gmail.com> <20101006102224.GE3676@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org, Dmitry Monakhov To: Jan Kara Return-path: Received: from mailhub.sw.ru ([195.214.232.25]:18729 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754217Ab0JFKl6 (ORCPT ); Wed, 6 Oct 2010 06:41:58 -0400 In-Reply-To: <20101006102224.GE3676@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 6 Oct 2010 12:22:24 +0200, Jan Kara wrote: > On Tue 05-10-10 22:20:20, Dmitry Monakhov wrote: > > Currently quota lists are global which is very bad for scalability. > > * inuse_lists -> sb->s_dquot->dq_inuse_list > > * free_lists -> sb->s_dquot->dq_free_lists > > * Add per sb lock for quota's lists protection > > > > Do not remove dq_lists_lock is used now only for protecting quota_hash > Hmm, wouldn't be it easier to just convert lists to per-sb ones in this > patch, convert hash in the next patch, and convert the spinlock in the last > one. You wouldn't have to have both spinlocks in parallel... But that's > just a nit ;). I've hoped that this would be easier to read and review. IMHO This that approach one may understand my ideas just by looking to diff. But if you want i can destroy and reassemble locking logic in one patch :) > > Honza > -- > Jan Kara > SUSE Labs, CR > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html