From: OGAWA Hirofumi Subject: Re: [patch 5/9] fs: remove unneeded DCACHE_UNHASHED tricks Date: Wed, 18 Nov 2009 20:54:48 +0900 Message-ID: <87zl6k3v5j.fsf@devron.myhome.or.jp> References: <200911172256.nAHMuUSi027629@imap1.linux-foundation.org> <20091118042914.GD21813@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, davem@davemloft.net, davidel@xmailserver.org, hch@lst.de, jens.axboe@oracle.com, mszeredi@suse.cz To: Nick Piggin Return-path: Received: from mail.parknet.jp ([210.171.162.6]:50134 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbZKRMEM (ORCPT ); Wed, 18 Nov 2009 07:04:12 -0500 In-Reply-To: <20091118042914.GD21813@wotan.suse.de> (Nick Piggin's message of "Wed, 18 Nov 2009 05:29:14 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Nick Piggin writes: > + return dynamic_dname(dentry, buffer, buflen, "anon_inode:%s", > + dentry->d_name.name, dentry->d_inode->i_ino); > +} This may be typo? The fmt has only "%s", but args are ->d_name.name and ->i_no. If so, it sounds like we would need to add __attribute__ ((format(printf, ...))) stuff to dynamic_dname(). Thanks. -- OGAWA Hirofumi