Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqZAd-0007BI-K9 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqZAZ-00078l-73 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:38 -0400 Received: from [199.232.76.173] (port=54996 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqZAY-00078M-Cn for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1026) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqZAX-0005Px-S4 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:34 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8NLEWdF005413 for ; Wed, 23 Sep 2009 17:14:33 -0400 Subject: Re: [Qemu-devel] [PATCH 1/2] cirrus_vga: also assign gr0/1 when writting shadow_gr0/1 References: <6b781a1bec0f609301d111b0389fa9784f9629c9.1253536404.git.quintela@redhat.com> From: Markus Armbruster Date: Wed, 23 Sep 2009 21:16:30 +0200 In-Reply-To: <6b781a1bec0f609301d111b0389fa9784f9629c9.1253536404.git.quintela@redhat.com> (Juan Quintela's message of "Mon\, 21 Sep 2009 14\:35\:17 +0200") Message-ID: <87zl8lbhf5.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org Juan Quintela writes: > This is a regression/bug caused by previous vga_cleanup. This fixes > Ubuntu installer reported by: > Pierre Riteau > > Signed-off-by: Juan Quintela Broken in commit 22286bc6. Patch restores old behavior of cirrus_vga_ioport_write() for address 0x3cf. But what about cirrus_mmio_blt_write() for address CIRRUS_MMIO_BLTBGCOLOR + 0? There we had cirrus_hook_write_gr(s, 0x00, value); which did not update s->vga.gr[0x00]. It does with your patch, doesn't it? Same for CIRRUS_MMIO_BLTFGCOLOR + 0.