From: OGAWA Hirofumi Subject: Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label Date: Tue, 04 Aug 2009 19:32:29 +0900 Message-ID: <87zlafswci.fsf@devron.myhome.or.jp> References: <1248274841-3586-1-git-send-email-ext-jorg.2.schummer@nokia.com> <1248428635-26073-1-git-send-email-ext-jorg.2.schummer@nokia.com> <87fxclmhxy.fsf@devron.myhome.or.jp> <1248691635.4618.43.camel@jorg-desktop> <87ljmas5ym.fsf@devron.myhome.or.jp> <1249375357.5736.53.camel@jorg-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-kernel\@vger.kernel.org" , "linux-fsdevel\@vger.kernel.org" To: =?iso-8859-1?Q?J=F6rg?= Schummer Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:34144 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932513AbZHDKcd (ORCPT ); Tue, 4 Aug 2009 06:32:33 -0400 In-Reply-To: <1249375357.5736.53.camel@jorg-desktop> (=?iso-8859-1?Q?=22J?= =?iso-8859-1?Q?=F6rg?= Schummer"'s message of "Tue, 04 Aug 2009 11:42:37 +0300") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: J=F6rg Schummer writes: > On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote: >> J=F6rg Schummer writes: > >> BTW, the patch has several bugs. fat_get_label_entry() doesn't check >> IS_FREE(), is it right? fat_create_label_entry() doesn't initialize = all >> timestamp in the case of msdos. spin_lock() usage is wrong. and more= =2E.. > > After reviewing the patch again, I did notice some additional problem= s > (I suppose that was the "and more..."). If and when I have time again= , I > might take a closer look at it again. > > Thanks for your help until now! No problem at all. Thanks for your work. --=20 OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html