Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3BEC2BB85 for ; Thu, 16 Apr 2020 08:36:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7E712063A for ; Thu, 16 Apr 2020 08:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7E712063A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOzzv-0007cu-43; Thu, 16 Apr 2020 08:35:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOzzu-0007co-94 for xen-devel@lists.xenproject.org; Thu, 16 Apr 2020 08:35:46 +0000 X-Inumbo-ID: 43b92f28-7fbd-11ea-9e09-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 43b92f28-7fbd-11ea-9e09-bc764e2007e4; Thu, 16 Apr 2020 08:35:45 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A635CAC4D; Thu, 16 Apr 2020 08:35:43 +0000 (UTC) Subject: Re: [PATCH] x86/boot: Fix early exception handling with CONFIG_PERF_COUNTERS To: Andrew Cooper References: <20200415173911.13286-1-andrew.cooper3@citrix.com> <72b35bfa-e795-72c0-d925-924ca18711df@suse.com> <4c418f62-14b5-1f77-9bf3-979b5d1f56d9@citrix.com> From: Jan Beulich Message-ID: <88658e82-e38a-6230-e6ab-7cfd00e4f19f@suse.com> Date: Thu, 16 Apr 2020 10:35:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <4c418f62-14b5-1f77-9bf3-979b5d1f56d9@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Julien Grall , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 16.04.2020 10:19, Andrew Cooper wrote: > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -679,7 +679,11 @@ handle_exception_saved: >  1:      movq  %rsp,%rdi >          movzbl UREGS_entry_vector(%rsp),%eax >          leaq  exception_table(%rip),%rdx > -        PERFC_INCR(exceptions, %rax, %rbx) > +#ifdef CONFIG_PERF_COUNTERS > +        lea   per_cpu__perfcounters(%rip), %rdi > +        add   STACK_CPUINFO_FIELD(per_cpu_offset)(%r14), %rdi > +        incl  ASM_PERFC_exceptions * 4(%rdi, %rax, 4) > +#endif >          mov   (%rdx, %rax, 8), %rdx >          INDIRECT_CALL %rdx >          mov   %r15, STACK_CPUINFO_FIELD(xen_cr3)(%r14) > > > If you're happy with that? I'm afraid I'm not - you can't use %rdi here, it already holds the called function's argument. I'd be fine with %rcx used instead. Jan