From: Michel Thierry Subject: Re: [PATCH v4 04/13] drm/i915/guc: Implement response handling in send_mmio() Date: Fri, 23 Mar 2018 14:55:09 -0700 Message-ID: <887892ad-87f6-d652-8b0b-ed6ec5e393b0@intel.com> References: <20180323144728.61548-1-michal.wajdeczko@intel.com> <20180323144728.61548-5-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADA646E2EF for ; Fri, 23 Mar 2018 21:55:09 +0000 (UTC) In-Reply-To: <20180323144728.61548-5-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMy8yMy8yMDE4IDc6NDcgQU0sIE1pY2hhbCBXYWpkZWN6a28gd3JvdGU6Cj4gV2UncmUgdXNp bmcgZGF0YSBlbmNvZGVkIGluIHRoZSBzdGF0dXMgTU1JTyBhcyByZXR1cm4gdmFsdWUgZnJvbSBz ZW5kCj4gZnVuY3Rpb24sIGJ1dCBHdUMgbWF5IGFsc28gd3JpdGUgbW9yZSBkYXRhIGluIHJlbWFp bmluZyBNTUlPIHJlZ3MuCj4gTGV0J3MgY29weSBjb250ZW50IG9mIHRoZXNlIHJlZ2lzdGVycyB0 byB0aGUgYnVmZmVyIHByb3ZpZGVkIGJ5IGNhbGxlci4KPiAKPiB2MjogbmV3IGxpbmUgKE1pY2hl bCkKPiB2MzogdXBkYXRlZCBjb21taXQgbWVzc2FnZQo+IAo+IFNpZ25lZC1vZmYtYnk6IE1pY2hh bCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBEYW5pZWxlIENl cmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IENjOiBPc2Nh ciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBNaWNoZWwgVGhp ZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPiAjMgo+IC0tLQo+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZ3VjLmMgfCAxNSArKysrKysrKysrKystLS0KPiAgIDEgZmlsZSBjaGFu Z2VkLCAxMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2d1Yy5jCj4gaW5kZXggYTUzM2ZmOC4uOWNlMDFlNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2d1Yy5jCj4gQEAgLTM2OCwxMSArMzY4LDIwIEBAIGludCBpbnRlbF9ndWNfc2VuZF9tbWlv KHN0cnVjdCBpbnRlbF9ndWMgKmd1YywgY29uc3QgdTMyICphY3Rpb24sIHUzMiBsZW4sCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIgcmV0PSVkIHN0YXR1cz0weCUwOFggcmVz cG9uc2U9MHglMDhYXG4iLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhY3Rp b25bMF0sIHJldCwgc3RhdHVzLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJ OTE1X1JFQUQoU09GVF9TQ1JBVENIKDE1KSkpOwo+IC0gICAgICAgfSBlbHNlIHsKPiAtICAgICAg ICAgICAgICAgLyogVXNlIGRhdGEgZnJvbSB0aGUgR3VDIHJlc3BvbnNlIGFzIG91ciByZXR1cm4g dmFsdWUgKi8KPiAtICAgICAgICAgICAgICAgcmV0ID0gSU5URUxfR1VDX01TR19UT19EQVRBKHN0 YXR1cyk7Cj4gKyAgICAgICAgICAgICAgIGdvdG8gb3V0Owo+ICAgICAgICAgIH0KPiAKCkknbSBu b3QgYSBiaWcgZmFuIG9mIGdvdG8ncywgc28gSSB3b3VsZCBoYXZlIGFkZGVkIHRoZSByZXNwb25z ZSBoYW5kbGluZyAKaW4gdGhlIGVsc2UgcGFydC4KCkJ1dCBpdCdzIHN0aWxsIGNvcnJlY3QsIHNv IG15IG9sZCByLWIgc3RpbGwgc3RhbmRzLgoKLU1pY2hlbAoKPiArICAgICAgIGlmIChyZXNwb25z ZV9idWYpIHsKPiArICAgICAgICAgICAgICAgaW50IGNvdW50ID0gbWluKHJlc3BvbnNlX2J1Zl9z aXplLCBndWMtPnNlbmRfcmVncy5jb3VudCAtIDEpOwo+ICsKPiArICAgICAgICAgICAgICAgZm9y IChpID0gMDsgaSA8IGNvdW50OyBpKyspCj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmVzcG9u c2VfYnVmW2ldID0gSTkxNV9SRUFEKGd1Y19zZW5kX3JlZyhndWMsIGkgKyAxKSk7Cj4gKyAgICAg ICB9Cj4gKwo+ICsgICAgICAgLyogVXNlIGRhdGEgZnJvbSB0aGUgR3VDIHJlc3BvbnNlIGFzIG91 ciByZXR1cm4gdmFsdWUgKi8KPiArICAgICAgIHJldCA9IElOVEVMX0dVQ19NU0dfVE9fREFUQShz dGF0dXMpOwo+ICsKPiArb3V0Ogo+ICAgICAgICAgIGludGVsX3VuY29yZV9mb3JjZXdha2VfcHV0 KGRldl9wcml2LCBndWMtPnNlbmRfcmVncy5md19kb21haW5zKTsKPiAgICAgICAgICBtdXRleF91 bmxvY2soJmd1Yy0+c2VuZF9tdXRleCk7Cj4gCj4gLS0KPiAxLjkuMQo+IAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK