From: "its_Giaan (Code Review)" Date: Tue, 12 Mar 2024 08:36:36 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <88b1f09ddf5020ba5af6961fe55e189cf2a21016-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="uati0un2iuQ="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --uati0un2iuQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/523?usp=3Demail ) Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 5: (4 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/523/comment/87905ca4_736be2e0 : PS5, Line 21: http_proxy_options and also a getter method to retrieve > The man page for --auth-nocache still says it has no effect on --http-pro= xy. [=E2=80=A6] Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/3b08b487_e3fc606d : PS5, Line 3126: if (ce->http_proxy_options) > This needs to be moved one level up. E.g. [=E2=80=A6] Done File src/openvpn/proxy.h: http://gerrit.openvpn.net/c/openvpn/+/523/comment/0c4157a3_109dd1dc : PS5, Line 61: bool nocache; > Please update "show_http_proxy_options" in options.c to show value of noc= ache. Done File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/f7da0dee_13ae81ae : PS5, Line 669: if (p->up.nocache) > wouldn't it be better to move this clearing into get_user_pass_http? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 5 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 12 Mar 2024 08:36:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --uati0un2iuQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

4 comments:

    =
  • Commit Message:

    • <= p style=3D"margin-bottom: 4px;">Patch Set #5, Line 21: http_proxy_options and also a getter m= ethod to retrieve

      The man page for --auth-nocache sti= ll says it has no effect on --http-proxy. [=E2=80=A6]

      Done

  • File src/openvpn/options.c:

  • Patch Set #5, Line 3126:= if (ce->= ;http_proxy_options)

    This needs to be moved one level= up. E.g. [=E2=80=A6]

    Done

  • File src/openvpn/proxy.h:

    • Patch Set #5, Line 61: bool nocache;

      Please update &quo= t;show_http_proxy_options" in options.c to show value of nocache.

      Done=

  • File src/openvpn= /proxy.c:

  • To= view, visit change 523. To unsubscribe, or for help writing mail filters, visit= settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279= fb71c01a1a78a
    Gerrit-Change-Number: 523
    Gerrit-PatchSet: 5
    Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Tue, 12 Mar 2024 08:36:36= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
    Gerrit-MessageType: comment
    --uati0un2iuQ=--