From: "its_Giaan (Code Review)"
Date: Tue, 1 Oct 2024 15:31:58 +0000
In-Reply-To:
References:
Reply-To: gianmarco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181...
Message-ID: <88fe8f0ce4e7b479971904f38e372042b40b4e83-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="cE6Qf51qrck="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: allow user to
specify 'local' multiple times in config files
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , plaisthos , openvpn-devel
--cE6Qf51qrck=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex, plaisthos.
its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/436?usp=3Demail )
Change subject: allow user to specify 'local' multiple times in config files
......................................................................
Patch Set 3:
(3 comments)
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/436/comment/e65be83d_307d5115 :
PS2, Line 127: "--local host|* [port] : Local host name or ip address a=
nd port. '*' can be used\n"
> Some of this should move to the documentation instead.
Done
http://gerrit.openvpn.net/c/openvpn/+/436/comment/e082d9e2_59ce1158 :
PS2, Line 997: befor
> "be for"?
Done
File src/openvpn/socket.c:
http://gerrit.openvpn.net/c/openvpn/+/436/comment/7a7bcf88_b92b38b3 :
PS2, Line 345: int i, j;
> For new code please move the declaration to the actual first use. No need=
to stay in pre-C99 style.
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 3
Gerrit-Owner: ordex
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: its_Giaan
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Tue, 01 Oct 2024 15:31:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--cE6Qf51qrck=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex, plaisthos. <=
/p>
View C=
hange
3 comments:
Done
Patch Set #2, Line 997: befor
"be for&quo=
t;?
Done
File src=
/openvpn/socket.c:
To view, visit change 436. To unsubscribe, or for help writing=
mail filters, visit setting=
s.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20a=
dde09529e2764
Gerrit-Change-Number: 436
Gerrit-PatchSet: 3
Gerrit-Owner: ordex <a@...2181...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: its_Giaan <gianmarco@...2726...&=
gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <a@...2181...> <=
/div>
Gerrit-Comment-Date: Tue, 01 Oct 2024 15:31:58=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--cE6Qf51qrck=--