From: David Ahern Subject: Re: [PATCH iproute2-next] Improve batch times by caching link lookups Date: Mon, 7 Jan 2019 13:58:31 -0700 Message-ID: <89099221-ca87-3298-47bf-b8e68403c2b2@gmail.com> References: <20190107204130.32144-1-dsahern@kernel.org> <9f8a0935-2f4c-74e8-038d-61e3b5049f12@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Eric Dumazet , David Ahern , stephen@networkplumber.org Return-path: Received: from mail-pl1-f182.google.com ([209.85.214.182]:46003 "EHLO mail-pl1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbfAGU6e (ORCPT ); Mon, 7 Jan 2019 15:58:34 -0500 Received: by mail-pl1-f182.google.com with SMTP id a14so702013plm.12 for ; Mon, 07 Jan 2019 12:58:33 -0800 (PST) In-Reply-To: <9f8a0935-2f4c-74e8-038d-61e3b5049f12@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/7/19 1:57 PM, Eric Dumazet wrote: > > > On 01/07/2019 12:41 PM, David Ahern wrote: >> From: David Ahern >> >> ip route uses ll_name_to_index to convert the user given device name to an >> index. At the moment ll_name_to_index uses if_nametoindex which is ioctl >> based and does not cache the result. When using a batch file this means >> the same device lookups can be done repeatedly adding unnecessary overhead >> (socket + ioctl call for each device lookup). >> >> Add a new function, ll_link_get, to send a netlink based RTM_GETLINK. If >> successful, cache the result in idx_head and name_head so future lookups >> can re-use the entry. >> >> With this change the time to install routes via a batch file is reduced >> from 30.7 seconds to 17.6 seconds (720,022 routes with 2 ecmp nexthops >> where the nexthop device is given). >> > > What time increase if we have 10,000 devices, and install one route ? > > Caching 10,000 devices would be quite a waste. > It only lookups up the device if ll_name_to_index is invoked for the device. This is NOT a link dump and cache; it only adds lookups to the cache.