Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B30A3C19F2B for ; Thu, 4 Aug 2022 11:34:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BFD2B8402F; Thu, 4 Aug 2022 13:33:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1659612838; bh=WAOaLGHqgVvmsA+MQ10zmeg6a2UUoPk9qI5eOrQS93k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Kbo6kD/4ISM9Ae9fkIRy3u4QlL8+Q0gzfFGKmC5srs9bxOye/x3HTRC4eD+0HUWWJ oZwgAGhVEfnB1kVkwAbC+rEw9GqEktxp6x/7xtQZ/sDKYl9wDmnzZd3XdALqhZaMvK eYTY4RXSL/WGAFbTkb4jLxha3I86eVxXiFHdLmszIhNj5z93hTXhjNfej9gb1qQINt q8wKktux935U9Ib+2qMF4t0679MFu/NzPsqumHhGBX6jpLjXSL6mr3Svb94Yp/Mbbe 0oH2SB7E0brZOIQFy8LQZRBZWQcOVZoG09pbYL8aJzAQUyGsQVUhhDWZgpup7Gfl0+ oTB5VdK1BYCSg== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 06A89810E8; Thu, 4 Aug 2022 13:33:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1659612837; bh=WAOaLGHqgVvmsA+MQ10zmeg6a2UUoPk9qI5eOrQS93k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MdittR1LwNPztJshOP9Grg8dn31mkWlPx2MCB0Zo2kWWmfvOTeXnBy/nu+eoJBPMh vYgOMzPe2h8HpDKDYOY0GmCwt8woB6CZDTC5yoxy9JEMwMx2rR17bxQPw4SW6+SjB6 KKbOEKYnrUN5bDnAVt9KVhJpHzkJjDdQygwSrP9tReD2LVfjzLfMbl8BYR0PVMajug yjika0AJX1hjiIcTERyr1BnM90ROI4346MSWi8CWNoM7RsagLrvswHqtvv9MX5n9Gw kXRopmDdq4qjEj9G7CkryZUIvKvDXnRHiYALzM2ZVAjfcIwxlMo6yr6my4aWA5EVrT 9+35M/abExivA== Message-ID: <89447b1d-e99c-a378-e4b7-18e76e69050c@denx.de> Date: Thu, 4 Aug 2022 13:33:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] ARM: cache: Allow SPL to build cache-pl310.c Content-Language: en-US To: Philip Oberfichtner , u-boot@lists.denx.de Cc: Christoph Niedermaier , Stefano Babic , Dzmitry Sankouski , Sean Anderson , Stefan Roese , Tom Rini References: <20220804081533.2228257-1-pro@denx.de> <6c9ed381d86f7c26404cc6b58e2b78e927e343fa.camel@denx.de> From: Marek Vasut In-Reply-To: <6c9ed381d86f7c26404cc6b58e2b78e927e343fa.camel@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/4/22 11:19, Philip Oberfichtner wrote: [...] >>> @@ -46,6 +45,7 @@ else >>> obj-$(CONFIG_$(SPL_TPL_)USE_ARCH_MEMSET) += memset.o >>> obj-$(CONFIG_$(SPL_TPL_)USE_ARCH_MEMCPY) += memcpy.o >>> endif >>> +obj-$(CONFIG_SYS_L2_PL310) += cache-pl310.o >> >> Doesn't this need SPL/TPL Kconfig symbols and >> >> obj-$(CONFIG_$(SPL_TPL_)SYS_L2_PL310) += cache-pl310.o >> >> ? > > CONFIG_SYS_L2_PL310 is not converted to Kconfig yet. And there is no > CONFIG_SPL_ usage for it so far. So I'd say no. Please correct me if > I'm wrong. I'm concerned whether applying this patch won't enable L2CC in SPL for boards where this could break things. There is a script to do the conversion to Kconfig easily, see doc/develop/moveconfig.rst . It might make sense to run it first, convert this symbol to Kconfig, and then add this patch second, and then enable SPL_...PL310 for this board only.