From: Michael Walle Date: Wed, 20 May 2020 18:42:11 +0200 Subject: [PATCH v4] dm: uclass: don't assign aliased seq numbers In-Reply-To: References: <20200303074738.3299-1-michael@walle.cc> <26cddaa1-358f-5677-a23a-81bc28e30e08@xilinx.com> <8bb08d3b19c5915d2bcfd3f0b7b853a3@walle.cc> <8155a3589f9069b306dd290d7f7d1707@walle.cc> <4d5d313a22b5a831032145193c5c8e4c@walle.cc> <990328817a5ad5bda5a3d00ffcac3aff@walle.cc> Message-ID: <895229e830aaea512f8a88f4cbaedb2b@walle.cc> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, Am 2020-05-19 18:47, schrieb Simon Glass: > Hi Michael, > > On Tue, 19 May 2020 at 06:17, Michael Walle wrote: >> >> Hi Simon, >> >> Am 2020-04-24 16:17, schrieb Michael Walle: >> > Hi Simon, >> > >> > Am 2020-04-20 01:38, schrieb Simon Glass: >> > >> > [..snip..] >> > >> >>> > uclass 31: eth >> >>> > 0 * smsc95xx_eth @ 3db69ac0, seq 0, (req -1) >> >>> >> >>> Shouldn't this be "req 0" if the ethernet alias is actually matched. >> >>> Does u-boot actually supports matching usb nodes to devices? If not, >> >>> shouldn't the alias be removed then? >> >>> >> >>> That being said, it is still strange why the bootloader doesn't find >> >>> ethernet-1 then. I've tried with my board, no native ethernet support >> >>> and an usb network dongle which works as expected (well the dongle >> >>> seems to have some issues to actually transfer frames). >> >> >> >> It is a bit strange. Removing the alias does not fix it though. >> > >> > Are you sure you removed the alias in the correct file? There are two, >> > could you please double check if is not contained in the resulting >> > device tree? >> > >> > dtc -I dtb -O dts dts/dt.dtb >> > >> > I just tested it on a rpi3b. and it works if i remove the alias. >> > >> >> So far as I know U-Boot doesn't work with the alias, since there is no >> >> driver for the "usb424,2514" compatible string. >> > >> > So it is actually correct behaviour of my patch. ethernet1 doesn't work >> > because there is no eth1addr. So I see three solutions: >> > >> > (1) make the matching work >> > (2) remove the alias >> > (3) set eth1addr instead of ethaddr >> >> Any news on this? Can I help somewhere? I'd go with (2). > > What is involved in (1)? I've given it a try in the new v5 version. -michael