From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/2] drm/amdgpu: Remove duplicate code in gfx_v8_0.c Date: Fri, 17 Aug 2018 09:26:12 +0200 Message-ID: <895ce408-c88f-de79-045e-d15a4bc87b68@gmail.com> References: <1534489619-1491-1-git-send-email-Rex.Zhu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1534489619-1491-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Rex Zhu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTcuMDguMjAxOCB1bSAwOTowNiBzY2hyaWViIFJleCBaaHU6Cj4gVGhlcmUgYXJlIG5vIGFu eSBsb2dpY2FsIGNoYW5nZXMgaGVyZS4KPgo+IDEuIGlmIGtjcSBjYW4gYmUgZW5hYmxlZCB2aWEg a2lxLCB3ZSBkb24ndCBuZWVkIHRvCj4gICAgIGRvIGtpcSByaW5nIHRlc3QuCj4gMi4gYW1kZ3B1 X3JpbmdfdGVzdF9yaW5nIGZ1bmN0aW9uIGNhbiBiZSB1c2VkIHRvCj4gICAgIHN5bmMgdGhlIHJp bmcgY29tcGxldGUsIHJlbW92ZSB0aGUgZHVwbGljYXRlIGNvZGUuCj4KPiB2MjogYWxsb2MgNiAo bm90IDcpIGR3cyBmb3IgdW5tYXBfcXVldWVzCj4KPiBTaWduZWQtb2ZmLWJ5OiBSZXggWmh1IDxS ZXguWmh1QGFtZC5jb20+CgpBdCBsZWFzdCBvZiBoYW5kIGxvb2tzIGxpa2UgYSBuaWNlIGNsZWFu dXAgdG8gYmUsIGJ1dCBJIGNhbid0IGZ1bGx5IApqdWRnZSBiZWNhdXNlIEknbSBub3Qgc28gZmFt aWxpYXIgd2l0aCB0aGUgS0lRIChJIHNob3VsZCBwcm9iYWJseSBjaGFuZ2UgCnRoYXQgYXQgc29t ZSBwb2ludCkuCgpTZXJpZXMgaXMgQWNrZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlh bi5rb2VuaWdAYW1kLmNvbT4uCgpSZWdhcmRzLApDaHJpc3RpYW4uCgo+IC0tLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y4XzAuYyB8IDgwICsrKysrKy0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNjcg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv Z2Z4X3Y4XzAuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OF8wLmMKPiBpbmRl eCAyODJkYmE2Li45MDZkNGE1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2dmeF92OF8wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjhf MC5jCj4gQEAgLTQ2MDQsNyArNDYwNCw2IEBAIHN0YXRpYyB2b2lkIGdmeF92OF8wX2tpcV9zZXR0 aW5nKHN0cnVjdCBhbWRncHVfcmluZyAqcmluZykKPiAgIHN0YXRpYyBpbnQgZ2Z4X3Y4XzBfa2lx X2tjcV9lbmFibGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICB7Cj4gICAJc3RydWN0 IGFtZGdwdV9yaW5nICpraXFfcmluZyA9ICZhZGV2LT5nZngua2lxLnJpbmc7Cj4gLQl1aW50MzJf dCBzY3JhdGNoLCB0bXAgPSAwOwo+ICAgCXVpbnQ2NF90IHF1ZXVlX21hc2sgPSAwOwo+ICAgCWlu dCByLCBpOwo+ICAgCj4gQEAgLTQ2MjMsMTcgKzQ2MjIsMTAgQEAgc3RhdGljIGludCBnZnhfdjhf MF9raXFfa2NxX2VuYWJsZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAkJcXVldWVf bWFzayB8PSAoMXVsbCA8PCBpKTsKPiAgIAl9Cj4gICAKPiAtCXIgPSBhbWRncHVfZ2Z4X3NjcmF0 Y2hfZ2V0KGFkZXYsICZzY3JhdGNoKTsKPiAtCWlmIChyKSB7Cj4gLQkJRFJNX0VSUk9SKCJGYWls ZWQgdG8gZ2V0IHNjcmF0Y2ggcmVnICglZCkuXG4iLCByKTsKPiAtCQlyZXR1cm4gcjsKPiAtCX0K PiAtCVdSRUczMihzY3JhdGNoLCAweENBRkVERUFEKTsKPiAtCj4gLQlyID0gYW1kZ3B1X3Jpbmdf YWxsb2Moa2lxX3JpbmcsICg4ICogYWRldi0+Z2Z4Lm51bV9jb21wdXRlX3JpbmdzKSArIDExKTsK PiArCWtpcV9yaW5nLT5yZWFkeSA9IHRydWU7Cj4gKwlyID0gYW1kZ3B1X3JpbmdfYWxsb2Moa2lx X3JpbmcsICg4ICogYWRldi0+Z2Z4Lm51bV9jb21wdXRlX3JpbmdzKSArIDgpOwo+ICAgCWlmIChy KSB7Cj4gICAJCURSTV9FUlJPUigiRmFpbGVkIHRvIGxvY2sgS0lRICglZCkuXG4iLCByKTsKPiAt CQlhbWRncHVfZ2Z4X3NjcmF0Y2hfZnJlZShhZGV2LCBzY3JhdGNoKTsKPiAgIAkJcmV0dXJuIHI7 Cj4gICAJfQo+ICAgCS8qIHNldCByZXNvdXJjZXMgKi8KPiBAQCAtNDY2NSwyNSArNDY1NywxMiBA QCBzdGF0aWMgaW50IGdmeF92OF8wX2tpcV9rY3FfZW5hYmxlKHN0cnVjdCBhbWRncHVfZGV2aWNl ICphZGV2KQo+ICAgCQlhbWRncHVfcmluZ193cml0ZShraXFfcmluZywgbG93ZXJfMzJfYml0cyh3 cHRyX2FkZHIpKTsKPiAgIAkJYW1kZ3B1X3Jpbmdfd3JpdGUoa2lxX3JpbmcsIHVwcGVyXzMyX2Jp dHMod3B0cl9hZGRyKSk7Cj4gICAJfQo+IC0JLyogd3JpdGUgdG8gc2NyYXRjaCBmb3IgY29tcGxl dGlvbiAqLwo+IC0JYW1kZ3B1X3Jpbmdfd3JpdGUoa2lxX3JpbmcsIFBBQ0tFVDMoUEFDS0VUM19T RVRfVUNPTkZJR19SRUcsIDEpKTsKPiAtCWFtZGdwdV9yaW5nX3dyaXRlKGtpcV9yaW5nLCAoc2Ny YXRjaCAtIFBBQ0tFVDNfU0VUX1VDT05GSUdfUkVHX1NUQVJUKSk7Cj4gLQlhbWRncHVfcmluZ193 cml0ZShraXFfcmluZywgMHhERUFEQkVFRik7Cj4gLQlhbWRncHVfcmluZ19jb21taXQoa2lxX3Jp bmcpOwo+ICAgCj4gLQlmb3IgKGkgPSAwOyBpIDwgYWRldi0+dXNlY190aW1lb3V0OyBpKyspIHsK PiAtCQl0bXAgPSBSUkVHMzIoc2NyYXRjaCk7Cj4gLQkJaWYgKHRtcCA9PSAweERFQURCRUVGKQo+ IC0JCQlicmVhazsKPiAtCQlEUk1fVURFTEFZKDEpOwo+IC0JfQo+IC0JaWYgKGkgPj0gYWRldi0+ dXNlY190aW1lb3V0KSB7Cj4gLQkJRFJNX0VSUk9SKCJLQ1EgZW5hYmxlIGZhaWxlZCAoc2NyYXRj aCgweCUwNFgpPTB4JTA4WClcbiIsCj4gLQkJCSAgc2NyYXRjaCwgdG1wKTsKPiAtCQlyID0gLUVJ TlZBTDsKPiArCXIgPSBhbWRncHVfcmluZ190ZXN0X3Jpbmcoa2lxX3JpbmcpOwo+ICsJaWYgKHIp IHsKPiArCQlEUk1fRVJST1IoIktDUSBlbmFibGUgZmFpbGVkXG4iKTsKPiArCQlraXFfcmluZy0+ cmVhZHkgPSBmYWxzZTsKPiAgIAl9Cj4gLQlhbWRncHVfZ2Z4X3NjcmF0Y2hfZnJlZShhZGV2LCBz Y3JhdGNoKTsKPiAtCj4gICAJcmV0dXJuIHI7Cj4gICB9Cj4gICAKPiBAQCAtNTAxNCwxNSArNDk5 Myw2IEBAIHN0YXRpYyBpbnQgZ2Z4X3Y4XzBfa2lxX3Jlc3VtZShzdHJ1Y3QgYW1kZ3B1X2Rldmlj ZSAqYWRldikKPiAgIAlpZiAocikKPiAgIAkJZ290byBkb25lOwo+ICAgCj4gLQkvKiBUZXN0IEtJ USAqLwo+IC0JcmluZyA9ICZhZGV2LT5nZngua2lxLnJpbmc7Cj4gLQlyaW5nLT5yZWFkeSA9IHRy dWU7Cj4gLQlyID0gYW1kZ3B1X3JpbmdfdGVzdF9yaW5nKHJpbmcpOwo+IC0JaWYgKHIpIHsKPiAt CQlyaW5nLT5yZWFkeSA9IGZhbHNlOwo+IC0JCWdvdG8gZG9uZTsKPiAtCX0KPiAtCj4gICAJLyog VGVzdCBLQ1FzICovCj4gICAJZm9yIChpID0gMDsgaSA8IGFkZXYtPmdmeC5udW1fY29tcHV0ZV9y aW5nczsgaSsrKSB7Cj4gICAJCXJpbmcgPSAmYWRldi0+Z2Z4LmNvbXB1dGVfcmluZ1tpXTsKPiBA QCAtNTA5MiwyMyArNTA2MiwxMSBAQCBzdGF0aWMgaW50IGdmeF92OF8wX2h3X2luaXQodm9pZCAq aGFuZGxlKQo+ICAgCj4gICBzdGF0aWMgaW50IGdmeF92OF8wX2tjcV9kaXNhYmxlKHN0cnVjdCBh bWRncHVfcmluZyAqa2lxX3Jpbmcsc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nKQo+ICAgewo+IC0J c3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSBraXFfcmluZy0+YWRldjsKPiAtCXVpbnQzMl90 IHNjcmF0Y2gsIHRtcCA9IDA7Cj4gLQlpbnQgciwgaTsKPiAtCj4gLQlyID0gYW1kZ3B1X2dmeF9z Y3JhdGNoX2dldChhZGV2LCAmc2NyYXRjaCk7Cj4gLQlpZiAocikgewo+IC0JCURSTV9FUlJPUigi RmFpbGVkIHRvIGdldCBzY3JhdGNoIHJlZyAoJWQpLlxuIiwgcik7Cj4gLQkJcmV0dXJuIHI7Cj4g LQl9Cj4gLQlXUkVHMzIoc2NyYXRjaCwgMHhDQUZFREVBRCk7Cj4gKwlpbnQgcjsKPiAgIAo+IC0J ciA9IGFtZGdwdV9yaW5nX2FsbG9jKGtpcV9yaW5nLCAxMCk7Cj4gLQlpZiAocikgewo+ICsJciA9 IGFtZGdwdV9yaW5nX2FsbG9jKGtpcV9yaW5nLCA2KTsKPiArCWlmIChyKQo+ICAgCQlEUk1fRVJS T1IoIkZhaWxlZCB0byBsb2NrIEtJUSAoJWQpLlxuIiwgcik7Cj4gLQkJYW1kZ3B1X2dmeF9zY3Jh dGNoX2ZyZWUoYWRldiwgc2NyYXRjaCk7Cj4gLQkJcmV0dXJuIHI7Cj4gLQl9Cj4gICAKPiAgIAkv KiB1bm1hcCBxdWV1ZXMgKi8KPiAgIAlhbWRncHVfcmluZ193cml0ZShraXFfcmluZywgUEFDS0VU MyhQQUNLRVQzX1VOTUFQX1FVRVVFUywgNCkpOwo+IEBAIC01MTIxLDIzICs1MDc5LDExIEBAIHN0 YXRpYyBpbnQgZ2Z4X3Y4XzBfa2NxX2Rpc2FibGUoc3RydWN0IGFtZGdwdV9yaW5nICpraXFfcmlu ZyxzdHJ1Y3QgYW1kZ3B1X3JpbmcKPiAgIAlhbWRncHVfcmluZ193cml0ZShraXFfcmluZywgMCk7 Cj4gICAJYW1kZ3B1X3Jpbmdfd3JpdGUoa2lxX3JpbmcsIDApOwo+ICAgCWFtZGdwdV9yaW5nX3dy aXRlKGtpcV9yaW5nLCAwKTsKPiAtCS8qIHdyaXRlIHRvIHNjcmF0Y2ggZm9yIGNvbXBsZXRpb24g Ki8KPiAtCWFtZGdwdV9yaW5nX3dyaXRlKGtpcV9yaW5nLCBQQUNLRVQzKFBBQ0tFVDNfU0VUX1VD T05GSUdfUkVHLCAxKSk7Cj4gLQlhbWRncHVfcmluZ193cml0ZShraXFfcmluZywgKHNjcmF0Y2gg LSBQQUNLRVQzX1NFVF9VQ09ORklHX1JFR19TVEFSVCkpOwo+IC0JYW1kZ3B1X3Jpbmdfd3JpdGUo a2lxX3JpbmcsIDB4REVBREJFRUYpOwo+IC0JYW1kZ3B1X3JpbmdfY29tbWl0KGtpcV9yaW5nKTsK PiAgIAo+IC0JZm9yIChpID0gMDsgaSA8IGFkZXYtPnVzZWNfdGltZW91dDsgaSsrKSB7Cj4gLQkJ dG1wID0gUlJFRzMyKHNjcmF0Y2gpOwo+IC0JCWlmICh0bXAgPT0gMHhERUFEQkVFRikKPiAtCQkJ YnJlYWs7Cj4gLQkJRFJNX1VERUxBWSgxKTsKPiAtCX0KPiAtCWlmIChpID49IGFkZXYtPnVzZWNf dGltZW91dCkgewo+IC0JCURSTV9FUlJPUigiS0NRIGRpc2FibGVkIGZhaWxlZCAoc2NyYXRjaCgw eCUwNFgpPTB4JTA4WClcbiIsIHNjcmF0Y2gsIHRtcCk7Cj4gLQkJciA9IC1FSU5WQUw7Cj4gLQl9 Cj4gLQlhbWRncHVfZ2Z4X3NjcmF0Y2hfZnJlZShhZGV2LCBzY3JhdGNoKTsKPiArCXIgPSBhbWRn cHVfcmluZ190ZXN0X3Jpbmcoa2lxX3JpbmcpOwo+ICsJaWYgKHIpCj4gKwkJRFJNX0VSUk9SKCJL Q1EgZGlzYWJsZSBmYWlsZWRcbiIpOwo+ICsKPiAgIAlyZXR1cm4gcjsKPiAgIH0KPiAgIAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWls aW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==