From: "flichtenheld (Code Review)" Date: Wed, 14 Jan 2026 16:53:06 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <89845ec3083b6d2005f47bbeae7b3615b0a4ce9d-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Xglkrcd4L2o="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: Update mbedtls to v4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --Xglkrcd4L2o= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=3Demail to review the following change. Change subject: GHA: Update mbedtls to v4 ...................................................................... GHA: Update mbedtls to v4 Also switch from Make to CMake for building it because the former is not supported anymore. Change-Id: I658b1b24da304938225a8f834d7484671a63360f Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml 1 file changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/1474/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index ce730f6..9eead7c 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -366,12 +366,12 @@ - name: make check run: make -j3 check VERBOSE=3D1 - mbedtls3: + mbedtls4: strategy: fail-fast: false matrix: os: [ubuntu-22.04] - ssllib: [mbedtls3] + ssllib: [mbedtls4] build: [ normal, asan ] include: - build: asan @@ -398,15 +398,19 @@ uses: actions/checkout@...2955... # v5.0.1 with: path: mbedtls - submodules: true + submodules: recursive # versioning=3Dsemver-coerced repository: Mbed-TLS/mbedtls - ref: v3.6.5 - - name: "mbedtls: make no_test" - run: make -j3 no_test SHARED=3D1 + ref: v4.0.0 + - uses: lukka/get-cmake@...2927... # v4.1.1 + - name: "mbedtls: cmake" + run: cmake -B build working-directory: mbedtls - - name: "mbedtls: make install" - run: sudo make install DESTDIR=3D/usr + - name: "mbedtls: cmake --build" + run: cmake --build build + working-directory: mbedtls + - name: "mbedtls: cmake --install" + run: sudo cmake --install build --prefix /usr working-directory: mbedtls - name: Checkout OpenVPN uses: actions/checkout@...2955... # v5.0.1 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I658b1b24da304938225a8f834d7484671a63360f Gerrit-Change-Number: 1474 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --Xglkrcd4L2o= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

GHA: Update mbedtls to v4

Also switc= h from Make to CMake for building it
because the former is not supported= anymore.

Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Si= gned-off-by: Frank Lichtenheld <frank@...2641...>
---
M .github= /workflows/build.yaml
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn r=
efs/changes/74/1474/1
diff --git a/.github/workflows/build.yaml b/.=
github/workflows/build.yaml
index ce730f6..9eead7c 100644
--- a/.github/workflows/build.yaml
+++ b/.gi= thub/workflows/build.yaml
@@ -366,12 +366,12 @@
<= span> - name: make check

run: make -j3 check= VERBOSE=3D1

- mbedtls3:
= + mbedtls4:
strategy:
fail-fas= t: false
matrix:
os: [ubunt= u-22.04]
- sslli= b: [mbedtls3]
+ = ssllib: [mbedtls4]
build: [ normal, asan ]
include:
- build: asan
@@ -398,15 +398,19 @@
uses: actions/che= ckout@...2955... # v5.0.1
with:
= path: mbedtls
= - submodules: true
+ submodules: recursive
# versio= ning=3Dsemver-coerced
repository: Mbed-TLS/mbedt= ls
- ref: v3.6= .5
- - name: "= ;mbedtls: make no_test"
- run: make -j3 no_test SHARED=3D1
+ ref: v4.0.0
+ - uses: lukka/get-cmake@...2927... # v4= .1.1
+ - name: &= quot;mbedtls: cmake"
+ run: cmake -B build
working-director= y: mbedtls
- - nam= e: "mbedtls: make install"
- run: sudo make install DESTDIR=3D/usr
+ - name: "mbedtls: cmake= --build"

+ = run: cmake --build build
+ working-directory: mbedtls
+ - name: "mbedtls: cmake --install"
+ run: sudo cma= ke --install build --prefix /usr
working-directory= : mbedtls
- name: Checkout OpenVPN
= uses: actions/checkout@...2955... # v5.0.1
<= br>

To view, visit change 1474. To unsubscribe, or for help writing mai= l filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7= 484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --Xglkrcd4L2o=--