Date: Tue, 26 Apr 2022 12:19:09 +0200 (CEST) From: Frank Lichtenheld Message-ID: <89933784.416729.1650968349518@...2642...> In-Reply-To: <20220422142953.3805364-6-arne@...1227...> References: <20220422134038.3801239-1-arne@...1227...> <20220422142953.3805364-1-arne@...1227...> <20220422142953.3805364-6-arne@...1227...> MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH 15/28] Remove pointless indentation from tls_process. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net Acked-by: Frank Lichtenheld Trivial. The commit message is a bit garbled though. Changing the first "add" to "and" makes it better, I think. "decleration" should be "declaration". Also remove the full stop from the summary line and move it at the end of the body. $ git show -w commit fdbf34d2e4e28c334e18a677b670b8ade9f87ded Author: Arne Schwabe Date: Fri Apr 22 16:29:40 2022 +0200 Remove pointless indentation from tls_process. This is probably a result from earlier code that still needed to be C89 compatible add probably added this to allow variable decleration diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 15af5894..097be8c0 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -2774,7 +2774,6 @@ tls_process(struct tls_multi *multi, } /* When should we wake up again? */ - { if (ks->state >= S_INITIAL) { compute_earliest_wakeup(wakeup, @@ -2813,7 +2812,6 @@ tls_process(struct tls_multi *multi, return false; } -} /* * Called by the top-level event loop. Regards, -- Frank Lichtenheld