Return-Path: From: Chaitanya Kulkarni Subject: Re: [PATCH 03/11] null_blk: don't set the discard_alignment queue limit Date: Mon, 18 Apr 2022 21:22:25 +0000 Message-ID: <89b62032-297a-1201-3a35-fa1731a0d620@nvidia.com> References: <20220418045314.360785-1-hch@lst.de> <20220418045314.360785-4-hch@lst.de> In-Reply-To: <20220418045314.360785-4-hch@lst.de> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Johannes Berg , Josef Bacik , "Md. Haris Iqbal , Jack Wang , Michael S. Tsirkin , Jason Wang , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=" , Mike Snitzer , Song Liu , Stefan Haberland , Jan Hoeppner , "Martin K." Petersen" , "linux-um@lists.infradead.org, linux-um@lists.infradead.org, "linux-block@vger.kernel.org" , "nbd@other.debian.org" , "virtualization@lists.linux-foundation.org" , "xen-devel@lists.xenproject.org" , "linux-raid@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-s390@vger.kernel.org" , "dm-devel@redhat.com" On 4/17/22 21:53, Christoph Hellwig wrote: > The discard_alignment queue limit is named a bit misleading means the > offset into the block device at which the discard granularity starts. > Setting it to the discard granularity as done by null_blk is mostly > harmless but also useless. > > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Chaitanya Kulkarni -ck _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um