From: Chris Wilson Subject: Re: [Blacklisted][PATCH] Submit batch buffers from flush callback chain Date: Fri, 30 Jul 2010 07:29:53 +0100 Message-ID: <89k77n$oh1fjl@fmsmga001.fm.intel.com> References: <1280442859-24569-1-git-send-email-krh@bitplanet.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1510362920==" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 012F09EF0E for ; Thu, 29 Jul 2010 23:29:56 -0700 (PDT) In-Reply-To: <1280442859-24569-1-git-send-email-krh@bitplanet.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1510362920== Content-Type: text/plain On Thu, 29 Jul 2010 18:34:19 -0400, Kristian Høgsberg wrote: > There are a few cases where the server will flush client output buffers > but our block handler only catches the most common (before going into select). > If the server flushes client buffers before we submit our batch buffer, > the client may receive a damage event for rendering that hasn't happened yet. > > Instead, we can hook into the flush callback chain, which the server will > invoke just before flushing output. This lets us submit batch buffers > before sending out events, preserving ordering. > > Fixes 28438: [bisected] incorrect character in gnome-terminal under compiz > https://bugs.freedesktop.org/show_bug.cgi?id=28438 > > Signed-off-by: Kristian Høgsberg A flush callback makes more sense than a block handler. Is there a guide to the various hooks the xserver uses for io and the meaning of those barriers between clients? Do we have an idea of the impact this has in non-damage situations, does it impact aa10text? ;-) In intel_dri.c we manually flush the batchbuffer, should this be better expressed in terms of a call to a general flush func? For what's it is worth, I approve of this change. :) -- Chris Wilson, Intel Open Source Technology Centre --===============1510362920== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1510362920==--