From: Chris Wilson Subject: Re: [PATCH] drm/i915: fix GMCH power reporting Date: Mon, 27 Sep 2010 18:45:51 +0100 Message-ID: <89k77n$p2c5up@fmsmga001.fm.intel.com> References: <20100927103544.14316c3e@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 386C49E81F for ; Mon, 27 Sep 2010 10:45:54 -0700 (PDT) In-Reply-To: <20100927103544.14316c3e@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org, tim.gardner@canonical.com List-Id: intel-gfx@lists.freedesktop.org On Mon, 27 Sep 2010 10:35:44 -0700, Jesse Barnes wrote: > The IPS driver needs to know the current power consumption of the GMCH > in order to make decisions about when to increase or decrease the CPU > and/or GPU power envelope. So fix up the divisions to save the results > so the numbers are actually correct (contrary to some earlier comments > and code, these functions do not modify the first argument and use it > for the result). Applied to -fixes, with a cc for stable, "it's nice to have good values in debugfs if nothing else". -Chris -- Chris Wilson, Intel Open Source Technology Centre