From: Chris Wilson Subject: Re: [PATCH] drm/gem: handlecount isnt really a kref so dont make it one. Date: Thu, 30 Sep 2010 00:09:14 +0100 Message-ID: <89k77n$p356kr@fmsmga001.fm.intel.com> References: <1285731949-20195-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id A8B3B9E744 for ; Wed, 29 Sep 2010 16:09:29 -0700 (PDT) In-Reply-To: <1285731949-20195-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, 29 Sep 2010 13:45:49 +1000, Dave Airlie wrote: > From: Dave Airlie > > There were lots of places being inconsistent since handle count > looked like a kref but it really wasn't. > > Fix this my just making handle count an atomic on the object, > and have it increase the normal object kref. > > Now i915/radeon/nouveau drivers can drop the normal reference on > userspace object creation. > > Signed-off-by: Dave Airlie Speaking as one who was recently confused by the not-a-kref nature of handlecount:- Reviewed-by: Chris Wilson -- Chris Wilson, Intel Open Source Technology Centre