From: Chris Wilson Subject: Re: [patch] i915: take struct_mutex in i915_dma_cleanup() Date: Sun, 25 Jul 2010 16:05:45 +0100 Message-ID: <89kc63$hi6qh3@fmsmga002.fm.intel.com> References: <20100623111954.GA16433@bicker> <20100623084718.2dfe6e7f@virtuousgeek.org> Return-path: In-Reply-To: <20100623084718.2dfe6e7f@virtuousgeek.org> Sender: linux-kernel-owner@vger.kernel.org To: Jesse Barnes , Dan Carpenter Cc: David Airlie , Eric Anholt , Zhenyu Wang , nanhai.zou@intel.com, Benny Halevy , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Jin, Gordon" List-Id: dri-devel@lists.freedesktop.org On Wed, 23 Jun 2010 08:47:18 -0700, Jesse Barnes wrote: > Reminds me, Gordon can you add module unload testing to your set of > basic daily tests? To unload you need to unbind the fbcon interface > first, my script is like this: > > echo 0 > /sys/class/vtconsole/vtcon1/bind > rmmod i915 > rmmod drm_kms_helper > rmmod drm > modprobe i915 > echo 1 > /sys/class/vtconsole/vtcon1/bind To which we could even add a kmemleak check. After rmmod drm and before reloading i915: echo scan > /sys/kernel/debug/kmemleak cat /sys/kernel/debug/kmemleak > `hostname`-leaks.txt If the output is not empty, file a bug. [Of course this means having to compile kmemleak into the kernel. The DEBUG_KMEMLEAK option is found under Kernel Hacking.] And since each generation has slightly different initialization stanzas, we need to repeat the test on all platforms. -- Chris Wilson, Intel Open Source Technology Centre