From: Chris Wilson Subject: Re: [REGRESSION, i915]: Periodic stalls with 2.6.36-rc2 Date: Tue, 24 Aug 2010 01:12:22 +0100 Message-ID: <89kc63$hrmse5@fmsmga002.fm.intel.com> References: <20100823233551.GA31920@sucs.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id EB16E9E7D5 for ; Mon, 23 Aug 2010 17:12:27 -0700 (PDT) In-Reply-To: <20100823233551.GA31920@sucs.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Sitsofe Wheeler , LKML , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, 24 Aug 2010 00:35:51 +0100, Sitsofe Wheeler wrote: > Hi, > > With 2.6.36-rc2 I see periodic stalls when running with a stock Ubuntu > 10.04 userspace. These stalls were not present in 2.6.36-rc1 on an EeePC > 900 with an i915. >From the error message, I'd suggest we'd tackle hangcheck - it simply shouldn't be firing at all under normal circumstances. (Looking at it we don't handle the introduction of the BSD ring correctly, but that is irrelevant on the EeePC 900.) Do the stalls and tearing go away with: diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index e4d42a7..dc5fb4f 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1305,8 +1305,7 @@ void i915_hangcheck_elapsed(unsigned long data) dev_priv->hangcheck_count = 0; /* Issue a wake-up to catch stuck h/w. */ - if (dev_priv->render_ring.waiting_gem_seqno | - dev_priv->bsd_ring.waiting_gem_seqno) { + if (0) { DRM_ERROR("Hangcheck timer elapsed... GPU idle, missed IRQ.\n"); if (dev_priv->render_ring.waiting_gem_seqno) DRM_WAKEUP(&dev_priv->render_ring.irq_queue); -- Chris Wilson, Intel Open Source Technology Centre