From: Mahesh Kumar Subject: Re: [PATCH v3 6/9] drm/i915/skl+: change WM calc to fixed point 16.16 Date: Thu, 22 Sep 2016 14:55:48 +0530 Message-ID: <8a02db0d-d3a5-8db9-003f-d46579440364@intel.com> References: <20160909080106.17506-1-mahesh1.kumar@intel.com> <20160909080106.17506-7-mahesh1.kumar@intel.com> <1474482740.2593.15.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DC3E6E2E3 for ; Thu, 22 Sep 2016 13:50:49 +0000 (UTC) In-Reply-To: <1474482740.2593.15.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGksCgoKT24gVGh1cnNkYXkgMjIgU2VwdGVtYmVyIDIwMTYgMTI6MDIgQU0sIFBhdWxvIFphbm9u aSB3cm90ZToKPiBIaQo+Cj4gRW0gU2V4LCAyMDE2LTA5LTA5IMOgcyAxMzozMSArMDUzMCwgS3Vt YXIsIE1haGVzaCBlc2NyZXZldToKPj4gRnJvbTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFy QGludGVsLmNvbT4KPiBGaXJzdCBvZiBhbGwsIGdvb2QgY2F0Y2ggd2l0aCB0aGlzIHBhdGNoIQo+ Cj4+IFRoaXMgcGF0Y2ggY2hhbmdlcyBXYXRlcm1hayBjYWxjdWxhdGlvbiB0byBmaXhlZCBwb2lu dCBjYWxjdWxhdGlvbi4KPj4gUHJvYmxlbSB3aXRoIGN1cnJlbnQgY2FsY3VsYXRpb24gaXMgZHVy aW5nIHBsYW5lX2Jsb2Nrc19wZXJfbGluZQo+PiBjYWxjdWxhdGlvbiB3ZSBkaXZpZGUgaW50ZXJt ZWRpYXRlIGJsb2NrcyB3aXRoIG1pbl9zY2FubGluZXMgYW5kCj4+IHRha2VzIGZsb29yIG9mIHRo ZSByZXN1bHQgYmVjYXVzZSBvZiBpbnRlZ2VyIG9wZXJhdGlvbi4KPj4gaGVuY2Ugd2UgZW5kLXVw IGFzc2lnbmluZyBsZXNzIGJsb2NrcyB0aGFuIHJlcXVpcmVkLiBXaGljaCBsZWFkcyB0bwo+PiBm bGlja2Vycy4KPiBUaGlzIHByb2JsZW0gaXMgdGhhdCB0aGUgcGF0Y2ggZG9lc24ndCBvbmx5IGRv IHRoaXMuIEl0IGFsc28gdHJpZXMgdG8KPiBtYWtlIHRoZSBtZXRob2QxIHJlc3VsdCBiZSBhIGZp eGVkIHBvaW50IDE2LjE2LCBhbmQgaXQgYWxzbyBkb2VzIGEKPiBjb21wbGV0ZWx5IHVucmVsYXRl ZCBjaGFuZ2Ugd2l0aCB0aGUgYWRkaXRpb24gb2YgdGhlIHlfdGlsZWQgdmFyaWFibGUuCj4gSSdk IHJlYWxseSBsaWtlIG9mIHRoZSAzIGNoYW5nZXMgd2VyZSAzIGRpZmZlcmVudCBwYXRjaGVzLgo+ CmFncmVlLCB5X3RpbGVkLCBjaGFuZ2UgY2FuIGdvIHNlcGFyYXRlbHksIHRoaXMgd2FzIGp1c3Qs IEkgZG9uJ3Qgd2FudGVkIAp0byB3cml0ZSBjb21wbGV0ZSBmYi0+bW9kaWZpZXIgbmFtZSBhbHdh eXMgOikuCkJ1dCBpbW8gbWFraW5nIG1ldGhvZC0xICYgbWV0aG9kLTIgb3V0cHV0IDE2LjE2IGZp eGVkIHBvaW50IHNob3VsZCBnbyBpbiAKc2luZ2xlIHBhdGNoLiAocGxhbmVfYmxvY2tzX3Blcl9s aW5lLCBtZXRob2RfMSAmIG1ldGhvZF8yIHRvIDE2LjE2KQo+PiBTaWduZWQtb2ZmLWJ5OiBNYWhl c2ggS3VtYXIgPG1haGVzaDEua3VtYXJAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgMjMgKysrKysrKysrKysrKystLS0tLS0tLS0KPj4gICAx IGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPj4KPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4gYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+IGluZGV4IDBlYzMyOGIuLmQ0MzkwZTQgMTAwNjQ0Cj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+PiBAQCAtMzUzMCwxMyArMzUzMCwxNSBAQCBzdGF0aWMg dWludDMyX3Qgc2tsX3BpcGVfcGl4ZWxfcmF0ZShjb25zdAo+PiBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY29uZmlnKQo+PiAgICovCj4+ICAgc3RhdGljIHVpbnQzMl90IHNrbF93bV9tZXRob2Qx KHVpbnQzMl90IHBpeGVsX3JhdGUsIHVpbnQ4X3QgY3BwLAo+PiB1aW50MzJfdCBsYXRlbmN5KQo+ PiAgIHsKPj4gLQl1aW50MzJfdCB3bV9pbnRlcm1lZGlhdGVfdmFsLCByZXQ7Cj4+ICsJdWludDY0 X3Qgd21faW50ZXJtZWRpYXRlX3ZhbDsKPj4gKwl1aW50MzJfdCByZXQ7Cj4+ICAgCj4+ICAgCWlm IChsYXRlbmN5ID09IDApCj4+ICAgCQlyZXR1cm4gVUlOVF9NQVg7Cj4+ICAgCj4+IC0Jd21faW50 ZXJtZWRpYXRlX3ZhbCA9IGxhdGVuY3kgKiBwaXhlbF9yYXRlICogY3BwIC8gNTEyOwo+PiAtCXJl dCA9IERJVl9ST1VORF9VUCh3bV9pbnRlcm1lZGlhdGVfdmFsLCAxMDAwKTsKPj4gKwl3bV9pbnRl cm1lZGlhdGVfdmFsID0gbGF0ZW5jeSAqIHBpeGVsX3JhdGUgKiBjcHA7Cj4+ICsJd21faW50ZXJt ZWRpYXRlX3ZhbCA8PD0gMTY7Cj4+ICsJcmV0ID0gRElWX1JPVU5EX1VQX1VMTCh3bV9pbnRlcm1l ZGlhdGVfdmFsLCAxMDAwICogNTEyKTsKPj4gICAKPj4gICAJcmV0dXJuIHJldDsKPj4gICB9Cj4g U28gc2hvdWxkbid0IHdlIGZpeCB0aGUgY2FsbGVycyBvZiBza2xfd21fbWV0aG9kMSB0byB0YWtl IGludG8KPiBjb25zaWRlcmF0aW9uIHRoYXQgdGhlIHZhbHVlIHJldHVybmVkIGlzIG5vdyBhIGZp eGVkIHBvaW50IDE2LjE2Pwo+IFNvdW5kcyBsaWtlIHdlIGhhdmUgYSBidWcgaGVyZS4KY2FsbGVy IGlzIG5vdyBjb25zaWRlcmluZyBpdCBhcyAxNi4xNiBvbmx5Cj4KPiBBbHNvLCBoYXZpbmcgbWV0 aG9kMSBiZSAxNi4xNiBhbmQgbWV0aG9kMiBiZSBhIG5vcm1hbCBpbnRlZ2VyIGFkZHMgYQo+IGxv dCB0byB0aGUgY29uZnVzaW9uLgpBY3R1YWxseSBtZXRob2QtMiBvdXRwdXQgaXMgYWxzbyAxNi4x NiBmaXhlZCBwb2ludC4gQmVjYXVzZSB3ZSBhcmUgCm11bHRpcGx5aW5nIGl0IHdpdGggcGxhbmVf YmxvY2tzX3Blcl9saW5lLCB3aGljaCBpcyAxNi4xNi4KPgo+Cj4+IEBAIC0zNjA1LDYgKzM2MDcs NyBAQCBzdGF0aWMgaW50IHNrbF9jb21wdXRlX3BsYW5lX3dtKGNvbnN0IHN0cnVjdAo+PiBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gICAJdWludDE2X3QgKm91dF9ibG9ja3MgPSAmcmVz dWx0LT5wbGFuZV9yZXNfYltpZF07Cj4+ICAgCXVpbnQ4X3QgKm91dF9saW5lcyA9ICZyZXN1bHQt PnBsYW5lX3Jlc19sW2lkXTsKPj4gICAJZW51bSB3YXRlcm1hcmtfbWVtb3J5X3dhIG1lbV93YTsK Pj4gKwlib29sIHlfdGlsZWQgPSBmYWxzZTsKPiBQbGVhc2UgZWl0aGVyIGRpc2NhcmQgdGhlc2Ug eV90aWxlZCBjaHVua3Mgb3IgbW92ZSB0aGVtIHRvIGEgc2VwYXJhdGUKPiBwYXRjaC4gQW5kIHNp bmNlIHdlIGhhdmUgdGhlIHlfdGlsZWQgdmFyaWFibGUsIG1heWJlIHdlJ2QgYWxzbyBsaWtlIHRv Cj4gaGF2ZSBhbiB4X3RpbGVkIHZhcmlhYmxlIGZvciBjb25zaXN0ZW5jeSBiZXR3ZWVuIHRoZSBj aGVja3M/CndpbGwgbW92ZSB5X3RpbGVkIHRvIG90aGVyIHBhdGNoLCBpZiB3ZSBoYXZlIGFub3Ro ZXIgdmFyaWFibGUgZm9yIAp4X3RpbGVkIHRoZW4gd2UgbmVlZCBvbmUgZm9yIG5vbmVfdGlsZWQg YWxzby4KSSdtIG5vdCBzdXJlIGhvdyB1c2VmdWwgaXQgd291bGQgYmUuCj4KPgo+PiAgIAo+PiAg IAlpZiAobGF0ZW5jeSA9PSAwIHx8ICFjc3RhdGUtPmJhc2UuYWN0aXZlIHx8ICFpbnRlbF9wc3Rh dGUtCj4+PiBiYXNlLnZpc2libGUpCj4+ICAgCQlyZXR1cm4gMDsKPj4gQEAgLTM2NTIsMTQgKzM2 NTUsMTggQEAgc3RhdGljIGludCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QKPj4g ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAgCXBsYW5lX2J5dGVzX3Blcl9saW5lID0g d2lkdGggKiBjcHA7Cj4+ICAgCWlmIChmYi0+bW9kaWZpZXJbMF0gPT0gSTkxNV9GT1JNQVRfTU9E X1lfVElMRUQgfHwKPj4gICAJICAgIGZiLT5tb2RpZmllclswXSA9PSBJOTE1X0ZPUk1BVF9NT0Rf WWZfVElMRUQpIHsKPj4gKwkJeV90aWxlZCA9IHRydWU7Cj4+ICAgCQlwbGFuZV9ibG9ja3NfcGVy X2xpbmUgPQo+PiAgIAkJICAgICAgRElWX1JPVU5EX1VQKHBsYW5lX2J5dGVzX3Blcl9saW5lICoK Pj4geV9taW5fc2NhbmxpbmVzLCA1MTIpOwo+PiAtCQlwbGFuZV9ibG9ja3NfcGVyX2xpbmUgLz0g eV9taW5fc2NhbmxpbmVzOwo+PiArCQlwbGFuZV9ibG9ja3NfcGVyX2xpbmUgPSAocGxhbmVfYmxv Y2tzX3Blcl9saW5lIDw8Cj4+IDE2KSAvCj4+ICsJCQkJCQkJCXlfbWkKPj4gbl9zY2FubGluZXM7 Cj4+ICAgCX0gZWxzZSBpZiAoZmItPm1vZGlmaWVyWzBdID09IERSTV9GT1JNQVRfTU9EX05PTkUp IHsKPj4gICAJCXBsYW5lX2Jsb2Nrc19wZXJfbGluZSA9Cj4+IERJVl9ST1VORF9VUChwbGFuZV9i eXRlc19wZXJfbGluZSwgNTEyKQo+PiAgIAkJCQkJKyAxOwo+PiArCQlwbGFuZV9ibG9ja3NfcGVy X2xpbmUgPDw9IDE2Owo+PiAgIAl9IGVsc2Ugewo+PiAgIAkJcGxhbmVfYmxvY2tzX3Blcl9saW5l ID0KPj4gRElWX1JPVU5EX1VQKHBsYW5lX2J5dGVzX3Blcl9saW5lLCA1MTIpOwo+PiArCQlwbGFu ZV9ibG9ja3NfcGVyX2xpbmUgPDw9IDE2Owo+PiAgIAl9Cj4gVGhpcyBpcyBwcm9iYWJseSBhIHJl YmFzZSBwcm9ibGVtLCBidXQgbm90IGFsbCBwbGFjZXMgd2hlcmUKPiBwbGFuZV9ibG9ja3NfcGVy X2xpbmUgYXJlIHVzZWQgd2VyZSBmaXhlZCB0byB0YWtlIGludG8gY29uc2lkZXJhdGlvbgo+IHRo ZSBuZXcgMTYuMTYgZm9ybWF0Lgo+Cj4KPiBOb3csIHdoYXQgSSd2ZSBiZWVuIHRoaW5raW5nIGlz IHRoYXQgd2UgY29tcGxldGVseSBmYWlsIGF0IHR5cGUtc2FmZXR5Cj4gd2hlbiB3ZSBtaXggdGhl c2Ugbm9ybWFsIGludGVnZXJzIHdpdGggdGhlIDE2LjE2IGludGVnZXJzLiBJZGVhbGx5LCB3ZQo+ IHNob3VsZCBmaW5kIGEgd2F5IHRvIG1ha2UgdGhlIGNvbXBpbGVyIGNvbXBsYWluIGFib3V0IHRo aXMgdG8gdXMsIHNpbmNlCj4gaXQncyB0b28gZWFzeSB0byBtYWtlIHN1Y2ggbWlzdGFrZXMuIENh bid0IHdlIHRyeSB0byBtYWtlIHRoZSBjb21waWxlcgo+IGhlbHAgdXMsIHN1Y2ggYXMgYnkgZGVm aW5pbmcgc29tZXRoaW5nIGxpa2UKPgo+IHR5cGVkZWYgc3RydWN0IHsKPiAJdWludDMyX3QgdmFs Owo+IH0gdWludF9maXhlZF8xNl8xNl90Owpzb3VuZHMgZ29vZCB0byBoYXZlIGRpZmZlcmVudCB0 eXBlIGZvciBmaXhlZF8xNl8xNi4KClJlZ2FyZHMsCi1NYWhlc2gKPgo+IGFuZCB0aGVuIG1ha2lu ZyB0aGUgYXBwcm9wcmlhdGUgZnVuY3Rpb25zL21hY3JvcyBmb3IgbWFuaXVwbGF0aW5nIHRoZW0K PiBhbmQgbWl4aW5nIHRoZW0gd2l0aCBpbnRlZ2Vycz8gVGhpcyB3b3VsZCBoZWxwIGNhdGNoaW5n IHByb2JsZW1zIHN1Y2gKPiBhcyB0aGUgb25lIHdlIGhhdmUgaGVyZS4gQWxzbywgb3RoZXIgcGll Y2VzIG9mIGk5MTUua28gYW5kIGRybS5rbyBjb3VsZAo+IGJlbmVmaXQgZnJvbSB0aGlzLgo+Cj4+ ICAgCj4+ICAgCW1ldGhvZDEgPSBza2xfd21fbWV0aG9kMShwbGFuZV9waXhlbF9yYXRlLCBjcHAs IGxhdGVuY3kpOwo+PiBAQCAtMzY3MCw4ICszNjc3LDcgQEAgc3RhdGljIGludCBza2xfY29tcHV0 ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QKPj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ ICAgCj4+ICAgCXlfdGlsZV9taW5pbXVtID0gcGxhbmVfYmxvY2tzX3Blcl9saW5lICogeV9taW5f c2NhbmxpbmVzOwo+PiAgIAo+PiAtCWlmIChmYi0+bW9kaWZpZXJbMF0gPT0gSTkxNV9GT1JNQVRf TU9EX1lfVElMRUQgfHwKPj4gLQkgICAgZmItPm1vZGlmaWVyWzBdID09IEk5MTVfRk9STUFUX01P RF9ZZl9USUxFRCkgewo+PiArCWlmICh5X3RpbGVkKSB7Cj4+ICAgCQlzZWxlY3RlZF9yZXN1bHQg PSBtYXgobWV0aG9kMiwgeV90aWxlX21pbmltdW0pOwo+PiAgIAl9IGVsc2Ugewo+PiAgIAkJdWlu dDMyX3QgbGluZXRpbWVfdXMgPSAwOwo+PiBAQCAtMzY4OCwxMiArMzY5NCwxMSBAQCBzdGF0aWMg aW50IHNrbF9jb21wdXRlX3BsYW5lX3dtKGNvbnN0IHN0cnVjdAo+PiBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPj4gICAJCQlzZWxlY3RlZF9yZXN1bHQgPSBtZXRob2QxOwo+PiAgIAl9Cj4+ ICAgCj4+IC0JcmVzX2Jsb2NrcyA9IHNlbGVjdGVkX3Jlc3VsdCArIDE7Cj4+ICsJcmVzX2Jsb2Nr cyA9IERJVl9ST1VORF9VUChzZWxlY3RlZF9yZXN1bHQsIDEgPDwgMTYpICsgMTsKPj4gICAJcmVz X2xpbmVzID0gRElWX1JPVU5EX1VQKHNlbGVjdGVkX3Jlc3VsdCwKPj4gcGxhbmVfYmxvY2tzX3Bl cl9saW5lKTsKPj4gICAKPj4gICAJaWYgKGxldmVsID49IDEgJiYgbGV2ZWwgPD0gNykgewo+PiAt CQlpZiAoZmItPm1vZGlmaWVyWzBdID09IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEIHx8Cj4+IC0J CSAgICBmYi0+bW9kaWZpZXJbMF0gPT0gSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEKSB7Cj4+ICsJ CWlmICh5X3RpbGVkKSB7Cj4+ICAgCQkJcmVzX2Jsb2NrcyArPSB5X3RpbGVfbWluaW11bTsKPj4g ICAJCQlyZXNfbGluZXMgKz0geV9taW5fc2NhbmxpbmVzOwo+PiAgIAkJfSBlbHNlIHsKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=