From: "cron2 (Code Review)" Date: Fri, 24 Jan 2025 14:00:58 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <8a12d4f6290ca8d76ca3a358d952e195c781c31a-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="IHKzgfYKZCs="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix PASS_BY_VALUE issue in options_postprocess_mutate_le() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan , plaisthos , flichtenheld Cc: openvpn-devel --IHKzgfYKZCs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/875?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Fix PASS_BY_VALUE issue in options_postprocess_mutate_le() ...................................................................... Fix PASS_BY_VALUE issue in options_postprocess_mutate_le() Fix issue reported by Coverity: CID 1641424: Performance inefficiencies (PASS_BY_VALUE) Passing parameter ce of type "struct connection_entry" (size 208 bytes) by value, which exceeds the low threshold of 128 bytes. Commit 8466c2ca unintentionally introduced a performance penalty due to passing struct connection_entry 'ce' by value to options_postprocess_mutate_le(). fix this by passing 'ce' by address. Change-Id: I0542df021ae0ba9c982335fed7bbd10ed326dd0f Signed-off-by: Gianmarco De Gregori Acked-by: Gert Doering Message-Id: <20250124130000.20067-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 566.html Signed-off-by: Gert Doering --- M src/openvpn/options.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/75/875/2 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index c938999..bd5c056 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3323,12 +3323,12 @@ } static void -options_postprocess_mutate_le(struct connection_entry ce, struct local_ent= ry *le) +options_postprocess_mutate_le(struct connection_entry *ce, struct local_en= try *le) { /* use the global port if none is specified */ if (!le->port) { - le->port =3D ce.local_port; + le->port =3D ce->local_port; } } @@ -3777,7 +3777,7 @@ { for (i =3D 0; i < o->ce.local_list->len; i++) { - options_postprocess_mutate_le(o->ce, o->ce.local_list->array[i= ]); + options_postprocess_mutate_le(&o->ce, o->ce.local_list->array[= i]); } } else -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/875?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0542df021ae0ba9c982335fed7bbd10ed326dd0f Gerrit-Change-Number: 875 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --IHKzgfYKZCs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by its_Giaan.

View Change

The following approvals got outdated= and were removed: Code-Review+2 by cron2

Fix PASS_BY_VALUE issue in options_postprocess_mutat=
e_le()

Fix issue reported by Coverity:
CID 1641424: Performance i= nefficiencies (PASS_BY_VALUE)
Passing parameter ce of type "str= uct connection_entry"
(size 208 bytes) by value, which exceeds = the low
threshold of 128 bytes.

Commit 8466c2ca unintentional= ly introduced a performance
penalty due to passing struct connection_ent= ry 'ce'
by value to options_postprocess_mutate_le().
fix this= by passing 'ce' by address.

Change-Id: I0542df021ae0ba9c982= 335fed7bbd10ed326dd0f
Signed-off-by: Gianmarco De Gregori <gianmarco@= ...2726...>
Acked-by: Gert Doering <gert@...1296...>
Message= -Id: <20250124130000.20067-1-gert@...1296...>
URL: https://www.mai= l-archive.com/openvpn-devel@lists.sourceforge.net/msg30566.html
Signed-o= ff-by: Gert Doering <gert@...1296...>
---
M src/openvpn/options= .c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ss=
h://gerrit.openvpn.net:29418/openvpn refs/changes/75/875/2
diff --=
git a/src/openvpn/options.c b/src/openvpn/options.c
index c= 938999..bd5c056 100644
--- a/src/openvpn/options.c+++ b/src/openvpn/options.c
@@ -3323,12 +3323,12 @@=
}

static void-options_postprocess_mutate_le(= struct connection_entry ce, struct local_entry *le)
+options_postprocess_mutate_le(struct conn= ection_entry *ce, struct local_entry *le)
{
/* use the global port if none is specified */
= if (!le->port)
{
- le->port =3D ce.local_port;
+ le->port =3D ce->local_= port;
}
}
@@ -3777,7 +3777,7 @@
{
= for (i =3D 0; i < o->ce.local_list->len; i++)
= {
- o= ptions_postprocess_mutate_le(o->ce, o->ce.local_list->array[i]);
+ options_p= ostprocess_mutate_le(&o->ce, o->ce.local_list->array[i]);

}
}
else

To view, visit change 875. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0542df021ae0ba9c982335fed7b= bd10ed326dd0f
Gerrit-Change-Number: 875
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--IHKzgfYKZCs=--