Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A79DC433FE for ; Wed, 5 Oct 2022 23:41:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 99D3A84B55; Thu, 6 Oct 2022 01:41:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="uADTLYYz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 40FB384D6B; Thu, 6 Oct 2022 01:41:13 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60050.outbound.protection.outlook.com [40.107.6.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 54D7184BF0 for ; Thu, 6 Oct 2022 01:41:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AatDtZjJmVBDN1e5VpretX2UyDNeHjDXb9oZXm5NcqDZSgMcOelw3VAeBEo97UhTzApTkA/UUSgwDC/L8PQB98T8cbRprV0eyOO84aRLK/T9khyUBreCZ9/Df4OMqq5hoDjoRq7+XTNzRiaAvi7r34vZD+LiDUu6b1VMy0tIfkDVWWFZUU7UR+VnXIUdQuHe+MqIjjRgHRkN8CzNNcZf6Cd4cuwJsej+bZm5HwYJhopxqqakO0tfGXqcNdq/FYFC1HA6Ukd9gjqZWfOy2+rGRv3qltJx3EmZVnKHQVvcnlVk8c2Ffi8P+4fBmfNw4ixvyNhm6DskVUi3WsaWtKS3uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBpUljPbES6n2+wxfQMA7Hy2HC4gSlQr0PWFjukMKEs=; b=AtDPemZrRyoKTvHalMUhOFKNjB4rfr0nZ+ehxyq1QSNrJDW1kDe6K5blw58AQzYN5VK8MsNq/F4irTp1bhq1jCow+CFlGnCDbSNMrpT7e45wKqRhopTBj+kHKOJ1i794VFZVEne5zy6P2kGBzpnKeBhC70fuds39thodf0jb1YkZoerGbjKR36uNmMVD5rEF4JDLW/MBK+O6jXyewjJYB/tmfLOaMNcGVkKTkazC1Y2INKs3EvRcZ649UmOjYrX9VJYqy76Kn9yeHXOGUGfc+B+Pgi0hiuzoe1gqrld3Hf1CEbBlIuceHPDuHOC6oI6axXWJtN5E7qW8gyKNTXtIxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qBpUljPbES6n2+wxfQMA7Hy2HC4gSlQr0PWFjukMKEs=; b=uADTLYYzmKtmQNc2Fkj3QxVk4X8vGgtXZkpVVTjWl4Eg4UCHzJCKryNFNfK5s+QHapEwojqyC4rKqDF+3KzUQ7o/mKjOHzsRi9qWb/B+pHGFTiPZAp0JRYqczT2nTDPBigeVSoj6VmCrMvMOsAKhVSXN/EjApe50EiWZh/05VD3UPbFXg7/6CWC+14A2Ss6ZYByb4VPc4zZO5Li1NAEFQ07kStdsGJXLTvbX73pQY9/30lEP8d9k6rh4oJoLqzNUf/UAMr6hEVVg9JiTuhqP48WwHR2OZer2jmVEg4bpiuqpgPL3Yzcp5Vvu2b1vIUqYRe15FAgE7CRf6vVT2iG2GQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) by DB9PR03MB7657.eurprd03.prod.outlook.com (2603:10a6:10:2bd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Wed, 5 Oct 2022 23:41:05 +0000 Received: from DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::204a:de22:b651:f86d]) by DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::204a:de22:b651:f86d%6]) with mapi id 15.20.5676.034; Wed, 5 Oct 2022 23:41:05 +0000 Message-ID: <8a4cd979-b23f-d2bb-1012-bfdc25094e89@seco.com> Date: Wed, 5 Oct 2022 19:41:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Sean Anderson Subject: Re: [PATCH 0/3] arm: smh: Fix and improve semihosting traps To: Andre Przywara , Tom Rini , Sean Anderson Cc: u-boot@lists.denx.de References: <20221005163849.3205046-1-andre.przywara@arm.com> Content-Language: en-US In-Reply-To: <20221005163849.3205046-1-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR02CA0030.namprd02.prod.outlook.com (2603:10b6:207:3c::43) To DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR03MB4972:EE_|DB9PR03MB7657:EE_ X-MS-Office365-Filtering-Correlation-Id: ee6f912c-517a-4a18-fb5c-08daa72b11c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SmxRWEtu35R7LpOo2PU1nHlXm2iE9T8HO8gle5Z2DhkRDh+96CtKvQkSokLl/cSQ4a1O9Fh1w58wlcdjeuv+Pdbtx5CLANHiQLYR5jxkfVp9nQmKy1KWE/bTQQnwzJr+FIjEK6T9sh3syxEAz8sYTHHMOdeqPLqRNXUAlIqJN55AG5Q31uU7wkeuKyt6vPXnjcBjL5xq/JMpkG6/UaX9n70S/VQFGUQzNuPvJGvvCvUV4Us1FLCmcAo8bkGqtbcjr3rlqf+0mvVFdiANKPgD3/J2zMtUy6c02nm2anuGsgUdYKMhaDsem9Yac5uuCt6Xoy3WFnWFEeJxd0TLapwNCj6d5SqDNv4ErELJgkXwYW+c/T3r+GkubDBaHBeaucO2bdE0rkIPGAs6Ij1IjVm8QpBp0qurq4H7ExCOW/1luzm5dbeJkJ+0nbFzLzEG9NCdvY9ftwQQAxeX54yLHVN+oQ/gss8dIW2VvJ2nZk+Pcq0HkqiX+cEaxdqTWDSV8sXJGTmJWm3JnNhWxm5sR0Qe5+IooTElMzNUGI5YMvye2AJbMsRz1dP83d9FOlNqDyfpF3m72ryNQASEktb7giRd9znEyWgE9Di5IqkOpIlSUVp+i+rYm+i+7OvcAstArOBWRww0xSDUQAwj7wFbjE0gtk3H59kLcAfOheoczhIQ+XRNItSmw5/eM5vDA0NkKe+jEAYVMNPZN3VaP4xkW6mJ/Qx/Lv7Lb0N0aErIvURwN44N536wnT4acauue65nTcPhON/rzPNbG/HTZxd890XhL4j0DmBWbJ2uJiYTlcn6xVUQjGK97LT9PCpbSc6+46NsjmZCoc7kP4csY8FquNlQaHjkLVmu5+nG6aUru8K4Wog= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4972.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(346002)(39850400004)(396003)(136003)(451199015)(966005)(316002)(478600001)(31686004)(6486002)(110136005)(44832011)(38100700002)(66476007)(186003)(4326008)(6666004)(66556008)(41300700001)(36756003)(66946007)(8676002)(38350700002)(6506007)(4744005)(53546011)(5660300002)(86362001)(26005)(31696002)(6512007)(2616005)(8936002)(2906002)(83380400001)(52116002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkNvSzlWWVlGcnZrdTlYNXFnR3NsUVNyTk1FeUM4ZGlobThwQjBWTWtWbURh?= =?utf-8?B?NTg4UzNSL1RJZGJnWTUvTmxrVC9oSWY5eitNd2w1UTJRUEE2cUxVVzE5UEZD?= =?utf-8?B?dDFIVjFseWFzMmdpeHQ3elRWZndmbTlFaDVhNk5PODZxOXlHTlg1c1BFbEZP?= =?utf-8?B?a1lHeFFOTTR1MldwY29HVEZXMzhnU1FFbWFzNGk4d08zeXEvRmI2MEJZQ05G?= =?utf-8?B?YmRGZ2MzSVdPTmFBcHNFWTBqdXJNblRYWjZTbENqVFozajJNeU9KVU9EOStB?= =?utf-8?B?bEZnYWxEamdtajY0VTVGeUtyZFp3eHpjN2tXUTlLNXRRTExUN2tKMzBiWWQx?= =?utf-8?B?b0RzcXRlUzlvQ0sxdDh2T25DMWJJdTY3c2c2blN5MUtpd1RlT2I5NVZSMVpv?= =?utf-8?B?NEZ1RElDUjltSkZYdFVkY3ZsMEhvMEFubEVWcFd6djhsQUcyczBvck95K1ZF?= =?utf-8?B?OEN2YkFOeTlUV0wybXZOSkV2MmZpc1doM2pTY1NvUXFncDlHWmxPbTF3VjVH?= =?utf-8?B?RnlsSnNUWDFPWnc5T0JQb3JOSWNWYXR0TDhZdjZKcStsbWFvU3RGaGxVSTNU?= =?utf-8?B?cmpIaDMzZHNNVjA1dTBLYTZpUnlNYS9SWXd4UE1ucG80YTcyODVheVBHVFBs?= =?utf-8?B?clB0bnBSd0p2NnphZ3RpMGJJcG9TZHNuZStDTHhVeTlNNHRKQSsrZThPUmpQ?= =?utf-8?B?V1FnTnFVSTlXWDlRUW5rbHYraGNlSnNhcWRGV3lLODEySlBrWDFNaFRoYUMy?= =?utf-8?B?S29rcTFTWjhHWkg2T3AwSVo4aFBYeGN0RVp6WHRQbUhFOTZoRUtNY0VFTk9U?= =?utf-8?B?bnd4QjRLdmdLbE9QVFZtNUtDRUNOaTNrd01IazUvOUZucVh6NjlzSEdSTEFp?= =?utf-8?B?TVlCaExCaGNHYTRtTTdkWjgvdWR6Ym44d2xranRnTHdUVnVqUTlNWkNNSkVa?= =?utf-8?B?T1dmWHR0ZlJTd0xadytTL1VuTXgra3lMYzBLYkw1d3RzM29HeEl4QjJRUW0v?= =?utf-8?B?VEdWTEhkd3ZGMzUwUDk3cmtUeVY5dmxuU243eTZYOXRuVjRMMitiOEtCR0lM?= =?utf-8?B?dFhKbXR1ajNlYy93VXZwaWtJbW5DbmFJYUMvOUU2bGpCcWlvTXk1Z2xFY1RU?= =?utf-8?B?bVA1NXNWVnNtdFdXN2ltZWdGRGxXZ1hGSjRobmlxdjdjNjlOZ3ZPVjgwby9v?= =?utf-8?B?NEEwcXovaFQzL1UwZCtJOGFVd0hWa3lEUFNadzlUV0tMbG4rTVhOWjJ5Z2M0?= =?utf-8?B?bUN6Q1F3cWlGWU9xM2QrNS9JSnBTWXpIOEF2dWJzZkZydGlSRkJvbHUzdWZF?= =?utf-8?B?TDlBaEVVM1dqOUZ2NmhzbDI2cCtwNFhvSVFWK3dOdVRGTXZqYTd1Skozbzgr?= =?utf-8?B?KzlWRm52M29WUTN0SmhGYys4MDFoeFpKNW52eEd5ekZDYmNGakFMbkY2MnFh?= =?utf-8?B?R01tTXNHQ3o1SWh6bkU1eklDbUpoUkN3RG1kM2xUUG54dGdaMGhwdGFicU9z?= =?utf-8?B?Y1AwMGxWKytjNTlPRDJFTXYwcWo3TFVxKys3WHVHcEM5SGE2cWVEMzNOUDFl?= =?utf-8?B?bEdKWVZGeTQ2cE8rZ0FjSkRJZmpiYWZPcjJxUzlraFVaaTBua3pMMnRQTnlI?= =?utf-8?B?WmdVRVR0cmFxMlJPd0tleGhFQmhoRWdWZC9vTDUxY1RTRTh2MGNzZHEzdGo2?= =?utf-8?B?bUZJbWphdHVmdEhtWFRoaVRHRWNMZzJibkVoUisrWDhsZHQ2MTVyYjA2bWQy?= =?utf-8?B?WGxrdXZlUC9ZbU1PQm4ySkNmNlgzcGdHaWhVSFp0MnNrNlYzV0dseTdSelc0?= =?utf-8?B?VElhVmdlRzBydlIyc1hoSFpicHB2U0VhRFg2NURCaGF5NjdxL051bjlmVTJ1?= =?utf-8?B?dFBXV21GSDZLTmFOT2RnOHp4Z2Z4dVBUM052VVluS3NRb1I4R3BoWDVsV01p?= =?utf-8?B?Wmt6YTRFMkZVWXZoWkp6bU1aVzk3UU9JRGVZZ1pnWENqTEw4clUwYTdKb3RX?= =?utf-8?B?UllyelhvdXd3OUM1aldZZGNkTEo0VzdvUjFhT3FaMFRjTzJDRHcxZzh0ZC9G?= =?utf-8?B?V0YyZm9SR2cxRGplQUlOZjdJTThkME5oVzAxRkNOLzRzRmVuaXk1aXVZS1dO?= =?utf-8?Q?i/XsCsEpZVty3+Rh15NlGSRCF?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee6f912c-517a-4a18-fb5c-08daa72b11c4 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 23:41:05.2556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rDrISmhsmhTs3gePSSpc69Szxi8T6Xet5vvNcHLQEUY5e10bEzDY/YhR0lmHOf9clEcz16sJvyH3W17SQYMrSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7657 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 10/5/22 12:38, Andre Przywara wrote: > While playing around with QEMU's semihosting implementation, I stared at > our semihosting trap code, and found some issues, that this mini-series > fixes. > > Please have a look! > > Cheers, > Andre > > Andre Przywara (3): > arm: smh: specify Thumb trap instruction > arm: smh: Make semihosting trap calls more robust > arm: smh: Allow semihosting trap calls to be inlined > > arch/arm/lib/semihosting.c | 44 +++++++++++++++++++++++++++----------- > 1 file changed, 31 insertions(+), 13 deletions(-) > This all LGTM Although I wonder if we should just move smh_trap into an assembly file. I think that would apply most of these optimization barriers. Your series will also confict with Kautuk's series [1]. I think the bugs you described above will apply to RISC-V as well. --Sean [1] https://lore.kernel.org/all/20220923070320.617623-1-kconsul@ventanamicro.com/