From: "flichtenheld (Code Review)" Date: Fri, 14 Jun 2024 12:55:14 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <8a97a2c846c3307974268b2232e5c1420e53fe00-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="pCb6sMrskiA="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove "experimental" denotation for --fast-io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --pCb6sMrskiA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/664?usp=3Demail to review the following change. Change subject: Remove "experimental" denotation for --fast-io ...................................................................... Remove "experimental" denotation for --fast-io This option is very old (from SVN days) and has been used by Access Server for many years. I don't think it makes sense to claim that it is "experimental" at this point. Change-Id: I913bb70c5e527e78e7cdb43110e23a8944f35a22 Signed-off-by: Frank Lichtenheld --- M doc/man-sections/generic-options.rst M src/openvpn/options.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/664/1 diff --git a/doc/man-sections/generic-options.rst b/doc/man-sections/generi= c-options.rst index f8a0f48..eb9cf28 100644 --- a/doc/man-sections/generic-options.rst +++ b/doc/man-sections/generic-options.rst @@ -215,7 +215,7 @@ are supported by OpenSSL. --fast-io - (Experimental) Optimize TUN/TAP/UDP I/O writes by avoiding a call to + Optimize TUN/TAP/UDP I/O writes by avoiding a call to poll/epoll/select prior to the write operation. The purpose of such a call would normally be to block until the device or socket is ready to accept the write. Such blocking is unnecessary on some platforms which diff --git a/src/openvpn/options.c b/src/openvpn/options.c index abcde89..f2c7536 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -268,7 +268,7 @@ #if ENABLE_IP_PKTINFO "--multihome : Configure a multi-homed UDP server.\n" #endif - "--fast-io : (experimental) Optimize TUN/TAP/UDP writes.\n" + "--fast-io : Optimize TUN/TAP/UDP writes.\n" "--remap-usr1 s : On SIGUSR1 signals, remap signal (s=3D'SIGHUP' or '= SIGTERM').\n" "--persist-tun : Keep tun/tap device open across SIGUSR1 or --ping-r= estart.\n" "--persist-remote-ip : Keep remote IP address across SIGUSR1 or --ping= -restart.\n" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/664?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I913bb70c5e527e78e7cdb43110e23a8944f35a22 Gerrit-Change-Number: 664 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --pCb6sMrskiA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

Vi= ew Change

Remove "experimental" denotation for --fast-io
<= br>This option is very old (from SVN days) and has been
used by Access S= erver for many years. I don't think it
makes sense to claim that it = is "experimental" at this
point.

Change-Id: I913bb70c5e= 527e78e7cdb43110e23a8944f35a22
Signed-off-by: Frank Lichtenheld <fran= k@...2641...>
---
M doc/man-sections/generic-options.rst
M src/= openvpn/options.c
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/664/1<=
/pre>
-  (Experim=
ental) Optimize TUN/TAP/UDP I/O writes by avoiding a call to
+ Optimize TUN/TAP/UDP I/O writes = by avoiding a call to
poll/epoll/select prior to the wri= te operation. The purpose of such a
call would normally = be to block until the device or socket is ready to
accep= t the write. Such blocking is unnecessary on some platforms whichdiff --git a/src/openvpn/options.c b/src/openvpn/options.cindex abcde89..f2c7536 100644
--- a/src/openvpn/opti= ons.c
+++ b/src/openvpn/options.c
@@ -268,7= +268,7 @@
#if ENABLE_IP_PKTINFO
&quo= t;--multihome : Configure a multi-homed UDP server.\n"
<= span> #endif
- "= ;--fast-io : (experimental) Optimize TUN/TAP/UDP writes.\n"

+ "--fast-io = : Optimize TUN/TAP/UDP writes.\n"
"--remap= -usr1 s : On SIGUSR1 signals, remap signal (s=3D'SIGHUP' or 'S= IGTERM').\n"
"--persist-tun : Keep tun= /tap device open across SIGUSR1 or --ping-restart.\n"
= "--persist-remote-ip : Keep remote IP address across SIGUSR1 or -= -ping-restart.\n"

To view, visit <= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/664?usp=3Demail">change 664= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I913bb70c5e527e78e7cdb43110e= 23a8944f35a22
Gerrit-Change-Number: 664
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--pCb6sMrskiA=--