From: "flichtenheld (Code Review)"
Date: Thu, 20 Mar 2025 10:33:38 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <8afc6e9ee035b98920d6f2c11792b98f265d45a1-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="SNXhLZ3Rt04="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Define a
.clang-format file for the project
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , openvpn-devel
--SNXhLZ3Rt04=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/790?usp=3Demail )
Change subject: Define a .clang-format file for the project
......................................................................
Patch Set 9:
(1 comment)
File .clang-format:
http://gerrit.openvpn.net/c/openvpn/+/790/comment/f971bb03_d7cf6623 :
PS9, Line 25: ColumnLimit: '100'
> How did we end up with 100? [=E2=80=A6]
Before we had *no* limits, our `uncrustify.conf` does not enforce any.
I came up with the 100 by looking at the code and seeing how well it fits. =
100 seems a good compromise to me. With clang-format it will use the full w=
idth available to it. So 120 is too wide I think, but 80 is obviously much =
too restrictive. If you prefer a different limit, let me know.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/790?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I40f6af10c5ee2f5aed4185d783fc622a2e3c19ff
Gerrit-Change-Number: 790
Gerrit-PatchSet: 9
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Thu, 20 Mar 2025 10:33:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos
Gerrit-MessageType: comment
--SNXhLZ3Rt04=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
View C=
hange
1 comment:
<=
li style=3D"margin: 0; padding: 0;">File .clang-format:
Before we had *no* li=
mits, our `uncrustify.conf` does not enforce any.
I came up with the 100 by looking at t=
he code and seeing how well it fits. 100 seems a good compromise to me. Wit=
h clang-format it will use the full width available to it. So 120 is too wi=
de I think, but 80 is obviously much too restrictive. If you prefer a diffe=
rent limit, let me know.
To view, visit change 790. =
To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I40f6af10c5ee2f5aed4185d783f=
c622a2e3c19ff
Gerrit-Change-Number: 790
Gerrit-PatchSet: 9
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Thu, 20 Mar 2025 10:33:38=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Gerrit-MessageType: comment
--SNXhLZ3Rt04=--