From: "plaisthos (Code Review)"
Date: Wed, 3 Jan 2024 14:40:16 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID: <8b2f0582df29fadaa6e2fee3da5c4cf7a9973d30-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="6BPfpQS2cdY="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Use mingw compile
definition also to unit tests
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , openvpn-devel
--6BPfpQS2cdY=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/469?usp=3Demail )
Change subject: Use mingw compile definition also to unit tests
......................................................................
Patch Set 3:
(2 comments)
File CMakeLists.txt:
http://gerrit.openvpn.net/c/openvpn/+/469/comment/b683acf6_b1411977 :
PS3, Line 293: target_compile_options(${target} PRIVATE -municode -=
UUNICODE)
> combining -municode with -UUNICODE and main(void) just means the -municod=
e has no effect at all. [=E2=80=A6]
I updated the patch to only use the same defines but not the -municode. Aft=
er looking up -U that it undefines UNICODE I am not really sure anymore why=
we use that for the normal mingw build.
http://gerrit.openvpn.net/c/openvpn/+/469/comment/5b8769bf_b8607c4b :
PS3, Line 666: target_compile_definitions(${test_name} PRIVATE =
-Dmain=3Dwmain)
> Yeah, just don't use -municode in the first place.
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/469?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b
Gerrit-Change-Number: 469
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 03 Jan 2024 14:40:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--6BPfpQS2cdY=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
combining -mu=
nicode with -UUNICODE and main(void) just means the -municode has no effect=
at all. [=E2=80=A6]
I updated the patch to only use the same defines but n=
ot the -municode. After looking up -U that it undefines UNICODE I am not re=
ally sure anymore why we use that for the normal mingw build.
<=
a href=3D"http://gerrit.openvpn.net/c/openvpn/+/469/comment/5b8769bf_b8607c=
4b">Patch Set #3, Line 666: target_compile_definitions(${test_name} PRIVATE -Dmain=3Dw=
main)
Yeah, just don't use -municode in the first=
place.
Done
To view, visit change 469. To unsubscribe=
, or for help writing mail filters, visit settings.