From: Michel Thierry Subject: Re: [PATCH] drm/i915/icl: Read the correct Gen11 interrupt registers Date: Thu, 17 May 2018 09:55:38 -0700 Message-ID: <8b3c31fa-59e3-e07b-58d2-7f35a21979c5@intel.com> References: <1525987387-12399-1-git-send-email-oscar.mateo@intel.com> <1525989595-18220-1-git-send-email-oscar.mateo@intel.com> <1526513950.2496.7.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 330586EADC for ; Thu, 17 May 2018 16:55:42 +0000 (UTC) In-Reply-To: <1526513950.2496.7.camel@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni , "Mateo Lozano, Oscar" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gNS8xNi8yMDE4IDQ6MzkgUE0sIFBhdWxvIFphbm9uaSB3cm90ZToKPiBFbSBRdWksIDIwMTgt MDUtMTAgw6BzIDE0OjU5IC0wNzAwLCBPc2NhciBNYXRlbyBlc2NyZXZldToKPj4gU3RvcCByZWFk aW5nIHNvbWUgbm93IGRlcHJlY2F0ZWQgaW50ZXJydXB0IHJlZ2lzdGVycyBpbiBib3RoCj4+IGRl YnVnZnMgYW5kIGVycm9yIHN0YXRlLiBJbnN0ZWFkLCByZWFkIHRoZSBuZXcgZXF1aXZhbGVudHMg aW4gdGhlCj4+IEdlbjExIGludGVycnVwdCByZXBhcnRpdGlvbmluZyBzY2hlbWUuCj4+Cj4+IE5v dGUgdGhhdCB0aGUgZXF1aXZhbGVudCB0byB0aGUgUE0gSVNSICYgSUlSIGNhbm5vdCBiZSByZWFk IHdpdGhvdXQKPj4gYWZmZWN0aW5nIHRoZSBjdXJyZW50IHN0YXRlIG9mIHRoZSBzeXN0ZW0sIHNv IEkndmUgb3B0ZWQgZm9yIGxlYXZpbmcKPj4gdGhlbSBvdXQuIFNlZSBnZW4xMV9zZXJ2aWNlX29u ZV9paXIoKSBmb3IgbW9yZSBpbmZvLgo+IAo+IEkgY2FuJ3QgZmluZCB0aGlzIGZ1bmN0aW9uLiBE aWQgeW91IG1lYW4gc29tZXRoaW5nIGVsc2U/Cj4gCgpzL2dlbjExX3NlcnZpY2Vfb25lX2lpci9n ZW4xMV9yZXNldF9vbmVfaWlyLwoKPiAKPiAKPj4KPj4gdjI6IGVsc2UgaWYgISEhIChQYXVsbykK Pj4gdjM6IGFub3RoZXIgZWxzZSBpZiAoVmluYXkpCj4+IHY0Ogo+PiAgICAtIFJlYmFzZWQKPj4g ICAgLSBSZW5hbWVkIHBhdGNoCj4+ICAgIC0gSW1wcm92ZWQgdGhlIG9yZGVyaW5nIG9mIEdFTnMK Pj4gICAgLSBJbXByb3ZlZCB0aGUgcHJpbnRpbmcgb2YgcGVyLUdFTiBpbmZvCj4+IHY1OiBBdm9p ZCBtYXliZS11bml0aWFsaXplZCAmIGFkZCBjb21tZW50IGV4cGxhaW5pbmcgdGhlIGxhY2sKPj4g ICAgICBvZiBQTSBJU1IgJiBJSVIKPj4KPj4gU3VnZ2VzdGVkLWJ5OiBQYXVsbyBaYW5vbmkgPHBh dWxvLnIuemFub25pQGludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogT3NjYXIgTWF0ZW8gPG9z Y2FyLm1hdGVvQGludGVsLmNvbT4KPj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxp bkBpbnRlbC5jb20+Cj4+IENjOiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFv bG9zcHVyaW9AaW50ZWwuY29tPgo+PiBDYzogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2Ft YmxlQGludGVsLmNvbT4KPj4gQ2M6IFZpbmF5IEJlbGdhdW1rYXIgPHZpbmF5LmJlbGdhdW1rYXJA aW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMu YyAgIHwgMzQgKysrKysrKysrKysrKysrKysrKysrKysrLQo+PiAtLS0tLS0tLS0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jIHwgMTEgKysrKysrKysrKy0KPj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5oIHwgIDIgKy0KPj4gICAzIGZpbGVz IGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4gYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+PiBpbmRleCBkNjYzYTllMC4uZDk5MmRkMiAxMDA2 NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPj4gQEAgLTExNzAsMTkgKzExNzAs MjggQEAgc3RhdGljIGludCBpOTE1X2ZyZXF1ZW5jeV9pbmZvKHN0cnVjdAo+PiBzZXFfZmlsZSAq bSwgdm9pZCAqdW51c2VkKQo+PiAgIAo+PiAgIAkJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQo ZGV2X3ByaXYsIEZPUkNFV0FLRV9BTEwpOwo+PiAgIAo+PiAtCQlpZiAoSVNfR0VONihkZXZfcHJp dikgfHwgSVNfR0VONyhkZXZfcHJpdikpIHsKPj4gLQkJCXBtX2llciA9IEk5MTVfUkVBRChHRU42 X1BNSUVSKTsKPj4gLQkJCXBtX2ltciA9IEk5MTVfUkVBRChHRU42X1BNSU1SKTsKPj4gLQkJCXBt X2lzciA9IEk5MTVfUkVBRChHRU42X1BNSVNSKTsKPj4gLQkJCXBtX2lpciA9IEk5MTVfUkVBRChH RU42X1BNSUlSKTsKPj4gLQkJCXBtX21hc2sgPSBJOTE1X1JFQUQoR0VONl9QTUlOVFJNU0spOwo+ PiAtCQl9IGVsc2Ugewo+PiArCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkgewo+PiAr CQkJcG1faWVyID0KPj4gSTkxNV9SRUFEKEdFTjExX0dQTV9XR0JPWFBFUkZfSU5UUl9FTkFCTEUp Owo+PiArCQkJcG1faW1yID0KPj4gSTkxNV9SRUFEKEdFTjExX0dQTV9XR0JPWFBFUkZfSU5UUl9N QVNLKTsKPj4gKwkJCS8qCj4+ICsJCQkgKiBUaGUgZXF1aXZhbGVudCB0byB0aGUgUE0gSVNSICYg SUlSIGNhbm5vdAo+PiBiZSByZWFkCj4+ICsJCQkgKiB3aXRob3V0IGFmZmVjdGluZyB0aGUgY3Vy cmVudCBzdGF0ZSBvZgo+PiB0aGUgc3lzdGVtCj4+ICsJCQkgKi8KPj4gKwkJCXBtX2lzciA9IDA7 Cj4+ICsJCQlwbV9paXIgPSAwOwo+PiArCQl9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikg Pj0gOCkgewo+PiAgIAkJCXBtX2llciA9IEk5MTVfUkVBRChHRU44X0dUX0lFUigyKSk7Cj4+ICAg CQkJcG1faW1yID0gSTkxNV9SRUFEKEdFTjhfR1RfSU1SKDIpKTsKPj4gICAJCQlwbV9pc3IgPSBJ OTE1X1JFQUQoR0VOOF9HVF9JU1IoMikpOwo+PiAgIAkJCXBtX2lpciA9IEk5MTVfUkVBRChHRU44 X0dUX0lJUigyKSk7Cj4+IC0JCQlwbV9tYXNrID0gSTkxNV9SRUFEKEdFTjZfUE1JTlRSTVNLKTsK Pj4gKwkJfSBlbHNlIHsKPj4gKwkJCXBtX2llciA9IEk5MTVfUkVBRChHRU42X1BNSUVSKTsKPj4g KwkJCXBtX2ltciA9IEk5MTVfUkVBRChHRU42X1BNSU1SKTsKPj4gKwkJCXBtX2lzciA9IEk5MTVf UkVBRChHRU42X1BNSVNSKTsKPj4gKwkJCXBtX2lpciA9IEk5MTVfUkVBRChHRU42X1BNSUlSKTsK Pj4gICAJCX0KPj4gKwkJcG1fbWFzayA9IEk5MTVfUkVBRChHRU42X1BNSU5UUk1TSyk7Cj4+ICsK Pj4gICAJCXNlcV9wcmludGYobSwgIlZpZGVvIFR1cmJvIE1vZGU6ICVzXG4iLAo+PiAgIAkJCSAg IHllc25vKHJwbW9kZWN0bCAmIEdFTjZfUlBfTUVESUFfVFVSQk8pKTsKPj4gICAJCXNlcV9wcmlu dGYobSwgIkhXIGNvbnRyb2wgZW5hYmxlZDogJXNcbiIsCj4+IEBAIC0xMTkwLDggKzExOTksMTMg QEAgc3RhdGljIGludCBpOTE1X2ZyZXF1ZW5jeV9pbmZvKHN0cnVjdCBzZXFfZmlsZQo+PiAqbSwg dm9pZCAqdW51c2VkKQo+PiAgIAkJc2VxX3ByaW50ZihtLCAiU1cgY29udHJvbCBlbmFibGVkOiAl c1xuIiwKPj4gICAJCQkgICB5ZXNubygocnBtb2RlY3RsICYKPj4gR0VONl9SUF9NRURJQV9NT0RF X01BU0spID09Cj4+ICAgCQkJCSAgR0VONl9SUF9NRURJQV9TV19NT0RFKSk7Cj4+IC0JCXNlcV9w cmludGYobSwgIlBNIElFUj0weCUwOHggSU1SPTB4JTA4eCBJU1I9MHglMDh4Cj4+IElJUj0weCUw OHgsIE1BU0s9MHglMDh4XG4iLAo+PiAtCQkJICAgcG1faWVyLCBwbV9pbXIsIHBtX2lzciwgcG1f aWlyLCBwbV9tYXNrKTsKPj4gKwo+PiArCQlzZXFfcHJpbnRmKG0sICJQTSBJRVI9MHglMDh4IElN Uj0weCUwOHgsCj4+IE1BU0s9MHglMDh4XG4iLAo+PiArCQkJICAgcG1faWVyLCBwbV9pbXIsIHBt X21hc2spOwo+PiArCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDExKSB7Cj4+ICsJCQlzZXFf cHJpbnRmKG0sICJQTSBJU1I9MHglMDh4IElJUj0weCUwOHhcbiIsCj4+ICsJCQkJICAgcG1faXNy LCBwbV9paXIpOwo+PiArCQl9Cj4+ICAgCQlzZXFfcHJpbnRmKG0sICJwbV9pbnRybXNrX21iejog MHglMDh4XG4iLAo+PiAgIAkJCSAgIHJwcy0+cG1faW50cm1za19tYnopOwo+PiAgIAkJc2VxX3By aW50ZihtLCAiR1RfUEVSRl9TVEFUVVM6IDB4JTA4eFxuIiwKPj4gZ3RfcGVyZl9zdGF0dXMpOwo+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+PiBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPj4gaW5kZXggYjk4Y2Q0NC4u ZDlmMmY2OSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJy b3IuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4+IEBA IC0xNjc1LDcgKzE2NzUsMTYgQEAgc3RhdGljIHZvaWQgY2FwdHVyZV9yZWdfc3RhdGUoc3RydWN0 Cj4+IGk5MTVfZ3B1X3N0YXRlICplcnJvcikKPj4gICAJfQo+PiAgIAo+PiAgIAkvKiA0OiBFdmVy eXRoaW5nIGVsc2UgKi8KPj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA4KSB7Cj4+ICsJ aWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpIHsKPj4gKwkJZXJyb3ItPmllciA9IEk5MTVf UkVBRChHRU44X0RFX01JU0NfSUVSKTsKPj4gKwkJZXJyb3ItPmd0aWVyWzBdID0KPj4gSTkxNV9S RUFEKEdFTjExX1JFTkRFUl9DT1BZX0lOVFJfRU5BQkxFKTsKPj4gKwkJZXJyb3ItPmd0aWVyWzFd ID0KPj4gSTkxNV9SRUFEKEdFTjExX1ZDU19WRUNTX0lOVFJfRU5BQkxFKTsKPj4gKwkJZXJyb3It Pmd0aWVyWzJdID0KPj4gSTkxNV9SRUFEKEdFTjExX0dVQ19TR19JTlRSX0VOQUJMRSk7Cj4+ICsJ CWVycm9yLT5ndGllclszXSA9Cj4+IEk5MTVfUkVBRChHRU4xMV9HUE1fV0dCT1hQRVJGX0lOVFJf RU5BQkxFKTsKPj4gKwkJZXJyb3ItPmd0aWVyWzRdID0KPj4gSTkxNV9SRUFEKEdFTjExX0NSWVBU T19SU1ZEX0lOVFJfRU5BQkxFKTsKPj4gKwkJZXJyb3ItPmd0aWVyWzVdID0KPj4gSTkxNV9SRUFE KEdFTjExX0dVTklUX0NTTUVfSU5UUl9FTkFCTEUpOwo+PiArCQllcnJvci0+bmd0aWVyID0gNjsK Pj4gKwl9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOCkgewo+PiAgIAkJZXJyb3It PmllciA9IEk5MTVfUkVBRChHRU44X0RFX01JU0NfSUVSKTsKPj4gICAJCWZvciAoaSA9IDA7IGkg PCA0OyBpKyspCj4+ICAgCQkJZXJyb3ItPmd0aWVyW2ldID0gSTkxNV9SRUFEKEdFTjhfR1RfSUVS KGkpKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9y LmgKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5oCj4+IGluZGV4IGRh YzBmOGMuLjU4OTEwZjEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z3B1X2Vycm9yLmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3Iu aAo+PiBAQCAtNTgsNyArNTgsNyBAQCBzdHJ1Y3QgaTkxNV9ncHVfc3RhdGUgewo+PiAgIAl1MzIg ZWlyOwo+PiAgIAl1MzIgcGd0YmxfZXI7Cj4+ICAgCXUzMiBpZXI7Cj4+IC0JdTMyIGd0aWVyWzRd LCBuZ3RpZXI7Cj4+ICsJdTMyIGd0aWVyWzZdLCBuZ3RpZXI7Cj4+ICAgCXUzMiBjY2lkOwo+PiAg IAl1MzIgZGVycm1yOwo+PiAgIAl1MzIgZm9yY2V3YWtlOwo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK