From: "plaisthos (Code Review)" Date: Mon, 7 Jul 2025 12:06:39 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., rein.vanbaaren@...1435..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <8ba1dc7fc0244cb6fd38e4032ec52cf8eb58e8b1-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="vsAC1IJXkBw="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Added PQE to WolfSSL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: comododragon Cc: flichtenheld , openvpn-devel --vsAC1IJXkBw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: comododragon, cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/1046?usp=3Demail ) Change subject: Added PQE to WolfSSL ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File README.wolfssl: http://gerrit.openvpn.net/c/openvpn/+/1046/comment/590f267a_2d630a04 : PS6, Line 59: OpenSSL does not accept the P curve notation and instead uses= the equivalent secp notation. Still white space errors. Maybe we can fix them on merge. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef53090a6edbd35 Gerrit-Change-Number: 1046 Gerrit-PatchSet: 6 Gerrit-Owner: comododragon Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Attention: comododragon Gerrit-Comment-Date: Mon, 07 Jul 2025 12:06:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --vsAC1IJXkBw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: comododragon, cron2, flichtenheld= .

Patch set 6:Code-Review +2=

V= iew Change

1 comment:

  • File README.wolfssl:

    • Patch Set #6, Line 59: <= code style=3D"font-family:monospace,monospace">OpenSSL does not accept the = P curve notation and instead uses the equivalent secp notation.

      =

      Still white spac= e errors. Maybe we can fix them on merge.

To view= , visit = change 1046. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef= 53090a6edbd35
Gerrit-Change-Number: 1046
Gerrit-PatchSet: 6
Gerrit-Owner: comododragon <rein.vanbaaren@= ...1435...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: comododragon <rein.vanbaa= ren@...1435...>
Gerrit-Comment-Date: Mon, 07 Jul 2025 12:06:39= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--vsAC1IJXkBw=--