From: "cron2 (Code Review)" Date: Wed, 14 Jan 2026 18:35:27 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, antonio@...2726... Message-ID: <8bcb08de70f0a413d1937e195d166afab11a60d7-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="VhtHqPl7iMo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[release/2.6]: Add check for bind-dev in DCO options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --VhtHqPl7iMo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=3Demail to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by ordex Change subject: Add check for bind-dev in DCO options ...................................................................... Add check for bind-dev in DCO options Github: OpenVPN/openvpn#683 Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5 Signed-off-by: Gert Doering Acked-by: Antonio Quartulli Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1447 Message-Id: <20260114160238.31321-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35= 260.html Signed-off-by: Gert Doering --- M src/openvpn/dco.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1447/3 diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index e41d59f..06d5920 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -317,6 +317,12 @@ } } + if (o->bind_dev) + { + msg(msglevel, "Note: bind-dev not supported with DCO, disabling da= ta channel offload"); + return false; + } + #if defined(_WIN32) if (o->mode =3D=3D MODE_SERVER) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5 Gerrit-Change-Number: 1447 Gerrit-PatchSet: 3 Gerrit-Owner: cron2 Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --VhtHqPl7iMo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #3 to this change.

View Change

The followi= ng approvals got outdated and were removed: Code-Review+2 by ordex

Add check for bind-dev in DCO optio=
ns

Github: OpenVPN/openvpn#683

Change-Id: I5d5fca3f5f7a724b4f= 9ec98832d3a785459f36a5
Signed-off-by: Gert Doering <gert@...1296...&g= t;
Acked-by: Antonio Quartulli <antonio@...2726...>
Gerrit URL:= https://gerrit.openvpn.net/c/openvpn/+/1447
Message-Id: <20260114160= 238.31321-1-gert@...1296...>
URL: https://www.mail-archive.com/openvp= n-devel@lists.sourceforge.net/msg35260.html
Signed-off-by: Gert Doering = <gert@...1296...>
---
M src/openvpn/dco.c
1 file changed, 6 = insertions(+), 0 deletions(-)

git pull ssh://ger=
rit.openvpn.net:29418/openvpn refs/changes/47/1447/3
diff --git a/s=
rc/openvpn/dco.c b/src/openvpn/dco.c
index e41d59f..06d5920= 100644
--- a/src/openvpn/dco.c
+++ b/src/o= penvpn/dco.c
@@ -317,6 +317,12 @@
= }
}

+ if (o->bind_dev)
+ {
+ msg(msglevel, "Note: bind-dev not supported with = DCO, disabling data channel offload");
+ return false;
+ }
+
#if defined(_WIN32)
if (= o->mode =3D=3D MODE_SERVER)
{

To view, visit change 1447. To unsubscribe, or for help writing = mail filters, visit settings.

=
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d= 3a785459f36a5
Gerrit-Change-Number: 1447
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --VhtHqPl7iMo=--