From: Madhav Chauhan Subject: Re: [PATCH v8 22/38] drm/i915/icl: Load DSI packet payload to queue Date: Wed, 31 Oct 2018 17:21:37 +0530 Message-ID: <8be5b5ea-e761-df77-d24d-81167f74a568@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 206256E2AA for ; Wed, 31 Oct 2018 11:51:43 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTAvMzAvMjAxOCA1OjI2IFBNLCBKYW5pIE5pa3VsYSB3cm90ZToKPiBUaGlzIHBhdGNoIGFk ZHMgRFNJIHBhY2tldCBwYXlsb2FkIHRvIGNvbW1hbmQgcGF5bG9hZAo+IHF1ZXVlIHVzaW5nIGNy ZWRpdCBiYXNlZCBtZWNoYW5pc20gZm9yICpsb25nKiBwYWNrZXRzLgo+Cj4gdjIgYnkgSmFuaToK PiAgIC0gQWRkIGludGVsX2RzaSBsb2NhbCB2YXJpYWJsZSBmb3IgYmV0dGVyIGNvZGUgZmxvdwo+ ICAgLSBVc2UgdGhlIG5ldyBjcmVkaXQgYXZhaWxhYmxlIGhlbHBlcgo+ICAgLSBVc2UgaW50IGZv ciBmcmVlX2NyZWRpdHMsIGksIGFuZCBqCgp2MiBjaGFuZ2VzIGFyZSBmaW5lLgoKUmVnYXJkcywK TWFkaGF2Cgo+Cj4gU2lnbmVkLW9mZi1ieTogTWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1aGFu QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50 ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2RzaS5jIHwgNTcgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gICAxIGZpbGUgY2hhbmdl ZCwgNTcgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ljbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ljbF9kc2kuYwo+IGluZGV4IGM3Yjc3 Y2Q4MWU0NS4uNTg3NzRhMWFjODRiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ljbF9kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ljbF9kc2kuYwo+IEBAIC0x MDcsNiArMTA3LDMzIEBAIHN0YXRpYyB2b2lkIHdhaXRfZm9yX2NtZHNfZGlzcGF0Y2hlZF90b19w YW5lbChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgIAl9Cj4gICB9Cj4gICAKPiAr c3RhdGljIGJvb2wgYWRkX3BheWxkX3RvX3F1ZXVlKHN0cnVjdCBpbnRlbF9kc2lfaG9zdCAqaG9z dCwgY29uc3QgdTggKmRhdGEsCj4gKwkJCSAgICAgICB1MzIgbGVuKQo+ICt7Cj4gKwlzdHJ1Y3Qg aW50ZWxfZHNpICppbnRlbF9kc2kgPSBob3N0LT5pbnRlbF9kc2k7Cj4gKwlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGludGVsX2RzaS0+YmFzZS5iYXNlLmRldik7 Cj4gKwllbnVtIHRyYW5zY29kZXIgZHNpX3RyYW5zID0gZHNpX3BvcnRfdG9fdHJhbnNjb2Rlciho b3N0LT5wb3J0KTsKPiArCWludCBmcmVlX2NyZWRpdHM7Cj4gKwlpbnQgaSwgajsKPiArCj4gKwlm b3IgKGkgPSAwOyBpIDwgbGVuOyBpICs9IDQpIHsKPiArCQl1MzIgdG1wID0gMDsKPiArCj4gKwkJ ZnJlZV9jcmVkaXRzID0gcGF5bG9hZF9jcmVkaXRzX2F2YWlsYWJsZShkZXZfcHJpdiwgZHNpX3Ry YW5zKTsKPiArCQlpZiAoZnJlZV9jcmVkaXRzIDwgMSkgewo+ICsJCQlEUk1fRVJST1IoIlBheWxv YWQgY3JlZGl0IG5vdCBhdmFpbGFibGVcbiIpOwo+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gKwkJfQo+ ICsKPiArCQlmb3IgKGogPSAwOyBqIDwgbWluX3QodTMyLCBsZW4gLSBpLCA0KTsgaisrKQo+ICsJ CQl0bXAgfD0gKmRhdGErKyA8PCA4ICogajsKPiArCj4gKwkJSTkxNV9XUklURShEU0lfQ01EX1RY UFlMRChkc2lfdHJhbnMpLCB0bXApOwo+ICsJfQo+ICsKPiArCXJldHVybiB0cnVlOwo+ICt9Cj4g Kwo+ICAgc3RhdGljIGludCBkc2lfc2VuZF9wa3RfaGRyKHN0cnVjdCBpbnRlbF9kc2lfaG9zdCAq aG9zdCwKPiAgIAkJCSAgICBzdHJ1Y3QgbWlwaV9kc2lfcGFja2V0IHBrdCwgYm9vbCBlbmFibGVf bHBkdCkKPiAgIHsKPiBAQCAtMTQ1LDYgKzE3MiwyNSBAQCBzdGF0aWMgaW50IGRzaV9zZW5kX3Br dF9oZHIoc3RydWN0IGludGVsX2RzaV9ob3N0ICpob3N0LAo+ICAgCXJldHVybiAwOwo+ICAgfQo+ ICAgCj4gK3N0YXRpYyBpbnQgZHNpX3NlbmRfcGt0X3BheWxkKHN0cnVjdCBpbnRlbF9kc2lfaG9z dCAqaG9zdCwKPiArCQkJICAgICAgc3RydWN0IG1pcGlfZHNpX3BhY2tldCBwa3QpCj4gK3sKPiAr CS8qIHBheWxvYWQgcXVldWUgY2FuIGFjY2VwdCAqMjU2IGJ5dGVzKiwgY2hlY2sgbGltaXQgKi8K PiArCWlmIChwa3QucGF5bG9hZF9sZW5ndGggPiBNQVhfUExPQURfQ1JFRElUICogNCkgewo+ICsJ CURSTV9FUlJPUigicGF5bG9hZCBzaXplIGV4Y2VlZHMgbWF4IHF1ZXVlIGxpbWl0XG4iKTsKPiAr CQlyZXR1cm4gLTE7Cj4gKwl9Cj4gKwo+ICsJLyogbG9hZCBkYXRhIGludG8gY29tbWFuZCBwYXls b2FkIHF1ZXVlICovCj4gKwlpZiAoIWFkZF9wYXlsZF90b19xdWV1ZShob3N0LCBwa3QucGF5bG9h ZCwKPiArCQkJCXBrdC5wYXlsb2FkX2xlbmd0aCkpIHsKPiArCQlEUk1fRVJST1IoImFkZGluZyBw YXlsb2FkIHRvIHF1ZXVlIGZhaWxlZFxuIik7Cj4gKwkJcmV0dXJuIC0xOwo+ICsJfQo+ICsKPiAr CXJldHVybiAwOwo+ICt9Cj4gKwo+ICAgc3RhdGljIHZvaWQgZHNpX3Byb2dyYW1fc3dpbmdfYW5k X2RlZW1waGFzaXMoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gICB7Cj4gICAJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5iYXNlLmRl dik7Cj4gQEAgLTEwNTIsNiArMTA5OCwxNyBAQCBzdGF0aWMgc3NpemVfdCBnZW4xMV9kc2lfaG9z dF90cmFuc2ZlcihzdHJ1Y3QgbWlwaV9kc2lfaG9zdCAqaG9zdCwKPiAgIAlpZiAocmV0IDwgMCkK PiAgIAkJcmV0dXJuIHJldDsKPiAgIAo+ICsJLyogb25seSBsb25nIHBhY2tldCBjb250YWlucyBw YXlsb2FkICovCj4gKwlpZiAobWlwaV9kc2lfcGFja2V0X2Zvcm1hdF9pc19sb25nKG1zZy0+dHlw ZSkpIHsKPiArCQlyZXQgPSBkc2lfc2VuZF9wa3RfcGF5bGQoaW50ZWxfZHNpX2hvc3QsIGRzaV9w a3QpOwo+ICsJCWlmIChyZXQgPCAwKQo+ICsJCQlyZXR1cm4gcmV0Owo+ICsJfQo+ICsKPiArCS8v VE9ETzogYWRkIHBheWxvYWQgcmVjZWl2ZSBjb2RlIGlmIG5lZWRlZAo+ICsKPiArCXJldCA9IHNp emVvZihkc2lfcGt0LmhlYWRlcikgKyBkc2lfcGt0LnBheWxvYWRfbGVuZ3RoOwo+ICsKPiAgIAly ZXR1cm4gcmV0Owo+ICAgfQo+ICAgCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK