From: Maarten Lankhorst Subject: Re: [PATCH 2/3] drm/i915: Wait for pending modesets to complete before trying link training Date: Thu, 9 Feb 2017 12:27:12 +0100 Message-ID: <8bfdef6d-0971-25d9-67ab-720103d8ad72@linux.intel.com> References: <1483981618-10233-1-git-send-email-maarten.lankhorst@linux.intel.com> <1483981618-10233-3-git-send-email-maarten.lankhorst@linux.intel.com> <20170126183158.GM31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170126183158.GM31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMjYtMDEtMTcgb20gMTk6MzEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gTW9uLCBK YW4gMDksIDIwMTcgYXQgMDY6MDY6NTdQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IFdlJ3JlIHByb3RlY3RlZCBieSB0aGUgY29ubmVjdGlvbl9tdXRleCBsb2NrIGFnYWluc3Qg YmxvY2tpbmcgbW9kZXNldHMsCj4+IGJ1dCBub25ibG9ja2luZyBtb2Rlc2V0cyBhcmUgcGVyZm9y bWVkIHdpdGhvdXQgYW55IGxvY2tpbmcuIFRoaXMgaXMKPj4gY2F1c2luZyBXQVJOIGluIGRybV93 YWl0X2Zvcl92YmxhbmsgYW5kIGluIGdlbmVyYWwgaXQncyBiZXR0ZXIgdG8gd2FpdAo+PiBiZWZv cmUgbW9kZXNldCBjb21wbGV0ZXMgYmVmb3JlIHRyeWluZyBhbnl0aGluZy4KPj4KPj4gU2lnbmVk LW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVs LmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNTEgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2Vk LCAzOSBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jCj4+IGluZGV4IGZiMTI4OTZiYWZlZS4uNzE4ODJkODg3MzkzIDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMKPj4gQEAgLTQwODAsMjQgKzQwODAsMzggQEAgaW50ZWxfZHBfY2hl Y2tfbGlua19zdGF0dXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPj4gIAlzdHJ1Y3QgaW50 ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlciA9ICZkcF90b19kaWdfcG9ydChpbnRlbF9kcCktPmJh c2U7Cj4+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RwX3RvX2RldihpbnRlbF9k cCk7Cj4+ICAJdTggbGlua19zdGF0dXNbRFBfTElOS19TVEFUVVNfU0laRV07Cj4+ICsJc3RydWN0 IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4IGN0eDsKPj4gKwlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9y ICppbnRlbF9jb25uZWN0b3IgPSBpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yOwo+PiArCWlu dCByZXQ7Cj4+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+PiAgCj4+IC0JV0FSTl9PTighZHJt X21vZGVzZXRfaXNfbG9ja2VkKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpKTsK Pj4gKwlkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4+ICsKPj4gK3JldHJ5Ogo+ PiArCXJldCA9IGRybV9tb2Rlc2V0X2xvY2soJmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9t dXRleCwgJmN0eCk7Cj4+ICsJaWYgKHJldCkKPj4gKwkJZ290byBvdXQ7Cj4+ICAKPj4gIAlpZiAo IWludGVsX2RwX2dldF9saW5rX3N0YXR1cyhpbnRlbF9kcCwgbGlua19zdGF0dXMpKSB7Cj4+ICAJ CURSTV9FUlJPUigiRmFpbGVkIHRvIGdldCBsaW5rIHN0YXR1c1xuIik7Cj4+IC0JCXJldHVybjsK Pj4gKwkJZ290byBvdXQ7Cj4+ICAJfQo+PiAgCj4+IC0JaWYgKCFpbnRlbF9lbmNvZGVyLT5iYXNl LmNydGMpCj4+IC0JCXJldHVybjsKPj4gKwljcnRjID0gaW50ZWxfY29ubmVjdG9yLT5iYXNlLnN0 YXRlLT5jcnRjOwo+PiArCWlmICghY3J0YykKPj4gKwkJZ290byBvdXQ7Cj4+ICAKPj4gLQlpZiAo IXRvX2ludGVsX2NydGMoaW50ZWxfZW5jb2Rlci0+YmFzZS5jcnRjKS0+YWN0aXZlKQo+PiAtCQly ZXR1cm47Cj4+ICsJcmV0ID0gZHJtX21vZGVzZXRfbG9jaygmY3J0Yy0+bXV0ZXgsICZjdHgpOwo+ PiArCWlmIChyZXQpCj4+ICsJCWdvdG8gb3V0Owo+PiArCj4+ICsJaWYgKCFjcnRjLT5zdGF0ZS0+ YWN0aXZlKQo+PiArCQlnb3RvIG91dDsKPj4gIAo+PiAgCS8qIEZJWE1FOiB3ZSBuZWVkIHRvIHN5 bmNocm9uaXplIHRoaXMgc29ydCBvZiBzdHVmZiB3aXRoIGhhcmR3YXJlCj4+ICAJICogcmVhZG91 dC4gQ3VycmVudGx5IGZhc3QgbGluayB0cmFpbmluZyBkb2Vzbid0IHdvcmsgb24gYm9vdC11cC4g Ki8KPj4gIAlpZiAoIWludGVsX2RwLT5sYW5lX2NvdW50KQo+PiAtCQlyZXR1cm47Cj4+ICsJCWdv dG8gb3V0Owo+PiAgCj4+ICAJLyogaWYgbGluayB0cmFpbmluZyBpcyByZXF1ZXN0ZWQgd2Ugc2hv dWxkIHBlcmZvcm0gaXQgYWx3YXlzICovCj4+ICAJaWYgKChpbnRlbF9kcC0+Y29tcGxpYW5jZS50 ZXN0X3R5cGUgPT0gRFBfVEVTVF9MSU5LX1RSQUlOSU5HKSB8fAo+PiBAQCAtNDEwNSw4ICs0MTE5 LDI2IEBAIGludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf ZHApCj4+ICAJCURSTV9ERUJVR19LTVMoIiVzOiBjaGFubmVsIEVRIG5vdCBvaywgcmV0cmFpbmlu Z1xuIiwKPj4gIAkJCSAgICAgIGludGVsX2VuY29kZXItPmJhc2UubmFtZSk7Cj4+ICAKPj4gKwkJ aWYgKGRybV9hdG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KGNydGMtPnN0YXRlKSkgewo+PiArCQkJ Lyogd2FpdCBmb3IgYXRvbWljIG1vZGVzZXQgdG8gY29tcGxldGUgKi8KPj4gKwkJCXJldCA9IGRy bV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2h3X2RvbmUoY3J0Yyk7Cj4+ICsJCQlpZiAocmV0IDwg MCkKPj4gKwkJCQlEUk1fRVJST1IoIldhaXRpbmcgZm9yIGh3X2RvbmUgdGltZWQgb3V0XG4iKTsK PiBJIHdvbmRlciBpZiB3ZSBzaG91bGQganVzdCBza2lwIHRoZSBodyBmcm9iYmluZyBpbiB0aGlz IGNhc2UuIEkgZ3Vlc3MgaXQKPiBtaWdodCBzdGlsbCByZXN0b3JlIHRoZSBsaW5rIGlmIHRoZSBj b21taXQganVzdCBzb21laG93IGdvdCBzdHVjawo+IHNvbWV3aGVyZSBub24tY3JpdGljYWwuCkht LCAgd2UgY291bGQgY2hlY2sgaWYgdGhlIGxpbmsgdHJhaW5pbmcgaXMgc3RpbGwgcmVxdWlyZWQg YWZ0ZXIgdGhlIHdhaXQuCk1heWJlIGV2ZW4gZG8gdGhlIHdhaXQgdW5sb2NrZWQsIHNpbmNlIGl0 IG1pZ2h0IHRha2UgYW4gYXJiaXRyYXJ5IGFtb3VudCBvZiB0aW1lCmFuZCB0aGVuIHJldHJ5Pwo+ PiArCQl9Cj4+ICsKPj4gIAkJaW50ZWxfZHBfcmV0cmFpbl9saW5rKGludGVsX2RwKTsKPj4gIAl9 Cj4+ICsKPj4gK291dDoKPj4gKwlpZiAocmV0ID09IC1FREVBRExLKSB7Cj4+ICsJCWRybV9tb2Rl c2V0X2JhY2tvZmYoJmN0eCk7Cj4+ICsJCWdvdG8gcmV0cnk7Cj4+ICsJfQo+PiArCj4+ICsJZHJt X21vZGVzZXRfZHJvcF9sb2NrcygmY3R4KTsKPj4gKwlkcm1fbW9kZXNldF9hY3F1aXJlX2Zpbmko JmN0eCk7Cj4+ICsJaWYgKHJldCkKPj4gKwkJRFJNX0VSUk9SKCJMb2NraW5nIGZhaWxlZCB3aXRo ICVpXG4iLCByZXQpOwo+IFRoaXMgc2VlbXMgaW5jb3JyZWN0IGlmIHdlIHRpbWVkIG91dCBvbiB0 aGUgd2FpdC4gTWF5YmUganVzdAo+IGNsZWFyIHJldCBhZnRlciB0aGUgaHdfZG9uZSB3YWl0Pwo+ Cj4+ICB9Cj4+ICAKPj4gIC8qCj4+IEBAIC00MTI1LDcgKzQxNTcsNiBAQCBpbnRlbF9kcF9jaGVj a19saW5rX3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+PiAgc3RhdGljIGJvb2wK Pj4gIGludGVsX2RwX3Nob3J0X3B1bHNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4+ICB7 Cj4+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RwX3RvX2RldihpbnRlbF9kcCk7 Cj4+ICAJdTggc2lua19pcnFfdmVjdG9yID0gMDsKPj4gIAl1OCBvbGRfc2lua19jb3VudCA9IGlu dGVsX2RwLT5zaW5rX2NvdW50Owo+PiAgCWJvb2wgcmV0Owo+PiBAQCAtNDE2NCw5ICs0MTk1LDcg QEAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPj4gIAkJ CURSTV9ERUJVR19EUklWRVIoIkNQIG9yIHNpbmsgc3BlY2lmaWMgaXJxIHVuaGFuZGxlZFxuIik7 Cj4+ICAJfQo+PiAgCj4+IC0JZHJtX21vZGVzZXRfbG9jaygmZGV2LT5tb2RlX2NvbmZpZy5jb25u ZWN0aW9uX211dGV4LCBOVUxMKTsKPj4gIAlpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhpbnRl bF9kcCk7Cj4+IC0JZHJtX21vZGVzZXRfdW5sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rp b25fbXV0ZXgpOwo+PiAgCj4+ICAJcmV0dXJuIHRydWU7Cj4+ICB9Cj4+IEBAIC00NDk5LDkgKzQ1 MjgsNyBAQCBpbnRlbF9kcF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmludGVs X2Nvbm5lY3RvcikKPj4gIAkJICogY2hlY2sgbGlua3Mgc3RhdHVzLCB0aGVyZSBoYXMgYmVlbiBr bm93biBpc3N1ZXMgb2YKPj4gIAkJICogbGluayBsb3NzIHRyaWdnZXJyaW5nIGxvbmcgcHVsc2Uh ISEhCj4+ICAJCSAqLwo+PiAtCQlkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNv bm5lY3Rpb25fbXV0ZXgsIE5VTEwpOwo+PiAgCQlpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhp bnRlbF9kcCk7Cj4+IC0JCWRybV9tb2Rlc2V0X3VubG9jaygmZGV2LT5tb2RlX2NvbmZpZy5jb25u ZWN0aW9uX211dGV4KTsKPj4gIAkJZ290byBvdXQ7Cj4+ICAJfQo+PiAgCj4+IC0tIAo+PiAyLjcu NAo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK