From: "ordex (Code Review)" Date: Fri, 25 Jul 2025 23:51:02 +0000 References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <8cb692211253898a82e58e579914ce0457d24797-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="z2qB25MTQh4="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: multi: make multi_process_float() static List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --z2qB25MTQh4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1115?usp=3Demail to review the following change. Change subject: multi: make multi_process_float() static ...................................................................... multi: make multi_process_float() static multi_process_float() is invoked only within multi.c, which is where it is defined. For this reason we can make it static and drop its declaration in multi.h. Change-Id: Id5e06f0822a3e7e4ad1b6f93caaefdb6a8cfe547 Signed-off-by: Antonio Quartulli --- M src/openvpn/multi.c M src/openvpn/multi.h 2 files changed, 9 insertions(+), 12 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/15/1115/1 diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index c5691ff..d23aee7 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3210,7 +3210,15 @@ return ret; } -void +/** + * Handles peer floating. + * + * If peer is floated to a taken address, either drops packet + * (if peer that owns address has different CN) or disconnects + * existing peer. Updates multi_instance with new address, + * updates hashtables in multi_context. + */ +static void multi_process_float(struct multi_context *m, struct multi_instance *mi, struct link_socket *sock) { diff --git a/src/openvpn/multi.h b/src/openvpn/multi.h index 8b2704c..eb5bf86 100644 --- a/src/openvpn/multi.h +++ b/src/openvpn/multi.h @@ -270,17 +270,6 @@ bool multi_process_timeout(struct multi_context *m, const unsigned int mpp= _flags); -/** - * Handles peer floating. - * - * If peer is floated to a taken address, either drops packet - * (if peer that owns address has different CN) or disconnects - * existing peer. Updates multi_instance with new address, - * updates hashtables in multi_context. - */ -void multi_process_float(struct multi_context *m, struct multi_instance *m= i, - struct link_socket *sock); - #define MPP_PRE_SELECT (1<<0) #define MPP_CONDITIONAL_PRE_SELECT (1<<1) #define MPP_CLOSE_ON_SIGNAL (1<<2) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1115?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id5e06f0822a3e7e4ad1b6f93caaefdb6a8cfe547 Gerrit-Change-Number: 1115 Gerrit-PatchSet: 1 Gerrit-Owner: ordex Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --z2qB25MTQh4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

ordex would like plaisthos and flichtenheld to review t= his change.

V= iew Change

multi: make multi_process_float() static

multi_proces= s_float() is invoked only within multi.c, which
is where it is defined.<= br>
For this reason we can make it static and drop its declaration
in= multi.h.

Change-Id: Id5e06f0822a3e7e4ad1b6f93caaefdb6a8cfe547
Si= gned-off-by: Antonio Quartulli <antonio@...2726...>
---
M src/o= penvpn/multi.c
M src/openvpn/multi.h
2 files changed, 9 insertions(+)= , 12 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn=
 refs/changes/15/1115/1
diff --git a/src/openvpn/multi.c b/src/open=
vpn/multi.c
index c5691ff..d23aee7 100644
-= -- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c@@ -3210,7 +3210,15 @@
return ret;
<= span> }

-void
+/**<= br>+ * Handles peer floating.
+ *
+ * If peer is floated to a taken addre= ss, either drops packet
+ * (if peer that owns address has different CN) or disconnects+ * existing peer. Updates mu= lti_instance with new address,
+ * updates hashtables in multi_context.
+ */
+static void
multi_process_float(struct mult= i_context *m, struct multi_instance *mi,
= struct link_socket *sock)
{
diff --git = a/src/openvpn/multi.h b/src/openvpn/multi.h
index 8b2704c..= eb5bf86 100644
--- a/src/openvpn/multi.h
++= + b/src/openvpn/multi.h
@@ -270,17 +270,6 @@

bool multi_process_timeout(struct multi_context *m, co= nst unsigned int mpp_flags);

-/**
- * Handles peer floating.
- *
- * If pe= er is floated to a taken address, either drops packet
- * (if peer that owns address has different= CN) or disconnects
- *= existing peer. Updates multi_instance with new address,
- * updates hashtables in multi_context.<= /span>
- */
-void multi_process_float(struct multi_co= ntext *m, struct multi_instance *mi,
- struct link_socket *sock);-
#define MPP_= PRE_SELECT (1<<0)
#define MPP_CONDITIONA= L_PRE_SELECT (1<<1)
#define MPP_CLOSE_ON_SIGNAL = (1<<2)

To view, visit change 1115= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id5e06f0822a3e7e4ad1b6f93caa= efdb6a8cfe547
Gerrit-Change-Number: 1115
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <antonio@...2726...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--z2qB25MTQh4=--