Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0D13D2FA for ; Wed, 19 Apr 2023 21:42:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52E68C433EF; Wed, 19 Apr 2023 21:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681940524; bh=/UYmwUwYQs7440o2kiPbrEuQwRSg8GJBGRE90WwDB9M=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=uL3eRnSQg/lrtNtoVEQVVC135yFOWOzmNXiD60SqEq5gRYyecug+a+aA0loWTs/yH HhuKX1Lwm9kw429oUVNtNliwdJ/xu7BjeNB5mg/n5CBFpJxjdU/wU0zEH1cmJMBmTl 1KvP53ZqIxUexnUdPCbG5jF0hbv9sZWvZA30FAry1j9Bm/XMcFVIBcWHsJhY0KQHsI CgNs55CPcdaX3kSXSH+69R8dJv+/SiTPVdzDZ0CppL1dXKBIMlW19tf8CEa/Xo4T6c /H7niEZ/zV8mwGHWZSkOQdgzzB85ctJTUk7e20zb1FXm/j15KiFRA0eV3p+h22j+j2 iu7Iu6ZYpZICg== Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 2FE6D27C0054; Wed, 19 Apr 2023 17:42:03 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 19 Apr 2023 17:42:03 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtuddgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugeskhgvrhhnvghlrdhorhhgqeenucggtf frrghtthgvrhhnpedvtddtffejfeeggefgleefgfeghfehfeefffetgffgleegudevveet hfefjeevkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrrhhnugdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidquddvkeehudej tddvgedqvdekjedttddvieegqdgrrhhnugeppehkvghrnhgvlhdrohhrghesrghrnhgusg druggv X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E837CB60089; Wed, 19 Apr 2023 17:42:02 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Message-Id: <8d070a27-fa53-4965-95b0-e0bf8bb90609@app.fastmail.com> In-Reply-To: References: <20230418-vchiq_platform_init-static-v1-1-3c38ba81bc66@kernel.org> <20ac24d6-4d94-4003-9203-d852714e1a46@app.fastmail.com> Date: Wed, 19 Apr 2023 23:41:42 +0200 From: "Arnd Bergmann" To: "Nick Desaulniers" Cc: "Simon Horman" , "Stefan Wahren" , "Broadcom internal kernel review list" , "Nathan Chancellor" , "Tom Rix" , "Greg Kroah-Hartman" , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, llvm@lists.linux.dev, "Florian Fainelli" Subject: Re: [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Apr 19, 2023, at 23:38, Nick Desaulniers wrote: > On Wed, Apr 19, 2023 at 2:35=E2=80=AFPM Arnd Bergmann wrote: >> >> On Wed, Apr 19, 2023, at 23:21, Nick Desaulniers wrote: >> > On Wed, Apr 19, 2023 at 1:51=E2=80=AFAM Simon Horman wrote: >> >> > Marking something as `depends on OF_DYNAMIC`. (Not sure whether Arnd >> > meant that for BCM2835_VCHIQ or BCM_VIDEOCORE). >> > Perhaps try that? >> > >> >> >> >> I'm a bit surprised as I didn't observe such a thing. >> >> But I also don't dispute it - clearly my testing was inadequate. >> >> >> >> I'll try and dig a bit deeper into this one. >> >> Perhaps starting with the report from the kernel test robot [3] >> >> I have this in my randconfig build tree, but it looks like I never >> sent it out. > > What else have you got hidden up in there? ;) > Reviewed-by: Nick Desaulniers Actually, I have fixes for all missing-prototype warnings in my tree, just remembered that this one is part of my longer series. I have about 150 patches that are already split up and just need to be sent out, plus more that are currently sitting in a combined changeset. Arnd