Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE64AC05052 for ; Fri, 18 Aug 2023 09:16:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aTiLURHx+gwfbOeCyKl8voT36eMkkJfs64dUpvfmJkE=; b=P9onHk/OPTnqhe +Jd9XKcE43eaQ+jTINcT6y/BJWPyc5gdyEACap+GbFa+FTkPgYx3KHogPpPmnIie/kMskRuVF1IAL SzApm1mlOes05nAefVkyC8wcGy7xw3IeCXPNM73Ux2Vwpk5RzgNJzijGgKW+3dmgQ/S8yZH6V3lfB 5UpNep4gIFlDWqHnKzqw+0PMVJVC7XY/i2hhZkenDGce7iKzIIMy7d3qrhXLOH+mGJDOaxjY/OS9J OC7vSGv0LkMU4MYwEY15L+MhwvL1miiYWFN30E9HcHOuLiPFaFI4wuzyfI4dQe5WDzbG/MQV6n6um EIzYs6VnXc8r2tYxwuBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWvaG-0084a9-0t; Fri, 18 Aug 2023 09:15:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWvaD-0084Zc-0V for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 09:15:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17525D75; Fri, 18 Aug 2023 02:16:31 -0700 (PDT) Received: from [10.57.4.78] (unknown [10.57.4.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 220003F762; Fri, 18 Aug 2023 02:15:49 -0700 (PDT) Message-ID: <8d2641a4-8237-9977-fd73-01a3cea42179@arm.com> Date: Fri, 18 Aug 2023 10:15:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/2] coresight: core: fix memory leak in dict->fwnode_list To: James Clark , Junhao He , mike.leach@linaro.org, leo.yan@linaro.org Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, jonathan.cameron@huawei.com, yangyicong@huawei.com, prime.zeng@hisilicon.com References: <20230817085937.55590-1-hejunhao3@huawei.com> <20230817085937.55590-3-hejunhao3@huawei.com> <16d7c933-ef2f-682e-742e-641c6a076ac0@arm.com> <87107f44-b760-5df4-6bcf-8482069a603a@arm.com> From: Suzuki K Poulose In-Reply-To: <87107f44-b760-5df4-6bcf-8482069a603a@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_021553_316385_DF5AE402 X-CRM114-Status: GOOD ( 27.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTcvMDgvMjAyMyAxNjowMSwgSmFtZXMgQ2xhcmsgd3JvdGU6Cj4gCj4gCj4gT24gMTcvMDgv MjAyMyAxNTo0NywgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPj4gT24gMTcvMDgvMjAyMyAxNToz OSwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPj4+IE9uIDE3LzA4LzIwMjMgMDk6NTksIEp1bmhh byBIZSB3cm90ZToKPj4+PiBUaGVyZSBhcmUgbWVtb3J5IGxlYWtzIHJlcG9ydGVkIGJ5IGttZW1s ZWFrOgo+Pj4+IC4uLgo+Pj4+IHVucmVmZXJlbmNlZCBvYmplY3QgMHhmZmZmMjAyMDEwM2MzMjAw IChzaXplIDI1Nik6Cj4+Pj4gIMKgwqAgY29tbSAiaW5zbW9kIiwgcGlkIDQ0NzYsIGppZmZpZXMg NDI5NDk3ODI1MiAoYWdlIDUwMDcyLjUzNnMpCj4+Pj4gIMKgwqAgaGV4IGR1bXAgKGZpcnN0IDMy IGJ5dGVzKToKPj4+PiAgwqDCoMKgwqAgMTAgNjAgNDAgMDYgMjggMjAgZmYgZmYgMTAgYzAgNTkg MDYgMjAgMjAgZmYgZmbCoCAuYEAuKCAuLi4uWS7CoCAuLgo+Pj4+ICDCoMKgwqDCoCAxMCBlMCA0 NyAwNiAyOCAyMCBmZiBmZiAxMCAwMCA0OSAwNiAyOCAyMCBmZiBmZsKgIC4uRy4oIC4uLi5JLigg Li4KPj4+PiAgwqDCoCBiYWNrdHJhY2U6Cj4+Pj4gIMKgwqDCoMKgIFs8MDAwMDAwMDAzNGVjNDcy ND5dIF9fa21lbV9jYWNoZV9hbGxvY19ub2RlKzB4MmY4LzB4MzQ4Cj4+Pj4gIMKgwqDCoMKgIFs8 MDAwMDAwMDA1N2ZiYzE1ZD5dIF9fa21hbGxvY19ub2RlX3RyYWNrX2NhbGxlcisweDVjLzB4MTEw Cj4+Pj4gIMKgwqDCoMKgIFs8MDAwMDAwNTVkNWUzNGI+XSBrcmVhbGxvYysweDhjLzB4MTc4Cj4+ Pj4gIMKgwqDCoMKgIFs8MDAwMDAwMDBhNDYzNWJlYj5dIGNvcmVzaWdodF9hbGxvY19kZXZpY2Vf bmFtZSsweDEyOC8weDE4OAo+Pj4+IFtjb3Jlc2lnaHRdCj4+Pj4gIMKgwqDCoMKgIFs8MDAwMDAw MDBhOTJkZGZlZT5dIGZ1bm5lbF9jc19vcHMrMHgxMC8weGZmZmZmZmZmZmZmZWRhYTAKPj4+PiBb Y29yZXNpZ2h0X2Z1bm5lbF0KPj4+PiAgwqDCoMKgwqAgWzwwMDAwMDAwMDQ0OWUyMGY4Pl0gZHlu YW1pY19mdW5uZWxfaWRzKzB4ODAvMHhmZmZmZmZmZmZmZmVkODQwCj4+Pj4gW2NvcmVzaWdodF9m dW5uZWxdCj4+Pj4gLi4uCj4+Pj4KPj4+PiB3aGVuIHJlbW92ZSBkcml2ZXIsIHRoZSBnb2xhYiB2 YXJpYWJsZXMgZGVmaW5lZCBieSB0aGUgbWFjcm8KPj4+PiBERUZJTkVfQ09SRVNJR0hUX0RFVkxJ U1Qgd2lsbCBiZSByZWxlYXNlZCwgZGljdC0+bnJfaWR4IGFuZAo+Pj4+IGRpY3QtPmZ3bm9kZV9s aXN0IGFyZSBjbGVhcmVkIHRvIDAuIFRoZSBsaWZldGltZSBvZiB0aGUgZ29sYWIKPj4+PiB2YXJp YWJsZSBoYXMgZW5kZWQuIFNvIHRoZSBidWZmZXIgcG9pbnRlciBpcyBsb3N0Lgo+Pj4+Cj4+Pj4g VXNlIHRoZSBjYWxsYmFjayBvZiBkZXZtX2FkZF9hY3Rpb25fb3JfcmVzZXQoKSB0byBmcmVlIG1l bW9yeS4KPj4+Cj4+PiBUaGFua3MgZm9yIHRoZSByZXBvcnQuIEJ1dCBwbGVhc2Ugc2VlIGJlbG93 Ogo+Pj4KPj4+Pgo+Pj4+IEZpeGVzOiAwZjVmOWI2YmE5ZTEgKCJjb3Jlc2lnaHQ6IFVzZSBwbGF0 Zm9ybSBhZ25vc3RpYyBuYW1lcyIpCj4+Pj4gU2lnbmVkLW9mZi1ieTogSnVuaGFvIEhlIDxoZWp1 bmhhbzNAaHVhd2VpLmNvbT4KPj4+PiAtLS0KPj4+PiAgwqAgZHJpdmVycy9od3RyYWNpbmcvY29y ZXNpZ2h0L2NvcmVzaWdodC1jb3JlLmMgfCAyMCArKysrKysrKysrKysrKysrKysrLQo+Pj4+ICDC oCAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pj4+Cj4+ Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtY29y ZS5jCj4+Pj4gYi9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LWNvcmUuYwo+ Pj4+IGluZGV4IDlmYWJlMDBhNDBkNi4uNjg0OWZhYWQ2OTdkIDEwMDY0NAo+Pj4+IC0tLSBhL2Ry aXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtY29yZS5jCj4+Pj4gKysrIGIvZHJp dmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdodC1jb3JlLmMKPj4+PiBAQCAtMTc1Niw2 ICsxNzU2LDIwIEBAIGJvb2wgY29yZXNpZ2h0X2xvc2VzX2NvbnRleHRfd2l0aF9jcHUoc3RydWN0 Cj4+Pj4gZGV2aWNlICpkZXYpCj4+Pj4gIMKgIH0KPj4+PiAgwqAgRVhQT1JUX1NZTUJPTF9HUEwo Y29yZXNpZ2h0X2xvc2VzX2NvbnRleHRfd2l0aF9jcHUpOwo+Pj4+ICt2b2lkIGNvcmVzaWdodF9y ZWxlYXNlX2Rldl9saXN0KHZvaWQgKmRhdGEpCj4+Pj4gK3sKPj4+PiArwqDCoMKgIHN0cnVjdCBj b3Jlc2lnaHRfZGV2X2xpc3QgKmRpY3QgPSBkYXRhOwo+Pj4+ICsKPj4+PiArwqDCoMKgIG11dGV4 X2xvY2soJmNvcmVzaWdodF9tdXRleCk7Cj4+Pj4gKwo+Pj4+ICvCoMKgwqAgaWYgKGRpY3QtPm5y X2lkeCkgewo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBrZnJlZShkaWN0LT5md25vZGVfbGlzdCk7Cj4+ Pj4gK8KgwqDCoMKgwqDCoMKgIGRpY3QtPm5yX2lkeCA9IDA7Cj4+Pj4gK8KgwqDCoCB9Cj4+Pj4g Kwo+Pj4+ICvCoMKgwqAgbXV0ZXhfdW5sb2NrKCZjb3Jlc2lnaHRfbXV0ZXgpOwo+Pj4+ICt9Cj4+ Pj4gKwo+Pj4+ICDCoCAvKgo+Pj4+ICDCoMKgICogY29yZXNpZ2h0X2FsbG9jX2RldmljZV9uYW1l IC0gR2V0IGFuIGluZGV4IGZvciBhIGdpdmVuIGRldmljZSBpbgo+Pj4+IHRoZQo+Pj4+ICDCoMKg ICogZGV2aWNlIGluZGV4IGxpc3Qgc3BlY2lmaWMgdG8gYSBkcml2ZXIuIEFuIGluZGV4IGlzIGFs bG9jYXRlZCBmb3IgYQo+Pj4+IEBAIC0xNzY2LDEyICsxNzgwLDE2IEBACj4+Pj4gRVhQT1JUX1NZ TUJPTF9HUEwoY29yZXNpZ2h0X2xvc2VzX2NvbnRleHRfd2l0aF9jcHUpOwo+Pj4+ICDCoCBjaGFy ICpjb3Jlc2lnaHRfYWxsb2NfZGV2aWNlX25hbWUoc3RydWN0IGNvcmVzaWdodF9kZXZfbGlzdCAq ZGljdCwKPj4+PiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0 IGRldmljZSAqZGV2KQo+Pj4+ICDCoCB7Cj4+Pj4gLcKgwqDCoCBpbnQgaWR4Owo+Pj4+ICvCoMKg wqAgaW50IGlkeCwgcmV0Owo+Pj4+ICDCoMKgwqDCoMKgIGNoYXIgKm5hbWUgPSBOVUxMOwo+Pj4+ ICDCoMKgwqDCoMKgIHN0cnVjdCBmd25vZGVfaGFuZGxlICoqbGlzdDsKPj4+PiAgwqDCoMKgwqDC oCBtdXRleF9sb2NrKCZjb3Jlc2lnaHRfbXV0ZXgpOwo+Pj4+ICvCoMKgwqAgcmV0ID0gZGV2bV9h ZGRfYWN0aW9uX29yX3Jlc2V0KGRldiwgY29yZXNpZ2h0X3JlbGVhc2VfZGV2X2xpc3QsCj4+Pj4g ZGljdCk7Cj4+Pj4gK8KgwqDCoCBpZiAocmV0KQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBnb3RvIGRv bmU7Cj4+Pgo+Pj4gVGhpcyBsb29rcyB3cm9uZy4gVGhlIGRldmxpc3Qgc2hvdWxkIGJlIG9ubHkg cmVsZWFzZWQgb24gdGhlICJkcml2ZXIiCj4+PiB1bmxvYWQsIG5vdCBvbiBldmVyeSBkZXZpY2Ug cmVsZWFzZS4gVGhlIGxpc3QgcmV0YWlucyB0aGUgZndub2RlIHRvCj4+PiBhc3NpZ24gdGhlIHNh bWUgbmFtZSBmb3IgYSBkZXZpY2UsIGlmIGl0IGlzIHJlLXByb2JlZCAoZS5nLiwgZHVlIHRvCj4+ PiAtRVBST0JFX0RFRkVSIGVycm9yKS4KPj4KPj4gVGhlIGJlc3Qgd2F5IGlzIHRvIGZyZWUgaXQg b24gbW9kdWxlX3VubG9hZCBhbmQgdW5mb3J0dW5hdGVseSB3ZSB3b3VsZAo+PiBuZWVkIHRvIGRv IGl0IGZyb20gYWxsIG1vZHVsZXMgdXNpbmcgdGhlIERFVkxJU1QuCj4+Cj4+IFN1enVraQo+Pgo+ IAo+IFNlZW1zIGxpa2Ugd2UgbWlnaHQgYWxzbyBiZSBhYmxlIHRvIG1vdmUgdGhlIHNlcGFyYXRl IGxpc3RzIHRvIGJlIG9uZQo+IGJpZyBsaXN0IG93bmVkIGJ5IHRoZSBtYWluICdjb3Jlc2lnaHQn IG1vZHVsZS4gSWYgYWxsIHRoZSBvdGhlciBtb2R1bGVzCj4gYXJlIGRlcGVuZGVudCBvbiB0aGF0 IG9uZSB0aGVuIGl0J3MgYWx3YXlzIGxvYWRlZCBmaXJzdCBhbmQgdGhlIGxpc3QgaXMKPiBhdmFp bGFibGUuIFRoZW4gaXQgcGVyc2lzdHMgYXMgbG9uZyBhcyB0aGUgbWFpbiBtb2R1bGUgaXMgbG9h ZGVkIGFuZCBjYW4KPiBiZSBmcmVlZCB3aXRoIHRoZSBub3JtYWwgZGV2bSBzdHVmZi4KClRoYXQg bWF5IG5vdCB3b3JrLCByaWdodCA/IEZvciB0aGUgZGV2bSBzdHVmZiB0byB3b3JrLCB5b3UgbmVl ZCBhIApkZXZpY2UuIE1vdmluZyB0aGlzIHRvIHRoZSBjb3Jlc2lnaHQgbWFpbiBtb2R1bGUsIGRv ZXNuJ3QgZ2l2ZSB1cwoqYSBkZXZpY2UqIHdoZXJlIGFsbCB0aGVzZSBsaXN0cyBjYW4gYmUgYWxs b2NhdGVkIGZyb20uIEFsc28sIHdlCm5lZWQgYSBsaXN0IHBlciBkZXZpY2UgdHlwZSAoZS5nLiwg dG1jLWV0Zjw+LCB0bWMtZXRiPD4sIHRtYy1ldHI8Pgpmb3IgdG1jIGV0Yy4pLiBTbyB0aGVuIHRo ZSBpbmRpdmlkdWFsIGRyaXZlcnMgbmVlZCB0byB0aGVuIHJlZmVyCnRvIHRoZSBwYXJ0aWN1bGFy IChleHBvcnRlZCEpIGxpc3QgZm9yIGFsbG9jYXRpb25zLgoKPiAKPiBUaGF0IHdvdWxkIGF2b2lk IHRoZSBhd2t3YXJkIGNvbWJvIG9mIHRoZSBzdGF0aWMgdmFyaWFibGVzIGluIGVhY2gKPiBtb2R1 bGUgcGx1cyB0aGUgbm9uIGRldm0ga2FsbG9jZWQgbGlzdC4KCkkgdGhpbmsgaXQgaXMgbm90IHRv byBiYWQgdG8gYWRkIGEgY2xlYW51cCBjYWxsIHRvIHRoZSBjYWxsZXJzLCB3aG8gdXNlCmEgZGV2 bGlzdC4KClN1enVraQoKCgoKPiAKPj4KPj4+Cj4+PiBTdXp1a2kKPj4+Cj4+CgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=