From: Tvrtko Ursulin Subject: Re: [PATCH 5/5] drm/i915/guc: Simplify guc_fw_path Date: Fri, 16 Dec 2016 16:01:04 +0000 Message-ID: <8d6b3d99-d345-1792-94ed-1e23ef547858@linux.intel.com> References: <20161215154708.31521-1-arkadiusz.hiler@intel.com> <20161215154708.31521-6-arkadiusz.hiler@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FA196EC7C for ; Fri, 16 Dec 2016 16:01:07 +0000 (UTC) In-Reply-To: <20161215154708.31521-6-arkadiusz.hiler@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arkadiusz Hiler , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE1LzEyLzIwMTYgMTU6NDcsIEFya2FkaXVzeiBIaWxlciB3cm90ZToKPiBDdXJyZW50bHkg Z3VjX2Z3X3BhdGggdmFsdWVzIGNhbiByZXByZXNlbnQgb25lIG9mIHRocmVlIHBvc3NpYmxlIHN0 YXRlczoKPgo+ICAxKSBOVUxMIC0gZGV2aWNlIHdpdGhvdXQgR3VDCj4gIDIpICdcMCcgLSBkZXZp Y2Ugd2l0aCBHdUMgYnV0IG5vIGtub3duIGZpcm13YXJlCj4gIDMpIGVsc2UgLSBkZXZpY2Ugd2l0 aCBHdUMgYW5kIGtub3duIGZpcm13YXJlCj4KPiBTZWNvbmQgY2FzZSBpcyB1c2VkIG9ubHkgdG8g V0FSTiBhdCB0aGUgbGF0ZXIgc3RhZ2UuCj4KPiBXZSBjYW4gV0FSTiByaWdodCBhd2F5IGFuZCBt ZXJnZSBjYXNlcyAxIGFuZCAyIGZvciBsYXRlciBoYW5kbGluZy4KPgo+IENjOiBBbnVzaGEgU3Jp dmF0c2EgPGFudXNoYS5zcml2YXRzYUBpbnRlbC5jb20+Cj4gQ2M6IEplZmYgTWNHZWUgPGplZmYu bWNnZWVAaW50ZWwuY29tPgo+IENjOiBNaWNoYWwgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tp QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBcmthZGl1c3ogSGlsZXIgPGFya2FkaXVzei5o aWxlckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19s b2FkZXIuYyB8IDIyICsrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDcg aW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjX2xvYWRlci5jCj4gaW5kZXggMGJiNWZkMS4uMDc1YTEwMyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiBAQCAtNDYwLDEyICs0NjAsOCBAQCBpbnQg aW50ZWxfZ3VjX2xvYWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCWlu dGVsX2d1Y19md19zdGF0dXNfcmVwcihndWNfZnctPmd1Y19md19sb2FkX3N0YXR1cykpOwo+Cj4g IAlpZiAoZndfcGF0aCA9PSBOVUxMKSB7Cj4gLQkJLyogRGV2aWNlIGlzIGtub3duIHRvIGhhdmUg bm8gdUNvZGUgKGUuZy4gbm8gR3VDKSAqLwo+ICsJCS8qIFdlIGRvIG5vdCBoYXZlIHVDb2RlIGZv ciB0aGUgZGV2aWNlICovCj4gIAkJcmV0dXJuIC1FTlhJTzsKPiAtCX0gZWxzZSBpZiAoKmZ3X3Bh dGggPT0gJ1wwJykgewo+IC0JCS8qIERldmljZSBoYXMgYSBHdUMgYnV0IHdlIGRvbid0IGtub3cg d2hhdCBmL3cgdG8gbG9hZD8gKi8KPiAtCQlXQVJOKDEsICJObyBHdUMgZmlybXdhcmUga25vd24g Zm9yIHRoaXMgcGxhdGZvcm0hXG4iKTsKPiAtCQlyZXR1cm4gLUVOT0RFVjsKPiAgCX0KPgo+ICAJ LyogRmV0Y2ggZmFpbGVkLCBvciBhbHJlYWR5IGZldGNoZWQgYnV0IGZhaWxlZCB0byBsb2FkPyAq Lwo+IEBAIC02MjgsMTEgKzYyNCw5IEBAIHN0YXRpYyB2b2lkIGd1Y19md19mZXRjaChzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIHZvaWQgaW50ZWxfZ3VjX2luaXQoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZ3VjX2Z3 ICpndWNfZncgPSAmZGV2X3ByaXYtPmd1Yy5ndWNfZnc7Cj4gLQljb25zdCBjaGFyICpmd19wYXRo Owo+ICsJY29uc3QgY2hhciAqZndfcGF0aCA9IE5VTEw7Cj4KPiAtCWlmICghSEFTX0dVQ19VQ09E RShkZXZfcHJpdikpIHsKPiAtCQlmd19wYXRoID0gTlVMTDsKPiAtCX0gZWxzZSBpZiAoSVNfU0tZ TEFLRShkZXZfcHJpdikpIHsKPiArCWlmIChJU19TS1lMQUtFKGRldl9wcml2KSkgewo+ICAJCWZ3 X3BhdGggPSBJOTE1X1NLTF9HVUNfVUNPREU7Cj4gIAkJZ3VjX2Z3LT5ndWNfZndfbWFqb3Jfd2Fu dGVkID0gU0tMX0ZXX01BSk9SOwo+ICAJCWd1Y19mdy0+Z3VjX2Z3X21pbm9yX3dhbnRlZCA9IFNL TF9GV19NSU5PUjsKPiBAQCAtNjQ0LDI0ICs2MzgsMjIgQEAgdm9pZCBpbnRlbF9ndWNfaW5pdChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJZndfcGF0aCA9IEk5MTVfS0JM X0dVQ19VQ09ERTsKPiAgCQlndWNfZnctPmd1Y19md19tYWpvcl93YW50ZWQgPSBLQkxfRldfTUFK T1I7Cj4gIAkJZ3VjX2Z3LT5ndWNfZndfbWlub3Jfd2FudGVkID0gS0JMX0ZXX01JTk9SOwo+IC0J fSBlbHNlIHsKPiAtCQlmd19wYXRoID0gIiI7CS8qIHVua25vd24gZGV2aWNlICovCj4gKwl9IGVs c2UgaWYgKEhBU19HVUNfVUNPREUoZGV2X3ByaXYpKSB7Cj4gKwkJV0FSTigxLCAiTm8gR3VDIGZp cm13YXJlIGtub3duIGZvciBwbGF0Zm9ybSB3aXRoIEd1QyFcbiIpOwoKSSB0aGluayB5b3Ugc2hv dWxkIGFsc28gc2V0IGk5MTUuZW5hYmxlX2d1Y19sb2FkaW5nIHRvIHplcm8gaGVyZSB0byAKYXZv aWQgdGhlIGxhdGVyIHN0YWdlcyBib3RoZXJpbmcgd2l0aCBwYXJ0aWFsIHNldHVwIGFuZCBjbGVh bnVwLgoKaW50ZWxfdWNfbG9hZCBzcGVjaWZpY2FsbHkgSSB0aGluayB3b3VsZCB3aXRoIHRoaXMg cGF0Y2ggcnVuIHNvbWUgc2V0dXAgCnRoZW4gaW1tZWRpYXRlbHkgZmFpbCBhbmQgaGF2ZSB0byB1 bndpbmQuCgpSZWdhcmRzLAoKVHZydGtvCgo+ICAJfQo+Cj4gIAlndWNfZnctPmd1Y19md19wYXRo ID0gZndfcGF0aDsKPiAgCWd1Y19mdy0+Z3VjX2Z3X2ZldGNoX3N0YXR1cyA9IEdVQ19GSVJNV0FS RV9OT05FOwo+ICAJZ3VjX2Z3LT5ndWNfZndfbG9hZF9zdGF0dXMgPSBHVUNfRklSTVdBUkVfTk9O RTsKPgo+IC0JLyogRWFybHkgKGFuZCBzaWxlbnQpIHJldHVybiBpZiBHdUMgbG9hZGluZyBpcyBk aXNhYmxlZCAqLwo+ICsJLyogRWFybHkgcmV0dXJuIGlmIHdlIGRvIG5vdCBoYXZlIGZpcm13YXJl IHRvIGZldGNoICovCj4gIAlpZiAoZndfcGF0aCA9PSBOVUxMKQo+ICAJCXJldHVybjsKPiAtCWlm ICgqZndfcGF0aCA9PSAnXDAnKQo+IC0JCXJldHVybjsKPgo+ICAJZ3VjX2Z3LT5ndWNfZndfZmV0 Y2hfc3RhdHVzID0gR1VDX0ZJUk1XQVJFX1BFTkRJTkc7Cj4gIAlEUk1fREVCVUdfRFJJVkVSKCJH dUMgZmlybXdhcmUgcGVuZGluZywgcGF0aCAlc1xuIiwgZndfcGF0aCk7Cj4gKwo+ICAJZ3VjX2Z3 X2ZldGNoKGRldl9wcml2LCBndWNfZncpOwo+IC0JLyogc3RhdHVzIG11c3Qgbm93IGJlIEZBSUwg b3IgU1VDQ0VTUyAqLwo+ICB9Cj4KPiAgLyoqCj4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==