Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3935C83F29 for ; Thu, 31 Aug 2023 07:55:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbcWJ-0002lO-P4; Thu, 31 Aug 2023 03:55:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbcWI-0002kw-2p; Thu, 31 Aug 2023 03:55:14 -0400 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3] helo=gandalf.ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbcWE-0001i8-Ro; Thu, 31 Aug 2023 03:55:13 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4Rbtjw4Bw5z4wy9; Thu, 31 Aug 2023 17:55:00 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Rbtjv2D3nz4wy8; Thu, 31 Aug 2023 17:54:59 +1000 (AEST) Message-ID: <8da79d04-435d-bc96-b6dc-e2f030712886@kaod.org> Date: Thu, 31 Aug 2023 09:54:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/4] ppc/xive: Use address_space routines to access the machine RAM To: Frederic Barrat , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Nicholas Piggin References: <20230829143236.219348-1-clg@kaod.org> <20230829143236.219348-2-clg@kaod.org> <288cb639-0b1a-9f46-d348-731c201cc535@linux.ibm.com> Content-Language: en-US From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <288cb639-0b1a-9f46-d348-731c201cc535@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=TXcQ=EQ=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.242, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/31/23 09:44, Frederic Barrat wrote: > > > On 29/08/2023 16:32, Cédric Le Goater wrote: >> to log an error in case of bad configuration of the XIVE tables by the FW. >> >> Signed-off-by: Cédric Le Goater >> --- >>   hw/intc/pnv_xive.c  | 27 +++++++++++++++++++++++---- >>   hw/intc/pnv_xive2.c | 27 +++++++++++++++++++++++---- >>   2 files changed, 46 insertions(+), 8 deletions(-) >> >> diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c >> index e536b3ec26e5..b2bafd61b157 100644 >> --- a/hw/intc/pnv_xive.c >> +++ b/hw/intc/pnv_xive.c >> @@ -242,12 +242,20 @@ static int pnv_xive_vst_read(PnvXive *xive, uint32_t type, uint8_t blk, >>   { >>       const XiveVstInfo *info = &vst_infos[type]; >>       uint64_t addr = pnv_xive_vst_addr(xive, type, blk, idx); >> +    MemTxResult result; >>       if (!addr) { >>           return -1; >>       } >> -    cpu_physical_memory_read(addr, data, info->size); >> +    result = address_space_read(&address_space_memory, addr, >> +                                MEMTXATTRS_UNSPECIFIED, data, >> +                                info->size); > > > I had been wondering which is the "right" API to update the guest memory. Since the cpu_physical_memory_* family ends up calling its address_space_* equivalent, I'm guessing the point of the change is really to catch any error yes. > and remove any potential ambiguity about the address space? yes. See LPC and XSCOM for other address spaces in the PowerNV domain. Also, the XIVE EDT but that's more a modeling trick. In this case, the IC is reading RAM using a physical address, so checking that the transaction status is important. The FW could configure bogus addresses. > > In any case, > Reviewed-by: Frederic Barrat Thanks, C. >   Fred > > >> +    if (result != MEMTX_OK) { >> +        xive_error(xive, "VST: read failed at @0x%" HWADDR_PRIx >> +                   " for VST %s %x/%x\n", addr, info->name, blk, idx); >> +        return -1; >> +    } >>       return 0; >>   } >> @@ -258,16 +266,27 @@ static int pnv_xive_vst_write(PnvXive *xive, uint32_t type, uint8_t blk, >>   { >>       const XiveVstInfo *info = &vst_infos[type]; >>       uint64_t addr = pnv_xive_vst_addr(xive, type, blk, idx); >> +    MemTxResult result; >>       if (!addr) { >>           return -1; >>       } >>       if (word_number == XIVE_VST_WORD_ALL) { >> -        cpu_physical_memory_write(addr, data, info->size); >> +        result = address_space_write(&address_space_memory, addr, >> +                                     MEMTXATTRS_UNSPECIFIED, data, >> +                                     info->size); >>       } else { >> -        cpu_physical_memory_write(addr + word_number * 4, >> -                                  data + word_number * 4, 4); >> +        result = address_space_write(&address_space_memory, >> +                                     addr + word_number * 4, >> +                                     MEMTXATTRS_UNSPECIFIED, >> +                                     data + word_number * 4, 4); >> +    } >> + >> +    if (result != MEMTX_OK) { >> +        xive_error(xive, "VST: write failed at @0x%" HWADDR_PRIx >> +                    "for VST %s %x/%x\n", addr, info->name, blk, idx); >> +        return -1; >>       } >>       return 0; >>   } >> diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c >> index bbb44a533cff..4b8d0a5d8120 100644 >> --- a/hw/intc/pnv_xive2.c >> +++ b/hw/intc/pnv_xive2.c >> @@ -240,12 +240,20 @@ static int pnv_xive2_vst_read(PnvXive2 *xive, uint32_t type, uint8_t blk, >>   { >>       const XiveVstInfo *info = &vst_infos[type]; >>       uint64_t addr = pnv_xive2_vst_addr(xive, type, blk, idx); >> +    MemTxResult result; >>       if (!addr) { >>           return -1; >>       } >> -    cpu_physical_memory_read(addr, data, info->size); >> +    result = address_space_read(&address_space_memory, addr, >> +                                MEMTXATTRS_UNSPECIFIED, data, >> +                                info->size); >> +    if (result != MEMTX_OK) { >> +        xive2_error(xive, "VST: read failed at @0x%" HWADDR_PRIx >> +                   " for VST %s %x/%x\n", addr, info->name, blk, idx); >> +        return -1; >> +    } >>       return 0; >>   } >> @@ -256,16 +264,27 @@ static int pnv_xive2_vst_write(PnvXive2 *xive, uint32_t type, uint8_t blk, >>   { >>       const XiveVstInfo *info = &vst_infos[type]; >>       uint64_t addr = pnv_xive2_vst_addr(xive, type, blk, idx); >> +    MemTxResult result; >>       if (!addr) { >>           return -1; >>       } >>       if (word_number == XIVE_VST_WORD_ALL) { >> -        cpu_physical_memory_write(addr, data, info->size); >> +        result = address_space_write(&address_space_memory, addr, >> +                                     MEMTXATTRS_UNSPECIFIED, data, >> +                                     info->size); >>       } else { >> -        cpu_physical_memory_write(addr + word_number * 4, >> -                                  data + word_number * 4, 4); >> +        result = address_space_write(&address_space_memory, >> +                                     addr + word_number * 4, >> +                                     MEMTXATTRS_UNSPECIFIED, >> +                                     data + word_number * 4, 4); >> +    } >> + >> +    if (result != MEMTX_OK) { >> +        xive2_error(xive, "VST: write failed at @0x%" HWADDR_PRIx >> +                   "for VST %s %x/%x\n", addr, info->name, blk, idx); >> +        return -1; >>       } >>       return 0; >>   }